From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB3D5EB64DC for ; Tue, 27 Jun 2023 15:25:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CBF88D0002; Tue, 27 Jun 2023 11:25:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37BB18D0001; Tue, 27 Jun 2023 11:25:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F5928D0002; Tue, 27 Jun 2023 11:25:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 118798D0001 for ; Tue, 27 Jun 2023 11:25:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD09880A6C for ; Tue, 27 Jun 2023 15:25:09 +0000 (UTC) X-FDA: 80948901138.12.1CF4E8B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id BE4DB1A000C for ; Tue, 27 Jun 2023 15:25:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gF3SuW5w; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687879508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vhqu6XD+ruq8OkOqwki1HcqcvHS0A0VxJzjy8VCYPok=; b=cprYrDcLPRR2Fvo24aWgJxF6R8rvbvgxupSPvyJs/riE0hp7pTKwRpoTcAcG3NzybX5hmf c9acwNX/e3gNo1gndKP7tdvd/dEqObBrKOAyMDXh9jhVnly+8cg28oUSm+4A02oPqWphD/ /uGciuF9da1MFBulRTDI+r5CQO2fpC0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687879508; a=rsa-sha256; cv=none; b=k1fiXn1IaTilBVWzDyydgQ6SCRayUS5aU/j99Rdzis6bLRzIC++VIol5Lez2HIE88L/1Xn aHHLl3K95R/LbvNOFQ2mEN3X1WGKKCxiAz1+psIR+DO8oemeGk9vT4JK8kJfx3Ce6qqa9l GbPlgFtC1cqk9Eex0YFA04ohasdh4FI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gF3SuW5w; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vhqu6XD+ruq8OkOqwki1HcqcvHS0A0VxJzjy8VCYPok=; b=gF3SuW5w8QlP57FlWiVqozsltn qL4gcSC5D9eBV6xSGUahoYZRBX9hMcnXeEyyg6H4gARpZVJD8RCmUfP8H3iOg80vFMtIChpurZqr5 UKKvD5fwjqQJHIIxCRNb3VmMyfJfrNvMzm7SfMtPfsuve4rwYnFs0r03ws/ugfbnaOeZ5KJ5x1VVB cRPSpv6zjlXN+fNTonnSN0L4WpsWKxjnd06FAEIb+GojSj/gGdJhSf5dx9lVxB5viYmNCbXXMQyjl MGAmLJijEtfpUE669GKOHBWN1xRzfNVCltfJAD5Qq74qOalF30o32nUZffq03IcELOK+TuVw34+un +/5fyhWg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qEAYy-002qIS-Rt; Tue, 27 Jun 2023 15:25:04 +0000 Date: Tue, 27 Jun 2023 16:25:04 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 08/12] writeback: Factor writeback_get_folio() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BE4DB1A000C X-Rspam-User: X-Stat-Signature: 7s7e44axhut78wp5g4kr64mwm81npcn7 X-Rspamd-Server: rspam03 X-HE-Tag: 1687879507-472470 X-HE-Meta: U2FsdGVkX1/OJgEOIsz6AoJH3M2MKHl/81dKkrcIBjQXjEfgepBfAsiprygF3z1EUyjWxwCcLfBL/w24nt9LePGYtEpmGYG4Hdc+iE7x5h1yVelGuK7RHlD0kBVkaKcwECIuUztTIV5BXHY2oRMedflsSaJwgrG7wv/m8TQaqmg8EiDp/bNROqWUAl5Ll2MgWYzIyNWFCRSJ1Zl3+MzqmR6aKmKnJhibDK/b4lpk0UZC0uLIAGbny1KKz9zqijHnC21+1G6OWRhBnA7Lb+IRBBWYg9TOaKA1RQ0JSo6JrfAtzVmmkcMsqgHj55Wg6QFpz5A6fORouKLbFm5fY0QkF3Imcend+uhoZsiNOQPOPSS1NHccyAg5LDmM03tMOV83ggiiaErGzVGcoJgUET0xzKGPy5qpNUQAdheXWoNPRFcG49xGT+TKZuU6QuRpQBK7anUqhxiOcdHC69BWT2ctcPApsZimxYsnN6YNPD1vfxGDmuBnjoxY3v7etauoH28cV+EIb2bKOj6knrWNmVXn7D9yA2ib46qtwbzirf4AVpgMx2TELDsOQ/LqVrn6o0fQrgm7L0E6OjDthuQUogx95dNKx0A8gxWgwsecnzeM/0iZ08CWgwvzDASQD42YzJca4LBB7+FgF6kkqr1QG3oJXRKMkVZSBbArPDUUc+hWMgtmEfRPB61biv9lmR0pyi7EyLnga8EZVbrj/BPyD66amRHWi0SopE9hlL+wMRujFIzf4P6cd6J3qb0AzOVexdIy8dHVapZLcU1xC1bO0DK5VjDwA3dy+Dd1l5U0u75uQ3Xz9DzHtXyKiGlHRYUTAGbUv5QlX7vR5sZpjproKACYSxTzYfq0fdBMWXQQyXVgGg8BduNgBOZ+p55YqkLr8Upvs3ZIC+kHzhsf8pKg6H05QBLY4eol8Ox9lawe8Hf9A3IWN377taJW0IwUy7pUUhyAtNLB3Q+Bdw1tLeM8CKy dTzXlQDj JskpCFXv7+Va9CM0hIXRQ/CWRBel8P7fkZgPikBZuhN9LefMv6qj1N96Fky2uwDmidZ2ohRWxZPKjjp+4hNfwou1KIoVlsqjoXWXc3w8S9+XhDTWARYlNMlrZ6OwUJByh9hMpnv/16+YsF9x8rPq0zuv2ezHgaOXSGEXGDSHXm6VKcdiE8pV74TxDfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 26, 2023 at 09:34:17PM -0700, Christoph Hellwig wrote: > > + for (;;) { > > + folio = writeback_get_next(mapping, wbc); > > + if (!folio) > > + return NULL; > > + wbc->done_index = folio->index; > > + > > + folio_lock(folio); > > + if (likely(should_writeback_folio(mapping, wbc, folio))) > > + break; > > + folio_unlock(folio); > > + } > > + > > + trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); > > + return folio; > > Same minor nitpick, why not: > > > while ((folio = writeback_get_next(mapping, wbc)) { > wbc->done_index = folio->index; > > folio_lock(folio); > if (likely(should_writeback_folio(mapping, wbc, folio))) { > trace_wbc_writepage(wbc, inode_to_bdi(mapping->host)); > break; > } > folio_unlock(folio); > } > > return folio; > > ? Because we end up having to call writeback_finish() somewhere, and it's neater to do it here than in either writeback_get_next() or both callers of writeback_get_folio().