From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721B1EB64DC for ; Wed, 12 Jul 2023 00:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF2D06B0071; Tue, 11 Jul 2023 20:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA36D6B0072; Tue, 11 Jul 2023 20:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6AD26B0075; Tue, 11 Jul 2023 20:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A3DAD6B0071 for ; Tue, 11 Jul 2023 20:46:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E6DA803E1 for ; Wed, 12 Jul 2023 00:46:41 +0000 (UTC) X-FDA: 81001119402.19.BD3982B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 9F2F4180015 for ; Wed, 12 Jul 2023 00:46:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MjxJ4ePS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689122799; a=rsa-sha256; cv=none; b=dn9qflkPHaWXYgz78YGzsbj8UUNL8wQRCJORNp2FKU0SNFnHWjLRgqeSh8Mbk3RoMqaDLH pdG9HGog0+dhEeAT7qCl5qlVSpLY09kWDBVpS5F0IN4gwVjVDUHP4129G7IdwUrWsg0bIN sONUJFNOpA1pOmKWYdmIOVtZOFpMmKA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MjxJ4ePS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689122799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vuMz9r50CK+igrSG6zWU18FkXs8hvCJFWii7yehFB7U=; b=HdzX01R7kAocWXOhZ8VkOL5P/AU1zQRu4nEY4SmzlgpXNKyky898VZRG3CoBwsv5/TRm1o fibxRX0vzMe7/Y96XPckNvEs1b+XpPsHb3ynn7L1KR0K/JVHnvKGU5E4fA6CPNwwLgZ2Us j0xt+ijZ0uhWp5AUCRGMHtsL9IM8mMA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689122798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vuMz9r50CK+igrSG6zWU18FkXs8hvCJFWii7yehFB7U=; b=MjxJ4ePSZgt4vRcXsQ9MZ3sWpbj0yJD0avb2tobjNJ4ICg/s6EhA6jH/z1ocBNrfAt5Q3E YiKRo2+SoCYBktfCW7KxZLPm59gRZ9nAgj2dKy1YjZxH06616u30DfEoSMtytrPYLnicgK oKCjlqwZhpf74B/mT+laqnLh/z5LQAo= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-UqLtC1v8M-aI35IVovLruQ-1; Tue, 11 Jul 2023 20:46:35 -0400 X-MC-Unique: UqLtC1v8M-aI35IVovLruQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC44A1C47671; Wed, 12 Jul 2023 00:46:33 +0000 (UTC) Received: from localhost (ovpn-12-61.pek2.redhat.com [10.72.12.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4830BC09A09; Wed, 12 Jul 2023 00:46:17 +0000 (UTC) Date: Wed, 12 Jul 2023 08:46:13 +0800 From: Baoquan He To: Simon Horman Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org, eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, derek.kiernan@amd.com, dragan.cvetic@amd.com, linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com, linus.walleij@linaro.org, tsbogend@alpha.franken.de, joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de, maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, frowand.list@gmail.com, kernel test robot , netdev@vger.kernel.org Subject: Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Message-ID: References: <20230707135852.24292-1-bhe@redhat.com> <20230707135852.24292-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9F2F4180015 X-Stat-Signature: 6bmbe6obf1r8szh6u8ujxm5p65yunz3u X-HE-Tag: 1689122799-49984 X-HE-Meta: U2FsdGVkX1/VAf49/P4xcAopITDLSjmZCn+P6w/hsfbHlLQB2My5ESrxia27xY1GAr/BmIV0SaGqTKkVli/CoTyhnDaAznhnhEtk3ENmn+HSWIACkMtMFZ2104UrAZ1IX+slPxubTH7YgzmlUS3wsGD4p38UvmACE72p5pMVh+z5znVbSKOYDTk5OeZJG9/x3gGzAHhXv3F3kNfW9KGTIO0K9MdPYYGp/azPuYWL8IXR/kpPc5LmrLlJVttKYXsHuEXK3M9kmTak+Whz8GRL2lBJsuOaqQutwqPzaNwT4tIMAeUtKU6+/eV12x7qenbFo2ZZnTCykM/JscDmqgcVRjx5ytawQ8wZc2qZswZyALzrZj7x+fMBgcJPUHtw/DVGVMx1sDfMkbccpKDzb6G3YDbU+1X3udmL7b/O79zALsgnDNMsliZPUSlJNjfc6s50bLBxq9HFwI21QxCiO7Ex/gt7/8KX3qDhp4jzG3p066BbjZiMZVDjVjxdnofUbp/yTCeoa5Ugwl5bqymaEVgJr3bh5Y364l1ev6jucmBf2wAITfi9Z+mHSKQNyw/zUa8ae9fD04qRTMK5/NqMyOpucwzJeYucXb++szA4cnVp1DT25G/7uoNYP8mknjxFgbJ2DiDkUPzwMDz2cdsIMdckiofsaZYKmuUSdUynKtYGr16iyfH8dx2C892HUrzrxK8Lu94hzTgDl6A4H+CgYloWjWNU75pKn1mskMy52q86gJ4QlH2FpmqQbCc8A/R9NtPMsKj3gYOeAuLK+uccsrFTisUJ+kCHxbSuKqDuigRfBpyqQ6aOd09FGb1jqWicOTmspZFLNtvWGrSvhT/uL3bjAtRKAm6NnJdp3l25W2WR96EBzcB0nJ1rWytGM3uHxfPW7XzCKG336NhLJudPwSotm8/jVJ77QlFDQFDiVia5JSJFGIPYsH+5fDaU0PBoaF2eBvKTaiLBoAGoa2EMoNw aZv5+aA5 HSYMYx9r2LhNBn+r2/NGDXsTx8arGgfU43g8/62jhfIeJ8ztVxv2lWcoKJk2hgz3XOE1U0vhbbTAHLZfJDypIsJMRMIiy7SD8GEvn49IN56/a5jFcpiyU2tl8X8DxRLVV4UeRGEWu+tXZFr1JCzlAkj6XNyTDzha44XM0YmMwabNHJPf0cSRWI+cH3pqCd/aNZASb5HyzcsoKlASuwpZb10FlF4n8amhXMTAgqhyguRzjXvswhheImtZEjaVsx82vGFsLUvYCUTXtmlt4JO/VXWs1FiZzpO2/xNRNNZKqn6M5Jpbx84L6kUwTshek4x0RdghP081Nt7fzJFf3/urO+p7DF8INL8w3LO7D/GCUBSAJu3q5qqVNXWVebJolbXev5rFw8+v3IyTZrNFURmwgjc2mPb7DSp5DJVceFTBw/KqKRNsExY9nRRxQrCkr25HDGcNDOZRPL50CVKDKGY+MkkeEWqTnhJTC3WrxsTT0uCSFlpE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/11/23 at 06:17pm, Simon Horman wrote: > On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > > to cause below compiling error if PCI is unset: > > > > ------ > > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > > ------ > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > > Signed-off-by: Baoquan He > > > Reviewed-by: Simon Horman > Tested-by: Simon Horman # build-tested Thanks, Simon. > > I wonder if this should also have: > > Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig") Agree, it's worth having Fixes tag.