From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76A8EB64DC for ; Tue, 11 Jul 2023 23:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F6AA6B0071; Tue, 11 Jul 2023 19:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A4246B0072; Tue, 11 Jul 2023 19:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16CE26B0075; Tue, 11 Jul 2023 19:58:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 02EBF6B0071 for ; Tue, 11 Jul 2023 19:58:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B947E803C2 for ; Tue, 11 Jul 2023 23:58:39 +0000 (UTC) X-FDA: 81000998358.21.3E5645A Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf03.hostedemail.com (Postfix) with ESMTP id DBCBB20004 for ; Tue, 11 Jul 2023 23:58:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VqHN+PWb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689119917; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xwas20+/U9dKqwODq7tDJPzox3WCbpZzdCnRyM9Eykw=; b=QjZCdXSmheSEF49M0uzDTXd2zCm+jiia8smAk8OFE6eCUJvAZWurkmTv73t2dUkbpVjBFp iH20TywP9PFef/IH7+D6+ufKDFuknscMqZyhYwPNDEGqiuidw8B+MrWw7NEBfKVWseSN2U g04q5Tn3ccnV6TV/I+VvVyKNz4xYXRw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VqHN+PWb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689119917; a=rsa-sha256; cv=none; b=HVENgt2U2PQYu8zqf/u5W8ZNquINnaWBsB8LYshfKW8Ylho9aR0AFMIIlUZCMFwVcImsey 7PpjmrAUT5YvjMeIFEmrSLuQrBDhLAFaCnfqHLoXHCdk3/oLGXs1DSuyF8dPOgODqvyQc+ HtJZ/tuPHDrBYKIEcQMUu8OaR6sGuTA= Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-55ae2075990so3407274a12.0 for ; Tue, 11 Jul 2023 16:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689119916; x=1691711916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=xwas20+/U9dKqwODq7tDJPzox3WCbpZzdCnRyM9Eykw=; b=VqHN+PWboxKi+36+B6+hERfi07qQGPyIyLP2uKp+C78Gp/xz+3na6RPg3fHQcnXKu6 uLkeurLTvqcejUb7rwRJVoxYY3/a2hF5v2OMVncDTMIGbUN/ZhtJ1Fb9QVFn4QL4gfrg ZDsZ6rDlxPrxr8mfZiZ9f+oFeN/PUxU6vo1LcMIEfmG6nTDTLr52Q/sQRKBimipTSdJ0 //9o009HZumhdQ5xMHIBgN0Un2+IypivcXkOObE712twuf7hgWxwDN8FhBAiYZGDiR6c AmRzmS75U/5HDmkCYV07H1mhT+Y69YDzuukdKBvicERN5S3Wz4HwU/NOsGxV6ys80vNR r5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689119916; x=1691711916; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xwas20+/U9dKqwODq7tDJPzox3WCbpZzdCnRyM9Eykw=; b=eU6yljT4ZGJF8qYCe+oGmg7UbNRrYhkr19AelJxa6EM4KDFwG/VE8S8Ln37En3weji QjVgb18XEjTMgZSdS1YQ4g5hNoHwmDxDiYXplgQ9Th9db2absBFhZEKwIHsJUEUmOmZu lVh0BDe8cvoF4El25TMIrlUycKaxyYkfWSJUo1TaJRe+V5Fsky87kZLLle1t09T/Z2Cu 0NVx8M1T5S2cN2XtqKjL12oAt0qeHaIMSd9Lhmdg9vBipZZbR+2ia6R+LsdMexe6ObdR +P/NhnHfqjH+gQxsfAwaqFYxhQ4kIBgxlDhGUWN6quJYTiO19+66+iAUSfNPek7w/cbo ukUw== X-Gm-Message-State: ABy/qLb0F81lKUTKH00ksg8gV7szCIot6zSFYz3VROTRf2r+2Nz/wuJ+ VMz+NvcOWHGIEC8tijB9YoE= X-Google-Smtp-Source: APBJJlGit9Y9qkDVVZ5OqygR9G78YvGP7ZYq1trdvSsmkbH5VrFJKYQMueSXDNaI+Ogc5alIYFYGVA== X-Received: by 2002:a05:6a21:585:b0:130:9af7:bfa with SMTP id lw5-20020a056a21058500b001309af70bfamr11021757pzb.60.1689119916468; Tue, 11 Jul 2023 16:58:36 -0700 (PDT) Received: from google.com ([2620:15c:211:201:97d7:e05c:68e1:2c6a]) by smtp.gmail.com with ESMTPSA id h10-20020a170902748a00b001b830d8bc40sm2521053pll.74.2023.07.11.16.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 16:58:35 -0700 (PDT) Date: Tue, 11 Jul 2023 16:58:33 -0700 From: Minchan Kim To: Alexey Romanov Cc: Andrew Morton , linux-mm , Jens Axboe , Konrad Rzeszutek Wilk , Seth Jennings , Sergey Senozhatsky Subject: Re: [PATCH 2/3] zram: support frontswap Message-ID: References: <20230710221659.2473460-1-minchan@kernel.org> <20230710221659.2473460-3-minchan@kernel.org> <20230711100848.ctymfhdy6bp3lin5@cab-wsm-0029881.sigma.sbrf.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230711100848.ctymfhdy6bp3lin5@cab-wsm-0029881.sigma.sbrf.ru> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DBCBB20004 X-Stat-Signature: 7sptgnhgqm1tpht3ehnt8ota5isy95pn X-HE-Tag: 1689119917-929480 X-HE-Meta: U2FsdGVkX1/WdbtmJRnjfcvWsCnWGtOx+UbBa/ltj6g6e+GdWcRaFyNfiJ2RrLJ9RfesJH24TqwxUXdnLGn6czTDeS56D6InPGsrGaEU2jH4R2wAJ7BpYIzDPq/zFw/NI7oV9EIRqn3FuuTWdApCAQPWn+rjS7r3rkIrn2KsYm2Ujzg2vSmxPmX76NVdgq+v1Xmk9auUcGApMkR3FzCFzMcBXX/lTKJeNi1I/GyoSk5Z0IyDpM+D5MVmraWTYcxlF5qSJzuyRwMxArwusAhupM/nDzd/MxPsOsFBtMVbQx7MPI66SbihAx3XzCybvs3wvjTMqCr+yg/ixLelJ/uSFj/iGShHwSm5y3XoaQhHQpsZE4Eo10qkH9SwMpHYDzIuMKqxbf6uoU0IHsX4WO8/yDjCCp30rw0HDcDyGMzMDzsym6/fR7f0b326MqYcQBRFMw9/pPDxkvYDjbjFsOjCW/cpi5HN1PHU4yLsZKnIqA7EBOSONgO+e+OFlRQDP3kHVh+89OBBR4svYH6T1lfuf4+VAEl5Psr75iphp3SHFR/FfN98o8uCOYo374oTiQMOGW491jn1TeVpU/ttUeIu+1Ri82fEKgBu0lGgtMqERna4howtiDfriywyRQUUAG4W8vClPFxjENt4CYuWGW3OQ5p0Dz0CQ+hj5xdHnpc06OqS1krZSDnPZ9n8pi+slQzl0erbAof70JcRt1NQa9KgEJhMhOySC5Hd97osNK/I/MF8+yf+5dRkLIG7AOmlGiyY2ddTycWwiQw+ABIVekIngHLwmFCO1kiYYSWKbaKQrB4mVuKgwys9E4DX86rA2BCMfQrYK/Cxii8gwtPpNFlCaEyHDsBMouOwdThEWMjQYteNeEbke7hsHLV1bDJgSmwpJ7jwpVkg67eNvCagb5xPey+0G/JVwo4mVRqmWqYEX59GON5Rxv6FjrsBUbfWLiztNMv+HPqNpTaqI52cYkv OFnv6g95 D4Ikv/+51yL3Rt0kb2S5kr731VdmRJOHJW4Xgp2tl1M6mvKzFlXlXV6KPjuI5LL/d+kqvPBbtT0UYDsF1GooZYNU/K1VpDZgmrVsCFoelIU0Wn702it+CGNen4Ow6HgdOB0nGGk8520bOWy5MqNN0sXF9AG2y+DFeWfchwlwGzA6DMx/yj5197t6S9ZtpSLGgO1Ve3n0X0ryVJCZ1/UFXj/EDBj1GP0fwgAWA0v0OebEnW2Fb+gpWub4JA1LELLsHa/O4XCbOyo4Q8P1dm2OojxWAqr9b5QUlLOpSfsfpEtJKJiy7XqDtZdFBWvj/qGg38XzGol+oI/Hd0X3wcSjweK7NCh/938eQgdS9odTvaZLPO860uctGO5JYiNOiqPXwq3EzpupiVJJTYOG0NdBf7aqb+LD9+PTt4gTwXGH0G7hIjD9KoiebKunKxtu6qDhqD1yudFMn31wbFDDXCf+2QkO1qzL3XpSRgqicfAgqPUqFl+QXjfgB6VcqH6V2Ld+quNiFH/kYl+zsJrDUP5+8hCr6q3/5SBRC1rhurlNNvkEgUot2JFg3VYByr67xPMtzCC0yVeYK7cwT30wKUkz1+ngdACTgoIIexdR6nj5RssIvFb7Qi4OztLzfBVAYeMqByQWzTfGgTOPGHZze82v3OUgjKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 10:08:46AM +0000, Alexey Romanov wrote: > Hello, > > On Mon, Jul 10, 2023 at 03:16:58PM -0700, Minchan Kim wrote: > > With frontswap, zram can perform swapout 13% faster, which restores > > its original performance with rw_page. > > > > 200M swapout using MADV_PAGEOUT: > > Before: 4355ms After: 3786ms > > > > Signed-off-by: Minchan Kim > > --- > > drivers/block/zram/Kconfig | 1 + > > drivers/block/zram/zram_drv.c | 98 +++++++++++++++++++++++++++++++++++ > > drivers/block/zram/zram_drv.h | 1 + > > 3 files changed, 100 insertions(+) > > > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > > index 0386b7da02aa..a841d6d14c74 100644 > > --- a/drivers/block/zram/Kconfig > > +++ b/drivers/block/zram/Kconfig > > @@ -4,6 +4,7 @@ config ZRAM > > depends on BLOCK && SYSFS && MMU > > depends on CRYPTO_LZO || CRYPTO_ZSTD || CRYPTO_LZ4 || CRYPTO_LZ4HC || CRYPTO_842 > > select ZSMALLOC > > + select FRONTSWAP > > help > > Creates virtual block devices called /dev/zramX (X = 0, 1, ...). > > Pages written to these disks are compressed and stored in memory > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > index 5d258a28ec43..5e973c982235 100644 > > --- a/drivers/block/zram/zram_drv.c > > +++ b/drivers/block/zram/zram_drv.c > > @@ -33,6 +33,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > > > #include "zram_drv.h" > > > > @@ -2170,6 +2172,90 @@ static struct attribute *zram_disk_attrs[] = { > > > > ATTRIBUTE_GROUPS(zram_disk); > > > > +static struct zram *zram_swaps[MAX_SWAPFILES]; > > +static LIST_HEAD(zram_list); > > +static DEFINE_SPINLOCK(zram_list_lock); > > + > > +static int zram_frontswap_store(unsigned int type, pgoff_t index, > > + struct page *page) > > +{ > > + int err; > > + struct zram *zram = zram_swaps[type]; > > + > > + err = zram_write_page(zram, page, index); > > + if (!err) { > > + zram_slot_lock(zram, index); > > + zram_accessed(zram, index); > > + zram_slot_unlock(zram, index); > > + } > > + > > + return err; > > +} > > + > > +static int zram_frontswap_load(unsigned int type, pgoff_t index, > > + struct page *page, bool *exclusive) > > +{ > > + int err; > > + struct zram *zram = zram_swaps[type]; > > + > > + zram_slot_lock(zram, index); > > + if (zram_test_flag(zram, index, ZRAM_WB)) { > > + zram_slot_lock(zram, index); > > Looks like zram_slot_unlock should be here instead of zram_slot_lock. me/ slabs self. > > > + return -1; > > + } > > + > > + err = zram_read_from_zspool(zram, page, index); > > + if (!err) > > + zram_accessed(zram, index); > > + zram_slot_unlock(zram, index); > > + > > + return err; > > +} > > + > > +static void zram_frontswap_invalidate_area(unsigned int type) > > +{ > > + struct zram *zram = zram_swaps[type]; > > + > > + if (!zram) > > + return; > > +} > > It makes sense? Maybe we just leave this function empty? Sorry, it was wrong version from my git tree. I had destroy zram in the case originally but since I decide to drop this patchset, never mind. Thanks for spending time for review, Alexey.