From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2507CEB64D9 for ; Wed, 12 Jul 2023 14:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63D8E6B0072; Wed, 12 Jul 2023 10:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C5E06B0074; Wed, 12 Jul 2023 10:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48CD66B0075; Wed, 12 Jul 2023 10:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 370DA6B0072 for ; Wed, 12 Jul 2023 10:42:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D652880263 for ; Wed, 12 Jul 2023 14:42:40 +0000 (UTC) X-FDA: 81003226080.28.01D2729 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id A6D2080008 for ; Wed, 12 Jul 2023 14:42:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zhBomEzA; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+8b06b5fac5f44d4f4265+7262+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8b06b5fac5f44d4f4265+7262+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689172959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f3+120nI0qsDe1YJ27JG6TM/bhTy85me+uHT6vnbIBE=; b=mvr79A5KRep3qgYE3tBIzz2BT7RnFzX/hKX0d9IlSlpz4ijKlV3uD/UiITN/+ORJ48AMFJ JANGRhsGDMmk4RjRFOOw92XG2hXfQ6diT3n47/tGe7zaOj1+xROnKA0CEf8ghkLhE9xoT1 Jn+UrH0Ls7XryKbyKWfhdCutO+xzbOI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zhBomEzA; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+8b06b5fac5f44d4f4265+7262+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8b06b5fac5f44d4f4265+7262+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689172959; a=rsa-sha256; cv=none; b=SB/1jG4d2k2QoCeRRrCEYFJEQmFWLj5NXSc8EAM+sh2B/IKWesItcJJ186QFQHoNYtP6kH 63wGkHW5RMUDuJ6FMVzxbIrWjcto8nW3Aq7vaaiN+/qFac7nGPiwsvMZvRlYAXjLDkK6Dj jyHZLs0WPGAnjNVCoKLnJGqkhITYScw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f3+120nI0qsDe1YJ27JG6TM/bhTy85me+uHT6vnbIBE=; b=zhBomEzAEIF6Wet6D0dCEHoDc9 okuiGV0HJ0zEb/6g3KT+kSOccac4dHYgXzgmsDXpd5wZ3ei7dOc22BhinkP4+RJ7NCVBTzXcBv0a+ mkdQEaNEfbsySg6JXBXksLnyMs5HzC1sQyuqHi9VEKswmzd+kYtoaru5bwiCoPxrcZUBp1cO/xy0y bCCdNiZ53tTwhsypKPiuSuZw7PiowQJiG+Lccs0ykZtxq9QACS+jqeeBsft5s18KqNPAfTUUX1Wyk FGYopr5EI2NQOSV19zN5vF0sLOsQE6sT2ANw/qeJXOTthiv+T/qnW2z43h+s7zvVxmvcr5LASvDU5 VUeU2pGA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJb2z-000EDU-2z; Wed, 12 Jul 2023 14:42:29 +0000 Date: Wed, 12 Jul 2023 07:42:29 -0700 From: Christoph Hellwig To: Kefeng Wang Cc: Andrew Morton , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 3/5] drm/amdkfd: use vma_is_stack() and vma_is_heap() Message-ID: References: <20230712143831.120701-1-wangkefeng.wang@huawei.com> <20230712143831.120701-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712143831.120701-4-wangkefeng.wang@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: A6D2080008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ie499duiujz8ycecb7e5xeb5mnibnnhr X-HE-Tag: 1689172958-977881 X-HE-Meta: U2FsdGVkX18qhn7NzEVp543Pvf6Hwrv17DBFXxG3L1xSyGO5BWqgA5RyINa+9Pwn4uFMczUJnOjMcCwR37+h9N7oCeRIC4VGQMvJxZfa6IVfVWg6qg6YUDqFJCOynb8rNuOYNkPOI902N7At3luMoHCmnKktLN4oUCqSXJxnZntdC0+ZHVe5RqsrUcx0Yo2fmjfBl08oJx3eoG4gs+oHDWjoeMOLiJZHAm2NciA3ber9c54C+T5pgjS7NHGygMWyavTs5VlLaj2c9FZnGszofz68k4tcdIyH8Ea6DPzzZ/1BNKvlPuZtXHhZY41lrMoQDx9OfogqFn6U6Tx0QteB7n9Hl17g3YyAib0dwrRd4vJmmLh//x/tQTX0b+3phZ+eTHiebIoibLqUfikPsbIpOeaI6SbMtUIM/WF8eS4A38Jw9Jy7SdiRIYId456Hym0Y6rVFqIregdi57qwVbrq2wOF8PAE/hVUq2HkUH87EiEITAwiaQJKANSfFbuMhV8zuKWtA05vChaN8rXIFsH0mvb941dTMJRaASOXJ4pDufsj8yrh+bLLa07zuNH8Tw2wuhBpNPlR/Nn/qNAs7cs/0DShvmjRXn7uO0aOz+YwnnG37sgcoyn+hN2eC+3lahyKZaA0OUD/Hn7TjP86flYAjnT2zM0wD1Nun6Hl3bqofpyeQLg3CqVPTDiNRhr6rVYmgOQgswzOH9QXBJ80A8Le23xGV54ao4qlXCvDNJy21zu/ygk9rt0tN7MYhljiPVnrv78O588JDYxk8J0TdQLyDUHwpYIfhVhKFU2OkBHE09XP3+tOgTIyJk130+jQqYCU3AIcRkiGAnod0Bb5ZLAsaparkelNw/b+C+5lo7iEMVvWwdi0pC6CSDZQigAr411kzyjaSFionQZxI44S2h/si+K0QHG9QhNyhiWrexzI1O4VPk3F2ZtIIwLpCIOMM7M7aK0vbvJ59bgL9oq++ucv OpY8b4+K Ktw6V18/ceZuDbVaZDYuVj7DuRYNsNuQ7JzkNl1wT27zo1G8/fcxjC8HIKlmu6yJG672Tb8VAiSb9j5caUYKZztpf+f3CeZoYPbZwiDqeH4wxof4DquBtFt+Jv2+69xr15Xw1p+VgvJNf4sturCM44f+sQmWwcn2kEEuewr1LEOuOF1ruUjJkEEEyt+3nKjN2y5xWvkq5GZ5JCnsit3rJFf63jrmyn6z5GosvU9RYhXaXLrLocR8uKW5MJBBClW9ttaCXd0+Uu6BX734aCGMDn53w3toRFWntvLEZzJOkLRmxqDumQXz0aSWaIJn8stlKLMPsnfG2XBE9G7jSAOBTfh0uTV3gYyeEn2y9/zCMtAM4bc5Z6GsIbMetKDwZhxVkNTb8dUYIJLSLotQfPiUipor0YlcWjd6u52SVM49eYO53qSuqGNIQQz665A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 12, 2023 at 10:38:29PM +0800, Kefeng Wang wrote: > Use the helpers to simplify code. Nothing against your addition of a helper, but a GPU driver really should have no business even looking at this information..