From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F76EB64DA for ; Wed, 12 Jul 2023 19:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F0788D0002; Wed, 12 Jul 2023 15:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A0046B0083; Wed, 12 Jul 2023 15:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88EFF8D0002; Wed, 12 Jul 2023 15:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 79B316B0081 for ; Wed, 12 Jul 2023 15:34:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4A4B88011D for ; Wed, 12 Jul 2023 19:34:22 +0000 (UTC) X-FDA: 81003961164.25.9342A02 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 6BBB7180015 for ; Wed, 12 Jul 2023 19:34:18 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OFcjsESF; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689190460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jr3Hl7WNOAwqfNKmA2uBFa05ZlB171lqpcl0qJmQ7Y=; b=xp7AT7JbLzZ+25jcC7t5chPOeCOXBU3GmJI79kYKWT6M28Lu0MjnwJkbudhIA9iDTFAzW8 G5tBT2U7OJb8vcNt3/PGrPXUvZNjbgPK2OJa8R/pjlDUpkO3xY8bCCOU5tlRat1ddHMh2a uYnKD9rKP4Ry3MwowvLwdZIdqbEPqEg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689190460; a=rsa-sha256; cv=none; b=v5DOMixUAP+0Qm4aas3k5ygV8ZbN85n1Ll6rk7F9EyY+qysmVRj63JdOwNjfhizGKtbmy+ /8dNWBKf5DIAvmdUkpkLyjs+NdUpykzz5EoX4aWcT5Ul0WfBvvDLmNVLWp3jVHb2vhvOvH Oz2OprbQkB5PLcOPu1laJ41L7Ws3D1c= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OFcjsESF; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5jr3Hl7WNOAwqfNKmA2uBFa05ZlB171lqpcl0qJmQ7Y=; b=OFcjsESFVjYF5RT4m5RfiYHvu4 Jly47BLJZiqswU8YRVI//wmYGAPxtXZiHoVfbrovi7ETU4sIZ89m2F2YZXMY+tZ6RYAj5ktf2sV2p lq9QcQlhW4Kd0TDHYKgx+l02FbaroRfnHLpMJRX3kK6Ik335h2E0iYUa3dIkqLEyUgZs7nWzlDy7m roIkWPOF0A3z8wcseqp1Y3inbhDZFomcF46//gAUOmDV1/nZQmWlpXOi45ctIqIcSeS12Qt9ABlco 9RBJhsSFNtj/qUuC+iaV463DAwtO43EvP3ym1CNBfCq/64UWGxbcws887+L9SncCX3TJe92OSXbmU V3RRzkZw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJfbG-00H1P2-RB; Wed, 12 Jul 2023 19:34:10 +0000 Date: Wed, 12 Jul 2023 20:34:10 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Suren Baghdasaryan , Dan Carpenter , linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Laurent Dufour , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Peter Xu , Dimitri Sivanich , Mike Travis , Steve Wahl Subject: Re: [bug report] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: References: <9704a138-60e6-4ede-91f0-844e1df2ad84@moroto.mountain> <331201b2-5f13-8e81-b5d4-b17f8784d498@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6BBB7180015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: webieajmtiy6y5uzykcbexz58mgiacnn X-HE-Tag: 1689190458-719620 X-HE-Meta: U2FsdGVkX194S8VYndJEQCFiXfe20jX6Nv8zvg53wV27JFTBjFmFAD6nw2P7YcgsIC6pTV3YZ34AVcV7x7xj9JLExxygP+diKwn/VhFnjD6hZ0KRgH5Je+/c3u4RgkDm7OD3epSYRwJ3deZdroqwdLg3yQD1IuhGSenRCSuYKBiloer9KN65SGUObEoA9Y+b7ziJl6T2hhMSx41/ZMs+UAdkwpuvRhnLK7vUX1Djr99iHxGOqiCoAhUIgbpLr/hqxQsdZsaHnogR95+ugKY44/ZgGY4Kxm7uaCrZcM1j9LiuyvrLwHZXl6ss2AtgRkUW2jKvgtiF3Bi/mUVMtuAoLTdQTtV2uIPchIpC5MEsftyeFHjnclCPpcU9Lufg0UwPqc33CbGPY7JZiXU92OEPxxYeNgFX1tkN2eYxphvZvIijnx+1vyCpbgDX+jrHuEkUxh5NuyWqj7UnpEg1TxtNMFF0L4KqF/jy4LDcGSD6cPd4NbhrO+EWJ/jTnJAnYYbCh2eDejffogB4CtKXotMnt3uEBEB9evTgC+LWT0loDC0JLb0R9VHFKpw7etwP1uC54qxtGgY3xv0EZwEkAOpbux0zJsXvWGmuzBOWOAwIXxHspshrWcRs0Xn4cD99vNcNeLIWlr62O7ibFJrd3jiTh/h4nHxuGCz6A6NggYMtKNZX6O+xQMdcVVhPcCN+xDoc6myHrMJ2qOvvZcbdTIuupdbClHuvMPtHoVG/epG1ezcNvzdYJvEELkwErz10SaQJCGA2mrrW+zPFwKnT1evkN5fg+T6sLiSVFysoFStRf6T4pREgQTjAr4jLQcJC4aAw9HqDnjjbdMFcAWwYj3v/taYNQoNa66MMnMd9aDzTMiVUtFmACxSoZBNvdEvTQo/qmhgIhxg5bAgCl+MN2FU01IN3Xq1raneMDVnWMUc5hdI+5LnPirZ8cYuc3e90JHqnnE9ObDfqTNnBx9TfUZu JdEuDuyG raNEF4mmpKrmZXtwKGGg43kYeC3Ts7H3E0RxYZPzgIe2aEmrhSpE0A1ECe6kH+Njy0EZoAF1TC9Q/hvC5r4Y7bBr/cg297+RT9ERQm5o04yVbErJE4eK1F/OgRoamDFvhgi2l/OOt3OZ58lR+pyZMqlAnye4PwnAXoVB+fNviBK9WClefJiOFucsx9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 12, 2023 at 07:49:53PM +0100, Matthew Wilcox wrote: > @@ -964,9 +966,12 @@ vm_fault_t gru_fault(struct vm_fault *vmf) > } > gru_load_context(gts); > paddr = gseg_physical_address(gts->ts_gru, gts->ts_ctxnum); > - remap_pfn_range(vma, vaddr & ~(GRU_GSEG_PAGESIZE - 1), > - paddr >> PAGE_SHIFT, GRU_GSEG_PAGESIZE, > - vma->vm_page_prot); > + > + pte = pfn_pte(paddr / PAGE_SIZE, vma->vm_page_prot); > + ptep = vmf->pte - (vaddr % GRU_GSEG_PAGESIZE) / PAGE_SIZE; > + set_ptes(vma->vm_mm, vaddr & ~(GRU_GSEG_PAGESIZE - 1), > + ptep, pte_mkspecial(pte), > + GRU_GSEG_PAGESIZE / PAGE_SIZE); > } Argh, no, this is wrong. The page table isn't mapped at this point. What we want is a cross between vmf_insert_pfn() and vm_insert_pages(). Let me add that ...