From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DECEB64D9 for ; Fri, 7 Jul 2023 12:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 706398D0003; Fri, 7 Jul 2023 08:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF3D8D0001; Fri, 7 Jul 2023 08:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3498D0003; Fri, 7 Jul 2023 08:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 539548D0001 for ; Fri, 7 Jul 2023 08:46:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1B0C31A0D73 for ; Fri, 7 Jul 2023 12:46:37 +0000 (UTC) X-FDA: 80984789634.02.990FFC7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 750A9C000A for ; Fri, 7 Jul 2023 12:46:34 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aRcME96T; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688733994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=epRwf36yVmCI0wCfpPMQq9jRILgggfDPrqVrqjBCaHU=; b=OnnYB8UhI6+L+16dQlmQznexCCiLVkgRg2W5oJ4l2ytB/1/VvpkaQgxzb+0jmcla/jumSi GLm2JJ4ZCQrVpJ3MP8k5lQJkFbP5KDz8Iq/zYWA80diqlGmGEqzXdUlM4hQ0xiPQzvoqJm Bs6tfTa7gueNnoY54weshMY9NVKo/JU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aRcME96T; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688733994; a=rsa-sha256; cv=none; b=WeWO6sbN7b5KPnntXRCXsVrqBG81Xtdn4f3ce/B0dgqQ1WrBKm4+Fgdh3+1Clz4yT7MeU/ m6QK4z4M53JVubizNPGBESBrQqPkLcOcBFrwfxyLqwfgCHRlRIJbqbWoEnW7bxs5cFSzxs eqUbopZG9NyAdKQBo8CtsGhUsYSgH4U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=epRwf36yVmCI0wCfpPMQq9jRILgggfDPrqVrqjBCaHU=; b=aRcME96TksAYGGy3xhnReI37vC 5vl2uIBCN9A8Tje4vTHDc0G5gPxthtBsNPG/mabnhgWkLg1hh7FNtFbJ3LRVn1mr6aHBOXgCp1GKG 6+EAsjOhy6AyH9NwB76t7ISQALA6g3SgxnG5fo998wq79otfqefffisrYYgPQMaNTW1LnPnF9gdyW uTTfX+xTnghYYA8ZnX7MwIJEH1fiRGelBGIe1F30FOTDbUYocTRS67jwjZRdkVhy04QhYMLWL9V2L EoWg6Y0BRKwSZYvkGogB3bYF+Hn4OU3LxHMuWa/IzLxEU1ekKD8vnAcuBXeDH51qUEpFrqlcMTs36 4LZpzHpA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qHkqw-00C1ck-Ly; Fri, 07 Jul 2023 12:46:26 +0000 Date: Fri, 7 Jul 2023 13:46:26 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, pintu.ping@gmail.com Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug Message-ID: References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> X-Rspamd-Queue-Id: 750A9C000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bqihwmwtxejnmmepuecgd9kpnfyan15w X-HE-Tag: 1688733994-194875 X-HE-Meta: U2FsdGVkX191Dw+edyJtWB5STIUX7Du2EASN8X5sCa1mNUOgafBf9ETEw2GOLgp2UZzw/HqvvJf7MTuL/ETtcv+XIdKKygdQhyp6BFshngInPoRQGW7co6vxD83h6oDivr6XbAG6vMBccS1FL0XjfWLubjDV8lJIWcXoix74ez4WGQZvNc1kA0PPYLhWHptKS7gbwUxgeJSN/E4D03gW4NEqk+QjsQFL58Oje+rjBFSajKwwL2FNTKicdRhwfVAX2B+/gISngh3xT/+ZEYdXwEQ3lTVxn8Iuq6oN1uY16e/Ex5CMp2rhrNkhhQnUsUuH3upvc0EttZmE1EOEY7tTnOQYq2rcye380mUDyqw3iSv7nYNUHLCVCrt/u0fKsjeP2OA7ywBuku9CrKi4Q+tqq8EhMGi3IMh5mlKYN92Zw7jzSQtkE3yZmO69SRLN1mP9nx9aTcmB4Ttms8b/PIpyeoUM9pBweg9cT5fw5YEt4DNoxex9u5LQE2qbUEObrbiqF1kF5ko4WFRMemy1lYbL3C+9NblDPuFsbN7OeB7PksoocWhfzfsf0eQ/Vp6CflzVvIGwt1jrKInZCUEhNuqYjWbh4mGiDTxAPOcngfIV2ChXH4JMokujsVjN0OTz8vlxWjeVleqkBl7VokEDbUBMbJtPHbT8jklIm3omZdTiqcWKckVQ7JOoYeaNk4cAYh+oQmKi5ttaEZPa1mNedmF5g5l1ZjhfTUCYjAIDiDldbZVEBviZHhB6A0pKZsEoiOiqRsqL5PuA2t1GN/z4OKev7+as4pCSu4xYALgwL6REE8ZXZQEjcIUAfv7Phtaf3ulQzv3Yi2CYxpgBaILSRDHSLYwFYw9YNx/4JoH/4+C3xF3W9Jw3qxiZ4XEV6uvBB5syHTT//S7VmYQ7lKPcqXNdkK466rT8X0G1Bt0GPdyFSYAJPUl5nsmWoALjVBX3uQjM89WZB6mbu44VIgoGEkn SWmQvHVV D8w7h4b+fTGflGfO7hHoDx+DPhGz4SnLjnPz8TbWCkxZc0yigj5KZyprvJyMohtbPIjc+4mdWUFMRtn7yRVhZZF1tuoHdz9DhS0HSfCUolWkUpxU5UH53hrv08+uRPh5TQqxmCIbiA74K98zu5ke9qWxPggNbN0oUqx64jkShQDBA03wpQw1wkcKFBBDkP+t47C+EjgsCZ1qgp3ajppYTUJVEN/nFXeH1Bo/SP9d8IPDbL4xKROmTbK6jp19o7DAjhXzm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 03:57:42PM +0530, Anshuman Khandual wrote: > LGTM, cma->name is an identifying attribute for the region for which the allocation > request was made. But how about using cma_get_name() helper instead ? Very few call > sites have been using the helper. It's not really a "helper", is it? The function name is longer than its implementation. cma_get_name(cma) vs cma->name Plus there's the usual question about whether a "got" name needs to be "put" (does it grab a refcount?) I think it's useful that this function exists since it lets us not expose struct cma outside of mm/, but it really should be called cma_name() and I don't think we should be encouraging its use within cma.c.