From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6892EEB64DA for ; Fri, 7 Jul 2023 14:22:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D005B8D0005; Fri, 7 Jul 2023 10:22:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB0FA8D0003; Fri, 7 Jul 2023 10:22:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9E3E8D0005; Fri, 7 Jul 2023 10:22:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ACF698D0003 for ; Fri, 7 Jul 2023 10:22:21 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7A141160DDC for ; Fri, 7 Jul 2023 14:22:21 +0000 (UTC) X-FDA: 80985030882.27.5001884 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 61025A0006 for ; Fri, 7 Jul 2023 14:22:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RQgyGV8d; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688739739; a=rsa-sha256; cv=none; b=ZEWve4Vuz/9IHYEr9zVWikCbmPUygpIer/rSRZsdBiEWKU2ZkR8sF95IVq1VYGirkb/U6V x1l4hXEbfuAGHtwLn6zkTtzqT0xOYZe0GWs3+DlZDsR9fipoeROLT4G4G3OvjtktrcKdqY 9GJB5Y4OsnW+dqda1869j6ld2EtBLrM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RQgyGV8d; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688739739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+YSopFfs/Xp1rj/0X1dHDDq/oR8SUXSZqyGCDyjotRc=; b=vXRkK1HjXyeR9B+X7Ho6ZIx5x0Ov5muDOkLH6/m6YaMmjHN3QShA9MhkS2Q5M46Rblh1Xr jHlPm67PpBfezara5OFUgDVgX+XO7EBgLh3hkM/WpV7tD+Huv5pzUN0o8tR8ghBjYdnvIk ivbDIEDCei1OPoMhiGT1Z4HYsLNJJ5I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+YSopFfs/Xp1rj/0X1dHDDq/oR8SUXSZqyGCDyjotRc=; b=RQgyGV8dYkwnQHsJe5kgrgMrNG JgRzOXyhUHfh1GwD4UYlFoF3sGhBbkB5BWWFBToTIZxbZoO0p2PWs6BGllgvpB2VwmAbVwfqkOX42 d2JaRl8NWHPUV3ZtzkiINLLt4djx5vePTPhCxCuBytVA+0ucyB7ddt+7GXwf5SE+BzJrXHkrxj3ee SWmhbLbe9gI7XqnbgD3Uaae9YDcKGaA1I7uvPJmmpW0pqLwcWQnVwwRYhILcTWYUAjEPjOlcxLjAr XkutZI4R956ROn0Y27V0lIeHkB26Vdo9K2WIUHWXVCS8JWq9AWQclmMTXx9hoS0VD0I+FObFCjnLQ J4kvhmww==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qHmLa-00C5Tc-RS; Fri, 07 Jul 2023 14:22:10 +0000 Date: Fri, 7 Jul 2023 15:22:10 +0100 From: Matthew Wilcox To: Pintu Agarwal Cc: Anshuman Khandual , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug Message-ID: References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 61025A0006 X-Stat-Signature: oo7iw5cycfeajb74b11iqfki6aajjpdd X-Rspam-User: X-HE-Tag: 1688739739-463127 X-HE-Meta: U2FsdGVkX1+vDrJDAa3TU7jkFhwSJLSW9Js9p9A2QSQnucy4LUqrUo29B4gmMGg3D4lBIc8DARqRYF2jJwegNRebTa6g+iBTkZb/FoHTyasuMTpKsyRkojwlccl6MOMNxJZAJieRHlebqCZFHpjc4wv18XhzpuuLPcpau1GZeNONOyK0D8CmRZjbyE/5NKhx034K87L5Dr4vk4Dt3+b+/9imCwviDGgA55ZQTdSug6BYMRY8YHhvckyxWps+G69edurUJxDqtks37ztC32bSaJ6Kn0x5rMDVhc1C7XcN4s28mTxt50MafaH2biZTG6/xklOXqfWPxVt/reQQofSnVrHBPLsZ7VcrDEIdO+C+HX05UvdTlIoyU+HpgKYm9lsPK9gOyiyX+XlGHe6DakK222dxJkfvXXegYcFt001JEtRgp7ajT4A71hntJ8DTMU2YXe3JRJYvJVmFGDhs9rZFeQ4xBsfTEuQyjYEWMv6L8MEqIN6A7Z8HYCI8uKv/d+2/9biLty91iDMg4Rxih4klB/btxediTXGUV79bwnmFcMX8g8Jw9bCFtqqsfHgxDYvPQ8kel8szcoOzpzG0m3zuI0y+qZ8kjgNteQQZWEa7LgQEYUmpmxerkvjYB5nGmvtyi3F7Kdtzt2S0IzuJXvRV/qyjMRe8xXo+8ijaYKzBbe1BVTf9ckB3gJ/SKiQevNwKWIXz4omYBnEL1E7HsXHzU5TLyhAAAmDrhnWxT+bMVp8dAfnLVeyuFa+YZSUmj/aZuxYGreqxEyt8LSfQm6gINKkwtW6v5cDTiegH/3DP/kGxDtza7Xh9y+NXxEgiqqVI1ioKgJzaMoPukBczBdAIqn8KiOLoWZO6F/suVESrDk0N0qa22lucf8zeEGaYkAgAg213vXisJetStXym6rVwlZGQ0ZLCuKQleBZt8vSKk0oKB17ElsmTFmYVI5Pj5SNSrmBAajoLlW6tWiZHiw7 qfJwa5be xeLIDdDXxVb81rSqANyJeblIkbdaqBl4tHuwo8ofY9s6mvs5JnFQztggjTffZpHfYA/asag2ky7GRu2FaDRi1mG6uJiLvRCBySgCiVEr7jK/cCFvk/HzriK3nb8prCIGQy7Cp050BLB+wiO5EnqDyXg9bFxJjhXVgfJr/MujqP5BZ8mE9ywpWjYc3k5uDIDqGZY4DP5MfUNx0bmlxFX5rdhBrXZHmdF2GIsRYZtFuX8yKcLJfxhKD8y0J0jj4gdgnBExLSMX8ICWxM2Q+GsuA1NP3k2/rKyLaiwZGbZwdFriDBVeeSVNwgbRNjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 07, 2023 at 07:46:31PM +0530, Pintu Agarwal wrote: > On Fri, 7 Jul 2023 at 19:40, Matthew Wilcox wrote: > > > One more question from here: > > > pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, > > > (void *)cma, cma->name, count, align); > > > > > > Do we really need this "cma %p" printing ? > > > I hardly check it and simply rely on name and count. > > > > Printing pointers is almost always a bad idea. Printing the base_pfn > > might be a good idea to distinguish CMAs which happen to have the > > same name? > > > No there is no name there, it's just a ptrval > cma: cma_alloc(cma (ptrval), name: reserved, count 64, align 6) You misunderstand me. I don't know how CMAs get their name. Is it not possible for two CMAs to have the same name as each other?