From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A01BDEB64DC for ; Tue, 11 Jul 2023 02:33:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 153648E0001; Mon, 10 Jul 2023 22:33:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 103918D0001; Mon, 10 Jul 2023 22:33:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F343E8E0001; Mon, 10 Jul 2023 22:33:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E10778D0001 for ; Mon, 10 Jul 2023 22:33:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AEFF11C7D10 for ; Tue, 11 Jul 2023 02:33:48 +0000 (UTC) X-FDA: 80997760536.01.55018ED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 0E5FC8000C for ; Tue, 11 Jul 2023 02:33:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q4EthXJN; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689042827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eBi5Sle1mhrJmlnMF1Qke0Mk1HZnEVe25yA516AMawM=; b=CegnRGcsrLmQ/69N4UBrFxPvgIo2JiRhJg9RGhee+S6nn2qRB30XoEwTOaC220mmwBTq4C Gz2xhgxP9zcDujn9H7wECwBy0ZGwRTE7ap20MiqYnccuzUI6Pf28q0STzIGAeiV5Sw0Xc9 p3jBB7QNH2E+R6ZrhTim96ys0dwl1Vw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689042827; a=rsa-sha256; cv=none; b=YcERIFClqqEMYZohhYUSG/aKS6ts+xsSHEAAosFqwdN9dd8W3upfK0+1OIoClUzLZGnItB YNhdWvqPkiKV/4AxFi69RV/P17rtNAI8j+M4JUyszVCu02uX1cKXtFVJGVmrtP6kc9K9+1 I2PRAkX1yVSLp1U/I2oYoaQAIYK+Vas= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Q4EthXJN; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eBi5Sle1mhrJmlnMF1Qke0Mk1HZnEVe25yA516AMawM=; b=Q4EthXJNHeEea8o3FgrQLtG1sd y54Z8zBaxl82GvbRcHWj2OmpbYe5Uit5tGKK2T5WgLLBQkXQqdhESakQvUG/Vu6rRWbb3Vi3vGk8x ZEQmFOraO9nlytl+rH8xjYx0XcIjgwkf/okiniPZGJUAa2W4o1MCTLKDcH5X+SJVmrp2cwkyoDRKt tLRlzFKz0nBEXq/9dXdfO/DXIIXh4l+VJ84dlZcqnrj8ChN07FJAZI9YTm1lzuMAoM/N7cdSsYJnV G6YcYKf2DdhpmkTFX/mpmEE/+g/SiTge2ODujFR0sLl0fpUc8w1HkT3yl4kNthLyIPTupv8UgR+5L smyFHClQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJ3CA-00FDgX-Uj; Tue, 11 Jul 2023 02:33:42 +0000 Date: Tue, 11 Jul 2023 03:33:42 +0100 From: Matthew Wilcox To: Andrew Morton Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , Anshuman Khandual Subject: Re: [PATCH v5 04/38] mm: Add folio_flush_mapping() Message-ID: References: <20230710204339.3554919-1-willy@infradead.org> <20230710204339.3554919-5-willy@infradead.org> <20230710161727.7a676996b64e9885cc15eaeb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710161727.7a676996b64e9885cc15eaeb@linux-foundation.org> X-Stat-Signature: o7rpspap4ofh156kqosnkpkeim45wp3i X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0E5FC8000C X-Rspam-User: X-HE-Tag: 1689042826-160767 X-HE-Meta: U2FsdGVkX1+mJzKPLxndXm50GwE0hbFtc6dz7D3/F70GK9V7Du8B0e7nPkbLFHBcxtS9srNbt6/ecDcTJqomonHzrEVcvwW5rL7Rz7EFtM4wlEGlapvEvtodAIEF6M+wHB0kGQqK4pQOLOoq6DWZmvxW44SJQ575y/uB22g9TZ2wDwHqgxHwUjTSWuIHVQ7Tiw3Y9ik9O4hUkieeL7U22eCSSfGUG2PhCRSg5O/3K7HzBvN07g7/o8zuP6QC/qJNYm9irCbsrNeEs017V9Ujrast8gr2pVgVcVZvvXOG4gwI/iWZrqi2eezASZ2QXJ/4Gv8X3Fs1NchEBcK4gnmLjJLUsreBx5JCr4zzAkqnxPaGKFGrx8kj4I6N7fbHk6Uc35YKAazvmBKym15dSnPmNQT+Lg71sQl/4t5QXsyYOkizBy2n1xRLhmXhyz5c4Jz3CnCfW5QI4u3iIALU2e2xSuzxb6/gYAnC06sTT5ZfYUcKjQz6RWecZ57nezkQn5VFW6L9jkpl46zvr7Kt5ppa8/Nwg5e9v+9mUPPF3RBp/qnmMzgCdOwz5Gxw+VSjT3/R65kNp/IQTwlcVMk1LDu/w+UY3NhzJUK++dE2cR7SgX5xcQxjExdNCxUTes4LCPMtAey3D1CSxxXxq2W5fq6u8pMC4Eby2VKFeJ+P1ExQWn1UIUgfdYDHATp6yrldHTSCK6pu10N8f1LVjRkhRYx6iSEhjQ937C2UY3bBwWAx9wlKqh106wl34O69Vgm3AI5Ji2UORrHX7U5aTM431yjYcb+pCW/XzmjpH3LByvdpQTfcOzwr7FhlzuCfARFaV8vk4OQpQZgKRby9pj7neVkQBSn/E0Sp1fcSr4y6ehnMi16fXBJ1elMzIgvM0o/edpIBJjH6O3BqLoRnkFGMekOl52vyYm4JxrZf7Q5+o97CprUMaBvWpb7d8onHeTzWUD3R3v9ILLOOTwvdAgueLK4 F/ZEPmHL jJ+HWRiQaoNPa9kCXzcAV5GBdMVj2Gu/UccALGnVgzHX4Z0Tw8fpMdMG+9BZNyFAbf/2R6FdYXbXrQorBBcoVCQsR66x27vYa5frhpS44T4CnraKNjAbpWLwvH/vAKogxXQoovDahxzBXVr3VjjOl5tPLOgxGGKF8BrOzQ/eWDtF0H616fy3bztDxEpRSxYC1C/3oNe/Ve0RmVrgMjNsPI3sHhQzSrM+bfAf7khKcIxU9Sf4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 04:17:27PM -0700, Andrew Morton wrote: > On Mon, 10 Jul 2023 21:43:05 +0100 "Matthew Wilcox (Oracle)" wrote: > > +static inline struct address_space *folio_flush_mapping(struct folio *folio) > > +{ > > + if (unlikely(folio_test_swapcache(folio))) > > + return NULL; > > + > > + return folio_mapping(folio); > > +} > > The name makes it sound like it flushes something. Wouldn't > folio_flushable_mapping() be clearer? Yes; I wasn't a big fan of the name, but I wasn't a fan of perpetuating the page_file_mapping / page_mapping_file confusio either. Do you want me to send you a set of fixup patches, or will you run them through sed -i ? ;-)