From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3691EB64DC for ; Tue, 11 Jul 2023 05:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 276CA8D0001; Tue, 11 Jul 2023 01:18:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2263C8E0001; Tue, 11 Jul 2023 01:18:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EEE08D0002; Tue, 11 Jul 2023 01:18:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 026A48D0001 for ; Tue, 11 Jul 2023 01:18:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AA4CCAF57F for ; Tue, 11 Jul 2023 05:18:01 +0000 (UTC) X-FDA: 80998174362.10.4083781 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 524E7C000D for ; Tue, 11 Jul 2023 05:17:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GS3vt5JT; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+77046741297d6883d172+7261+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+77046741297d6883d172+7261+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689052679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eLCiqBQt5rRCWROchXuKftJ29ZljgP81G4wCNq6Sl3o=; b=IQ9J/cvEkqgMojwMHdREsW/O+1VkCfmuqJBD/+B6cWznfTQp6A/7OV1YM/aTTnKmgSJA91 /RhBtES8gm2rQV7Pdoda7sndwwLT3Xz40aevqno51rmRGO3icPrkiJmdgoxvt3JMcTM1hI sIPr1UiM4M4oVfuVNaNh5nhxsFLfiB4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GS3vt5JT; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+77046741297d6883d172+7261+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+77046741297d6883d172+7261+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689052679; a=rsa-sha256; cv=none; b=vRC3xduwT+gzk4SvoEX9X8ncBbIkn2YN2rWTjnMHnhYIGTx1OfHXookjn1euxYUJjq1jfS P38wNnujivegYeAXVSqLGclUYzm8W2Cl2NJCUbZfX9WqjzXm7fpy+hbX00Gz1vW1Lu6FiU Jet2B6paXdQWfcaixuytB4GABQamHic= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eLCiqBQt5rRCWROchXuKftJ29ZljgP81G4wCNq6Sl3o=; b=GS3vt5JTkrcVDoeqd6U8DXRuC2 42AuqRL/4aGLcXR2fB1L2/B+6EnEfrTFmFLnybGp8dCfTSLuhT5+OH09z9jwWgEDsLHlHSIGnhwD/ Rksv3Cx3H+B+QMh/CETpGbXx0nTVwOWLMQbEf1bmqSFZ8XvLtyZeW9eRK0s/ZzIgCi5OK1MaIedlW argZvCDkhyTdwt49nXbqi9AWuTYQ0NjS++iTa0eNk+s+THM/VRErkcGCJpRfHZUT/fzTT1ofL12ko ux1lsRGHue8Q+lis8Y9xRJfAmWj8XhmX2wKbIawENLRvR8/Tn8fLqMxKPUVI7jOwfCbce2HZGCoPV NRGGwtpw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qJ5l5-00DjXR-33; Tue, 11 Jul 2023 05:17:55 +0000 Date: Mon, 10 Jul 2023 22:17:55 -0700 From: Christoph Hellwig To: Minchan Kim Cc: Andrew Morton , linux-mm , Jens Axboe , Konrad Rzeszutek Wilk , Seth Jennings , Sergey Senozhatsky Subject: Re: [PATCH 0/3] zram: use frontswap for zram swap usecase Message-ID: References: <20230710221659.2473460-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710221659.2473460-1-minchan@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 524E7C000D X-Stat-Signature: gbssmkrrjpb3xuw46wp3ayjmoeg94adq X-HE-Tag: 1689052679-201003 X-HE-Meta: U2FsdGVkX1/9oJDhc2bC1EGF2V9QtnsYX14ps4yhr42qq/9m+U84jv6Ch9Fx/teyRXfSpb0aYvexcnOB42/4rVfEG1i7RSSeok8kSSsIF9I8nooZP06B951LbecX+hhCfIUkySkdlQxyFvtmE6W3+w3Lt/5n9k3nExtyt5g+EPlue2CK1nQAiSqtpI+73smwVpWXFtxup95vOzYDq/37/y/adNsz6T/ojex/BuHc6Kg+HBqXkaRQb5Xm9AZJUcSDOu1KhKumDhdM4zYP1xCrHmSt87oPjGz/mEc/cOxASI8BC3t+Fv1utAhZbIt+UVa1brnhd8OlKyHIutD7d7nPGtnWqGN/+oHYOKjrKcnccHGoUWH1t8PYg6YIkf2Z0JxZ44/d7Z1P0VdoDaIIFPJAzdkxYw8V6A9KdwEu2Yj//w6VenFFwgbSquTtZWNj+3n80tONQ+e0VSgFfNBqeeHL2plVGepdUQN+hHhKF9yKwZIbEbRWrepzjqBopWRczuUa1LiMYifxnLkETru34szgsnknvB9zq0v58ND5uwzc4jx09dwvPuY/2wxctNYeqmAGGQu2LW6585E1ImoarTLtvyZ7VIV0di43JT0Kr4aLRHb/hUe3UzG6B3vo5DMMCKPT0PJ/BOBY5pxBa+uPUqbPmtph0vjB1RsFnQq5+txpRVAG4f9S0y2jtnE5t6N0NHWVm+rg+WZyL+0bDBSpXkfh+gmKhnkatkY6yDZgINQyZzuawjUfDUjZso8vPBtvYavs3+jOi299n4NYjTVqO3n/51kvOmDDuNrMgSL8k+aBAbXfi8nG1nGHc8N9c2K8NJWjGJc5IuxFCJvKnprUWzVUtfpeqW9WJ6ewmAq6kl25oRqwQJqjnJEoASZyGYSSsjCSnqREuppLf3dHTazd1dBfZfjF+xLI6ZGVcgBdTZsu7LRECvAXakJKQhyz8qmpZ0y7Qu+cC54rQWjlvO9IDll xLJwhEw9 rH/OtQkfyuvifM3Wa4HUnq7kult7otVT8drBy7WtsXIA03iu7fbisZ141uB+xBbgFonbqZ1FRtJ1hoENz2yug8x7gisL/yXXHXUqn/FmPu2kKnLf02bdsXXf0ZcquUBdMntkYoX3piADSJP77B3GmMPppLKIfV8rPObDz1JEWnN49Dd7+j6dSZZJhIzOl1EkrRkz6nm5TgtwaJ6jTtt9azhpVIlfK5s9Cf+HioOV3HPwy0QBBaaQM7jaq5lGBLxdmYdCs6Uwo27fzdNbbAmpshfrWxeodpM3N4HQM1OXReJmQOSHqAznoIhKXxX1WavEol2keYpJtqRLVByG8XeWaJe1a1Q1XECIdV54d X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 10, 2023 at 03:16:56PM -0700, Minchan Kim wrote: > This patchset uses frontswap for zram swap usecase and remove > swap_slot_free_notify swap specific operation in block device. > It shows 13% swapout improvement for MADV_PAGEOUT. Err, no. frontswap needs to go away, and not be tried to a block driver. If you want compressed swap without a block driver please use zswap and help improvig it and the swap abstraction to not require a backing allocation for it. We need to fix swap and not pile hacks on top of hacks.