From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B2EC0015E for ; Mon, 24 Jul 2023 17:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 682706B0071; Mon, 24 Jul 2023 13:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 632766B0074; Mon, 24 Jul 2023 13:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB606B0075; Mon, 24 Jul 2023 13:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C4376B0071 for ; Mon, 24 Jul 2023 13:46:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05183A08B3 for ; Mon, 24 Jul 2023 17:46:01 +0000 (UTC) X-FDA: 81047233764.01.3CE5FCC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 3F3B4180016 for ; Mon, 24 Jul 2023 17:46:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=h28sDPA0; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690220760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5bpwVTVaUqtAVaYcNBEZIFegA2+4WwZEsgW7Px640jc=; b=w1LR8RJ8sfjQ9Sh5b0HEA+XzpxhKdW61Vf6aZsAWy7xQ5NoCRr168rZkQhF5fGFLQ1Mf7l chzEn+eL2grZo6Oc5OUhUOE0zFjjjnPxxofmVbzWv1UfLB5E95cxyMO9pyBNAvX6QL1D05 tP9bIDBbaDzYYYArQ7DtnYuugdLJrH4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=h28sDPA0; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690220760; a=rsa-sha256; cv=none; b=OnV6RwhnCxW+CmhLdkLRz4fHa0iePdYm4/iMYTF8bOP+0O5XNv0FzWhzEVRnm4f1M3e0ib E6BKldWfPJNehL6c+1S1It0QzbUoScdFXZip+P5Yn+iRv/CAv26s8a+QTcFW+oiQosl8Qe VXkHDcI1d0arNZ6/h9PkaVAnZDtIPuw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5bpwVTVaUqtAVaYcNBEZIFegA2+4WwZEsgW7Px640jc=; b=h28sDPA0dxfJ1l6d8qgPu8DaIS fveaNEh6coImuHuXg7JTKIrfvPrOuUxnHgjYKonu0bV6Gc6lbPfjIDhUqlNfcpg1870sRKWHsW7xr KskVhcPQ9T0M6BtTjopSc6851zMvWWp6Lwu701U1UUsL3x842CijjkMa5HtMNzemWoRoJtPLvQe1q DAVSuAtAWKTT+OrSgPT320d0hHhOhM3t6ELZRb/2uNw7S9Rr+HYny/bPBvTuYTHu4rtzc1X3202Ot uaCEbFxWsr1FDKD2mvaYNEYs2UCSjbjyHlht9EvMNpYLXJYcyG749MgsAC9sLYXAZIiofJ06LjT4h +uf+rUug==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qNzd7-004ew0-Sn; Mon, 24 Jul 2023 17:45:57 +0000 Date: Mon, 24 Jul 2023 18:45:57 +0100 From: Matthew Wilcox To: Jann Horn Cc: linux-mm@kvack.org, Arjun Roy , Eric Dumazet , Suren Baghdasaryan , linux-fsdevel@vger.kernel.org, Punit Agrawal Subject: Re: [PATCH v2 5/9] mm: Move FAULT_FLAG_VMA_LOCK check down in handle_pte_fault() Message-ID: References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3F3B4180016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: resafzfbk8j87kpn6jehnogk3dm998o8 X-HE-Tag: 1690220759-997243 X-HE-Meta: U2FsdGVkX1/wPKEVODDyOiHIFhNw6GHcVH4DyfnqEq78wC/uL+tRqjNJzOdIS+hrtgaeqHlpaobs3aNzdqL1YueJG/u2mlQIQuMUR7pV9qD07GUeENB0x2RpVMGf9uPpA9HBbd8vfrdbk/NLEnbCrGJB1yktEgpxDhS8KtsqKD5hovFerRKRfqb55hR+rsLykPBynQXkpPDOXncJFDzpVjHTyPkS5LWrs1aiKb1o3gWxjj5yFLF8iGNEFQN7r+jUtLzSWmfiv2/EOe3tgjwdJNpGJBx1CEbdflKfdCD/f3gSumeYjMEfz0UshR5E48kaqnMlLUU0YlbxTWz9BTV1QCw/6Xo+fRBFuabemlPx59qWqz9ccxoGTU/rzrqdspR5nurggiSUZuDM9e982MUkd8r0PfKe+m9mGEhHfOQrey86PqKa83F3zJghNT2ZuYPYnYlNkNi/Abxaf2iHta6wZnTTOV8U6mWaHK2jtD4UoMCR75Iy5dWIm4CkjAZpTFpks1lLv8RDMN9ykfYioY2nNtVxRdoFtwaFAkUkLALjL/m4oZ27Fohk6F5/c12E7sq312fhFytCMkborfd5xbBedKYKo4SfCHvZhW0KHZn9wJhGXoy33ppmq/XFlx6N/j2Bm36KeF/0jLGT6P/+2AQ9Bpj3QA9vInaWcTHG2C7Q0RXjxYQPzc/MDpGvzsATqjblpPPrWQgTqLmQq9Q/vxECNXbJJYB/AQ5/qFpHepkeuKIzJOHWBnwsgI8CB7/tANT27Jihqo4Aw65zA/gM8kRwzBeAicIU+3lNuhcJE47eZm3cwjIMygDFbfhfxQJix1McL3wKbd1Q7osZL10gHPWDEb9IuPptaYg4oXEmGOyUWO6MzhiiFB7+VihnhLlFib6sW/PbRt1YvQkvWdGe95iP+GAfn+ONJ247BOvoiSZEeprfro58tkO6q7GVb/0ZwoOkOBV8wgZaleipyX/rMna ac+AsmYN uf/PvSC+r0bP6IFkU3ccvIA7JczaCD6ww52+ZKvsOGe/ISJxkKBsiPABdG0D08XFZ4c5xv4/HtEwDL4rteOJX8jb1VXZoT+a3UA3UnjqgGebeKdyVsCgwJMej8/8Q6Puea8pht/NdGt2BPQS+bUFDZPLrdHZxxXdxswsCf2M5hFZLMjqb50LdI2KXNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 24, 2023 at 05:46:21PM +0200, Jann Horn wrote: > > + if ((vmf->flags & FAULT_FLAG_VMA_LOCK) && !vma_is_anonymous(vmf->vma)) { > > + vma_end_read(vmf->vma); > > + return VM_FAULT_RETRY; > > + } > > At this point we can have vmf->pte mapped, right? Does this mean this > bailout leaks a kmap_local() on CONFIG_HIGHPTE? Yup. Guess nobody's testing on 32-bit machines. Thanks, fixed.