From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E57A4C001DF for ; Tue, 25 Jul 2023 06:07:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7586C6B007D; Tue, 25 Jul 2023 02:07:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7091A6B007E; Tue, 25 Jul 2023 02:07:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D1DF6B0080; Tue, 25 Jul 2023 02:07:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5008C6B007D for ; Tue, 25 Jul 2023 02:07:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 103B31C99A0 for ; Tue, 25 Jul 2023 06:07:57 +0000 (UTC) X-FDA: 81049103394.08.545D003 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 513D74000B for ; Tue, 25 Jul 2023 06:07:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QlD7W3Ww; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690265274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iff00GoXaDH4cb1D/MrDupG+dzFdTmhxdlQCFPsloUg=; b=K+vzfC1vcQbc48lUi9jmzztVyETt/wrbesLDV9r4uTFrJVadZ4B999OTLMjgw58kQJ9cBG yyelX2v1UIleYXaD9+xGo9bM0O+HKnWgagCU847Y/5W2bWd+bwAW9BSlka5u+otb/tLpzx 7bY1Q4cvXdqXEv1brmn7x3hK+B1O6sU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QlD7W3Ww; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690265274; a=rsa-sha256; cv=none; b=qhNYWbjJMsmKF+/C2bYTweHz8rcqXKuSFrQKPQHxj4RuxqVkE1r8phT2zq2zBDNl6nrR8d 0CKiphKa5xrmDoiKCq0/pVCDf2VQpsmX0lz9sX83LykK6GfBj+rCrhbIK0b8HHmkxBS3nT x0Z8qw4t9Q5AtOSH2zq25lJ+Q/xe8KE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56A6161526; Tue, 25 Jul 2023 06:07:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17930C433C8; Tue, 25 Jul 2023 06:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690265272; bh=g1caD9CrbR3LwJeOeh9fQXcDn7BjKUbUaJjDJVl9M7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QlD7W3Wwt32cIbOtX7m31Rqe01XgCM1QR4umfbVEgKtJ8KHz/H9F9XbeKH6Hfta5I tVipI5y51fg4rSCaNsTt3DWQPuUmOz5pMrX9NKS8Kh72woVGRyoDdS42QH+6J0QF7k HVKBYLI7HUSwZApcG06ComH69NMZuj/ciA0NvbYXIqOZX3m6ZZfpn1gb+3c+oaiz04 9fMzkRPZM4eu1ov7VGp7oRTlRUrYOdEoll+1lW92CJh8uBQDm7d8LQozNmbX9yLGQg IZ35ydjMZqw7/4hOlHqz3dqIBxdRzVPWUS5o512vFArgCKJRaFay/PNVr8ziTm+FH9 Z4k9PnWe3XPYw== Date: Tue, 25 Jul 2023 09:07:46 +0300 From: Mike Rapoport To: Usama Arif , Jonathan Corbet Cc: songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com Subject: Re: [External] Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Message-ID: References: <20230207114456.2304801-1-usama.arif@bytedance.com> <463c960e-1d3b-edc0-edbb-d5ecbf7fc3b1@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463c960e-1d3b-edc0-edbb-d5ecbf7fc3b1@bytedance.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 513D74000B X-Stat-Signature: ygmoq3rbxen6gbemnbqb6oseheqzw14r X-Rspam-User: X-HE-Tag: 1690265274-583107 X-HE-Meta: U2FsdGVkX1/ifihmQsQTVoYkV0tbSKcCQKVaprNsXp9It/GgM0D5OUsXQm3gFQ+lHaNFFoHTgFIWt7SPqr+qOrsJiym9l7pfe7cX7iZAVDXpVa/sAr24/s9Ie/Q6V1SpO2l0eQqh4kYP++1kOVGnD42mM8+5nU+NtpR6KfA/nQvKtH1nG1qyYymvQ6gLa13vL5iUuqbKFvN13BpU2kLWxFEPWcTOm/TAn0iO/6dfXzIO+Txx2v5UUQUKjtio3IPhy74jn/IcmG6MPhnwooS4RfaGMVuN37B0cT6L8kr+z3JQ9h7otObChJHW3WbotXJ1Ss4QYpnKgiv4vEmsCUoMGes/2WMiXXluUj/qlwEPuPikqSmdpjvbBs2cV9JH8Ux13Gx39OnL8l88AUry/g8wOtxFWM9l9NjsWa66JKuOM8/vUmFbcVqoYfd5U7A9nJXWRwLyh/8a0+98v9hqwrRQtVJdeNC1GaQRTuwyyCp5j37VoXjt+n36xr6aBzPbhs3v1zgwV1J5d0k1Ek7W645qTpP8KrlAXV2ELlY9SOofvwMca50DDHuIsKdjsTnLMbCg5/XNjCltiUpLEaHOdSpnQ/coJbwJ+INCwlDLc43ndSWq/qjmkJDH+lT0PUHSfeBaO0JCU8IwDxNiYUq7bPiTItGtxKVQ7s2xKZZalhxHEVF6Jwi86ij9How9l9JGlustHu94SWDAm/nhAtP9DV7vF7Fp6dcmErkXCM8YGXGzJ6roxcG9wNH74xyro5GvICu8wYuH3nk5cMpX54Bwrsu5qZHiwYfUQuuDAWHefPXkO/wipj3pTS+qeb7O9O4lMMZOoRX4QomUW3lFGH40+4U8yPpHBKkCxocXMKfLk9nY+9XigSr1X/XeCBoxR2sFBULNLd+izieaCoToQdOYOEzFlSdIoQuN0dNBdC+FzOrpUB2FvgFIrSS3IJRJ4DPwk/ELeNpma016BrZ/bxz7oWg WYt1Zzb2 Yl5wRsXks2qi+KsMVGtDfjFuGUvwgnM72fFeAGBC4XY4bB51J3dUklcaYtCjInIBRKXZbWyRXG45U7zHfblFTk8DsnKhk1ytBrEGbe/vcpEy7iIH7s0BK1ZP3FIszbgypiQcK/kMhgz+qRY/ZlcSv88+6mvYhkfckLCukzwObW5cjsATaauVuso+e3ijL8bEPgrLi2VNHIdvyosA2o6fG106Dm54GK2x8MuVzrU2/zK9MvOR2LMOLqCtrLf8ujC4/8gDkmaoXRhODXNV2y4/kOGhcgQ6mHd+cA0PfpdmsOzDTyiO/pDRCymTMgXDpVl7MBEbgmvyiBShQNkM8zAGigPLzvRO+sW3XM+a+qk7kIv8z7uyaVLs5wXToJR58GDf8IGrQQBTowf+3lp0TlGD8zdMEhWuPenq8beV8uxs03j4AB69uqtLGktD25vtETfSUll6rjVXm0pTYOTB1nq6OcWUOoqyExotMKZPB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (adding Jon) On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: > > > On 08/02/2023 09:51, Mike Rapoport wrote: > > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: > > > 1GB HugeTLB page consists of 262144 base pages. > > > > > > Signed-off-by: Usama Arif > > > > Acked-by: Mike Rapoport (IBM) > > > > > --- > > > Documentation/mm/vmemmap_dedup.rst | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > > > index a4b12ff906c4..689a6907c70b 100644 > > > --- a/Documentation/mm/vmemmap_dedup.rst > > > +++ b/Documentation/mm/vmemmap_dedup.rst > > > @@ -1,3 +1,4 @@ > > > + > > > .. SPDX-License-Identifier: GPL-2.0 > > > ========================================= > > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > > > For each base page, there is a corresponding ``struct page``. > > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to > > > -- > > > 2.25.1 > > > > > > > Hi, > > Was just reading vmemmap_dedup.rst for something and realized that its still > 4096 pages for 1G, maybe this patch got missed? > > Thanks, > Usama -- Sincerely yours, Mike.