From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2672EB64DC for ; Sat, 15 Jul 2023 03:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76D4A6B0071; Fri, 14 Jul 2023 23:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71C5A6B0072; Fri, 14 Jul 2023 23:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60B0A6B0074; Fri, 14 Jul 2023 23:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4E13D6B0071 for ; Fri, 14 Jul 2023 23:42:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1976C1402DB for ; Sat, 15 Jul 2023 03:42:22 +0000 (UTC) X-FDA: 81012448524.19.267D532 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 7A2A5C0009 for ; Sat, 15 Jul 2023 03:42:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="P/pMrUwn"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689392540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yKjL48l7aPRw8IocgRlVRY32V+vRxNKJ9cdRkCWL6qw=; b=dJOUe73t2sCctzEQoO2D8gS1c7foIoYuk3alq5vlupjAtlLospVH2NVe36pYYPGrWyb2nk wj2LhZ0tKJzSMqA7hut8E+0sD9P7sfE+dqmpdfuS9CMFSdLogEyxYVfxotzl8e/xvaoke2 vO8zgMZTog+yzwpDgoHhhKR33iHaIbE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="P/pMrUwn"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689392540; a=rsa-sha256; cv=none; b=vE1yyKL21y6FDRthf97tZJuYnUECvRcQUgryXLyo2L0y+S58CVI8RedMSV2IBbvK6zbXoM DEyTU1sEuBuvMcSEp2N/zbvjCWTw+6wCadUCvEbSGCZk52dwx1PibxEN7aX/2PjU91t9fi 7ewQZxZpUMM69DpzWeu7y7i/K0b6Tdc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yKjL48l7aPRw8IocgRlVRY32V+vRxNKJ9cdRkCWL6qw=; b=P/pMrUwn5P9Y9d44vXU4s64xqn BgNAcSxwdu1J7hdcFr3BjWrO2ghT2IqrRnE4doa/NqWIZ/J0V4oYz6Ye2DH5MtI/u8WyZFfPfoC91 hNogEZnp4Oxya0+y/OQoCUMrIQfUdwaKfFBblKAkx4CnMgMphIpfYPEZoCUR++BdKjswJJWKXfnqh sU7eQJ5T4zsfC3q4qMPjKReOCKxek7xt4sD+smSPs7beK6OO7iFelmM4Sr2fcuAXn3Lh3b1CHjqRW DVZAIcNPceUHWSO2lUSyy1xI2ZY6y5ijetd8lLv3f2uD2wNtla9ZuM57jct1pLcDWs2fFBIVqu/Az OJYLOvaA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qKWAf-001nAv-9W; Sat, 15 Jul 2023 03:42:13 +0000 Date: Sat, 15 Jul 2023 04:42:13 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-ID: References: <20230714194610.828210-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714194610.828210-1-hannes@cmpxchg.org> X-Rspamd-Queue-Id: 7A2A5C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ajic3odxs9cd8b5zjyzto9icqi1owg9p X-HE-Tag: 1689392540-376567 X-HE-Meta: U2FsdGVkX1/wNzvhstA4HAvE3ScKrQXhNrPgCcTkmF5B30u29mXV21CMi2+jTZ+R8S45SxXXqgvmGgPC87m12eh0ZJx4uainq5/AvA8+L4Qbvzh+hlqsjYbmlFcVyBj1NojaBKZYU4Ko7ROX3Vabtdo/6sziy3tC0ZSGdmW8/KUimTiosaLpWD5OCP3TsnCh72AK8dtV1r0zqMTwTeB+dX+u5BZXv2Q1baMyVzDRqjVpEB2nV+NOImOriyHvgx8aMnSvs1DEJy0Y4l0HPhyOSnf6l55BEaiUD45AzZT68tNxr37hypLy/3heFCwxAuo8INUlgYUqJx9rnAjxf6ZESkmrwhDRUnANOTFwmDy6T1wXZItBDDGWx1SjLndFd1BiV8KZfXu6poNF3urFHKt3tXMy5DuXqtO5Hc/Xto6Jvc694JqEt9ioZdyQsUBwaf1TmvveRuiYQWgFiHyir7z/k4dfJUVnOoK7GIUDKYOJOXAil1s0mG9wA/TxgV+pw2/3H+sUuzN57fsn8Z728CZRbss/dBncs9/2uiXpHAX1s9VaROyqhxJFZlIAxE4A+/1csQMoJhk4QCAsKYyPACOumqbRKjucjFSFotACevCB9kJiXmfsLFLmvA5//QgbrK0UEzXqhNw/nV056Xdd3V/Pc5dIatT3Viu+Wlrn0HH+1Z93zIjsDNvloMmGbuW4oySLQ0ipQyLwq2hG9RxbJrJorwdoP4DusJxuLdMxk7b1tg6sTE3oz2PV8wCPw5viWqohWZVCnq6ZI+pZKa5QF4Kz2t1Xp9yb53uCiENAtUtwjEIT4Q+l5WXb0vXaghM4JTi6cQfhL0ggbnQkmiqLQzvq1K6Q4ywWrARJArgHHXcVYYIXDNROeXqc/EHPiD2T1dOO5cYMMSZvrKC9MKoCy5XPYzzI1rVe5E7ojtT2MuZ/KtIgRjrWG86Z+LnHGyY3eH70n7klvaz8SflsljHXH2R lNW/L/TR HpjS4ogBAOwzh4zDn6VkZ4ChQ2kQNNbidXkVLy4SwhLqO4sGj5zhgd6/LxlkFWieCp4k/WB7rWbreM+s+tHp6NhHPqn9tsF9KYGuJzrVbtJ7KiAU/jXX1a0h1kiTyM32PQL0OhuA43m8o05Umz71uy9yKVz1pQ5CUIe/9p/dIrNmkLTgOxsc0VnhM+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 03:46:08PM -0400, Johannes Weiner wrote: > diff --git a/mm/zswap.c b/mm/zswap.c > index 62195f72bf56..1b0128060792 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -2,7 +2,7 @@ > /* > * zswap.c - zswap driver file > * > - * zswap is a backend for frontswap that takes pages that are in the process > + * zswap is a cache that takes pages that are in the process > * of being swapped out and attempts to compress and store them in a > * RAM-based memory pool. This can result in a significant I/O reduction on > * the swap device and, in the case where decompressing from RAM is faster > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include > #include > #include > #include To make this patch compile, I had to add zswap.h to the include list.