From: Matthew Wilcox <willy@infradead.org>
To: Peng Zhang <zhangpeng362@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sidhartha.kumar@oracle.com, akpm@linux-foundation.org,
wangkefeng.wang@huawei.com, sunnanyong@huawei.com
Subject: Re: [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read()
Date: Mon, 17 Jul 2023 14:34:26 +0100 [thread overview]
Message-ID: <ZLVDYjdflF+3oJCG@casper.infradead.org> (raw)
In-Reply-To: <20230717132602.2202147-2-zhangpeng362@huawei.com>
On Mon, Jul 17, 2023 at 09:25:57PM +0800, Peng Zhang wrote:
> +++ b/mm/page_io.c
> @@ -58,18 +58,18 @@ static void end_swap_bio_write(struct bio *bio)
>
> static void __end_swap_bio_read(struct bio *bio)
> {
> - struct page *page = bio_first_page_all(bio);
> + struct folio *folio = page_folio(bio_first_page_all(bio));
Should we have a bio_first_folio_all()? It wouldn't save any calls to
compound_head(), but it's slightly easier to use.
> if (bio->bi_status) {
> - SetPageError(page);
> - ClearPageUptodate(page);
> + folio_set_error(folio);
I appreciate this is a 1:1 conversion, but maybe we could think about
this a bit. Is there anybody who checks the
PageError()/folio_test_error() for this page/folio?
> + folio_clear_uptodate(folio);
Similarly ... surely the folio is already !uptodate, so we don't need to
clear the flag?
next prev parent reply other threads:[~2023-07-17 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:25 [PATCH 0/6] Convert several functions in page_io.c to use a folio Peng Zhang
2023-07-17 13:25 ` [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() Peng Zhang
2023-07-17 13:34 ` Matthew Wilcox [this message]
2023-07-18 12:56 ` zhangpeng (AS)
2023-07-18 16:16 ` Matthew Wilcox
2023-07-19 7:46 ` zhangpeng (AS)
2023-07-20 5:21 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 2/6] mm/page_io: use a folio in sio_read_complete() Peng Zhang
2023-07-17 13:40 ` Matthew Wilcox
2023-07-18 12:58 ` zhangpeng (AS)
2023-07-18 16:21 ` Matthew Wilcox
2023-07-19 7:47 ` zhangpeng (AS)
2023-07-20 5:22 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 3/6] mm/page_io: use a folio in swap_writepage_bdev_sync() Peng Zhang
2023-07-17 14:00 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 4/6] mm/page_io: use a folio in swap_writepage_bdev_async() Peng Zhang
2023-07-17 14:01 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio Peng Zhang
2023-07-17 13:48 ` Matthew Wilcox
2023-07-18 12:56 ` zhangpeng (AS)
2023-07-17 13:26 ` [PATCH 6/6] mm/page_io: convert bio_associate_blkg_from_page() " Peng Zhang
2023-07-17 13:46 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVDYjdflF+3oJCG@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).