From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F159EB64DC for ; Mon, 17 Jul 2023 13:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1EDD8D0001; Mon, 17 Jul 2023 09:40:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0336B0074; Mon, 17 Jul 2023 09:40:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BD8C8D0001; Mon, 17 Jul 2023 09:40:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C2066B0072 for ; Mon, 17 Jul 2023 09:40:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 42BD61602EE for ; Mon, 17 Jul 2023 13:40:30 +0000 (UTC) X-FDA: 81021213420.26.FA05AF3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 3EBB2A0012 for ; Mon, 17 Jul 2023 13:40:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sNqY+OXh; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689601228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OjcJNfI+ZFsjHCpKJy4DcI+Lam5MgEbyR3vKrF75hvk=; b=oH1d/BaU3IFQy1BaRwbkaF2TuLmKk8pP7KWtOh+F4p113rOSb71dlByas4r1K7Sov0jsYy jrmYzg/oQsWDyw6EgAdQ+5USmlF7sWHsWoUyrH9iaFg9Vvno9x0YypWRy36KdA2hgA9J7v DLbgwk8hIWk41fMtn6J7UQNJ/flcijo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=sNqY+OXh; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689601228; a=rsa-sha256; cv=none; b=yI4tTxi5Xm49sNGhHTyXQulRGwiydpYY952SZsbU6kBHJ5nkgy/ZGhaUFU5Wn+dCBzpWnd xoFBXPtAN5bjUhznB+Tj7U4DK+995G6lbdfAJs0iHluT21JypiwQjt6bycaOFx4aqgqs4S gYZfCwY6Y3hC2nrHI+VynV0VCviR59E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OjcJNfI+ZFsjHCpKJy4DcI+Lam5MgEbyR3vKrF75hvk=; b=sNqY+OXhxUClUB7xAXZjrPH1lI K8RGdXd/0ZJ0S/l/tgC75d5SD4NAXz2xUVxkjo9mxF4syd2zpTJliExEkS8h2RvcA2/VM3NjJVq6+ OrRwUsB5HenSqG+hYhnc7m8xxupgc5Hk+Ii156mpISEZ12TzRtc12zzivIMrPQDE6Ukx52UzIgYih 6TbOYeKc8jlO/ZwlcWaPSnFIO82K5RRjLOMxq1DWLq3/lmnm889qsXf6iBofzWh55d42tR32w8o49 PS2wTnPuONSl5T+c+oyCKteKMMjBvyOa+IRZZGeBTx5Va+k7KeH4KmG+GIcbDlnIHjsIJoT3JX7m7 u9cuIfbQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qLOSe-003xHn-Al; Mon, 17 Jul 2023 13:40:24 +0000 Date: Mon, 17 Jul 2023 14:40:24 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, Kent Overstreet Subject: Re: [PATCH 2/6] mm/page_io: use a folio in sio_read_complete() Message-ID: References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-3-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717132602.2202147-3-zhangpeng362@huawei.com> X-Rspamd-Queue-Id: 3EBB2A0012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pu1yhuao736zzff3uhfira3bdm3tnxa4 X-HE-Tag: 1689601227-150967 X-HE-Meta: U2FsdGVkX1/Ep5WMV+LfIolQ+n1whjxGufx6LPqH1FII/Vw2avrpzdeiZ7hgW+3G3fxI97/XP89wXhtPABCiEYQ6mVPOLMrPe9TF32dckuezIR4SIrgy0Col+86L/FI1+tqVG2cHcPqvwwKmSU2iE5AfebGnxNDMyZxKdsyFlijHswt2/yDTWzcaE0Sy3DvJV53cxSV4/QSZqOjuI8xq8SLnOPJDv9frw1d4i4dd2hQkeL7g2gd0cuvygN3byrIhLU9sqxjmjhr1cdfZjiAQ2bHJEpHsBAuoLJoU64NhIkac18JXWo54zCXqlDe5CW0uYom5DwhiV71Q08lnQbpEVlc94Oy7NmNnxW4RouST1i4Q7KnKy1EUPpkSNGp53j76DcLNpxRlcBy9aBMeIK6EIutxQTVp46Fm9SvVh4KyhWZGwW1hwmuFRXfoeXh5PjnKkKWm9xA8NNtqrasaUKdATgD1qtST6/nqh78klEqOSDdETWS5HirzOQIaolC90jRxage5dWphe0jBX1J6b71rGWdUAxnbJgSoWRZAlNdrXrrqw7RruhcIn5rjxhxTP1JCXGl9xPYsVVl+ohMjmkbQ0pSSk3YqecjW8cmP8p7ZCRMeMNnr4yNzUfTz/SOBpCGT64Q9+/ifJcRzRa5h85dWt5jFJCkNECiNkH1ZKb0X16Gn49yJpiNdSnwkupZQ1SWCB7fRQb3XdvXFLqV0jorW8llQs53yiLBNcW7rG+4laOXRxSuAXryIEox9ucnx7Em1JtQP8JuUIUHIFJPnxAHVW1OgN5LyTOgsyn6udpLsp8SbmC1flcBI+ophf1D2U9oSWp8z7y0jwofYbdfeHLhCgpCZ5nfrv7bym4bnsZEI4hZxzfI4bp7hvcWnoREKhjtFuU4LwdbrAEfJOXHILv8mVlwRWb6kS2KbRWddwKK96F0IlJGvRgt3ensJYOBZlnUIT0EFjMG3J5z2hpEjHNv Y+YrFxbC fFomwoO+3b5wa/xx8TI7SJVtXQ9yGTvcmvDLD5JA2Q+4IqqqnM7e4KKSNiwuepcvwu4hH9IC5MxKHz0tYpsKYPHPxQKHgDn694fqhCTtjS/U0b11TVUuTmSR+l6T7DNIepVTEJyB32gY8+JoDrERwwKedou7v3EN6OAbdP22IJ8BPsumgfKnemB7WYKlvBCMyXBgBTPqdwefVAOiIcLbugU9S+49KjUP3O6m8XXAbANmMfIlAGBV5tz6tsKcGN4+UB0+W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 09:25:58PM +0800, Peng Zhang wrote: > +++ b/mm/page_io.c > @@ -406,19 +406,19 @@ static void sio_read_complete(struct kiocb *iocb, long ret) > > if (ret == sio->len) { > for (p = 0; p < sio->pages; p++) { > - struct page *page = sio->bvec[p].bv_page; > + struct folio *folio = page_folio(sio->bvec[p].bv_page); > > - SetPageUptodate(page); > - unlock_page(page); > + folio_mark_uptodate(folio); > + folio_unlock(folio); > } I'm kind of shocked this works today. Usually bvecs coalesce adjacent pages into a single entry, so you need to use a real iterator like bio_for_each_folio_all() to extract individual pages from a bvec. Maybe the sio bvec is constructed inefficiently. I think Kent had some bvec folio iterators in progress? > count_vm_events(PSWPIN, sio->pages); > } else { > for (p = 0; p < sio->pages; p++) { > - struct page *page = sio->bvec[p].bv_page; > + struct folio *folio = page_folio(sio->bvec[p].bv_page); > > - SetPageError(page); > - ClearPageUptodate(page); > - unlock_page(page); > + folio_set_error(folio); > + folio_clear_uptodate(folio); > + folio_unlock(folio); Similar questions to the last patch -- who checks the error flag on this page/folio, and isn't the folio already !uptodate? > } > pr_alert_ratelimited("Read-error on swap-device\n"); > } > -- > 2.25.1 >