From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB93EB64DC for ; Mon, 17 Jul 2023 13:48:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 450C16B0072; Mon, 17 Jul 2023 09:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 400016B0074; Mon, 17 Jul 2023 09:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EE0D8D0002; Mon, 17 Jul 2023 09:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1CB866B0072 for ; Mon, 17 Jul 2023 09:48:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D53DBC02C0 for ; Mon, 17 Jul 2023 13:48:28 +0000 (UTC) X-FDA: 81021233496.28.816D124 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 3A8A5180011 for ; Mon, 17 Jul 2023 13:48:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IKnPkT2u; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689601707; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yP81tFY4pH4Uv/KB5Cd7YMQTVo773Q8/WCwZl/r6MdM=; b=B0GfbLNdtR7gBgPaB0gV9WdroUQdTFwmRoZiXDI21767RFex20kbzsm2EiSaKUvPtcHvTu /5sXgK5VAYCGzano8PD+4v4i9tgosmEZ2CicluoIuc+QATjAZxtsbj7ZJJOZDbOo5bJLrX CEyRjf56CuB6qgBhyhLjR6zmccGhntg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689601707; a=rsa-sha256; cv=none; b=VvFOyeQ0HonmIGJU53juSZRF3ENwHBT2RgGBib/UiEiTiSLCLHUq/SAQM2TlZfD0UohCIN RCobjmn+MGG7USfgrQV0aADgBEhnjcEdMOtYVcFOJpkusudJu1D3c5SgQbxE8EwpGM2xa7 XMi6RQLWAsM2Na68NV8aIq9rHXJrbbs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IKnPkT2u; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yP81tFY4pH4Uv/KB5Cd7YMQTVo773Q8/WCwZl/r6MdM=; b=IKnPkT2uyTAXvHREmWNsusoqR1 1CJ7o0GyzM8Z2W5DaVh1jLd7ekUkkBbcFFuQTuggUbT8j1r0Ml5IzqF2odT5yrsjn4504kdm9NqUP usSw3GNGgi/psfXxRmVeUh6s/p7V9dGHdK4fub2jsFrwIpMOwT5ZDo/r8aKVN8M/Msd7N2rWOi4zb kOmD33umFyPJtLfCNiJGDcZ+OykbQb9zhYDlXWUZ4D+5bkv1tGefBaJRO3X/6YnxeEdhM4jqa8GNR w/msxM7G6kEv9xydANsn4G/M7uZcZeGIIGrp+Jlc88iG2T/qZIw3YgbPLbHbnsfNCw3y8QmUuPvl7 EWB6xhlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qLOaO-003xdE-Bi; Mon, 17 Jul 2023 13:48:24 +0000 Date: Mon, 17 Jul 2023 14:48:24 +0100 From: Matthew Wilcox To: Peng Zhang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio Message-ID: References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-6-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717132602.2202147-6-zhangpeng362@huawei.com> X-Stat-Signature: 7gca4jket7fnxthrccwk7n63e3smo9qp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3A8A5180011 X-Rspam-User: X-HE-Tag: 1689601706-478378 X-HE-Meta: U2FsdGVkX19BCuoJxqXqUfbFs4bwCv35pcNtp64HjnnxDGl9xnc/N0Xi57LupeazyRMBxRPFo+aZ3+gz9/TCvFZWyO+A8v+527FQ9bnnJyOj61u66esR+ekvmAf/drurlLzkSAUjSkMGJR5/LdYCi/F7lbkiEC/1L87A/gCA7JcxOea6PC1dXo5bZqoHq3+qJJzA1BeB0nLy/IJmvXzZmS8Sw6yizd/fFccXBNp1U3l2d3gQnvd3qlVxCu4e/KHFCWkpw8LfOdOKP6S3bBwtY0ioq8m8Ra1rCUTCQJBBWwjEZ1sK9Ua4ZzDu6VX0IMgrvmPgz1eRRTP9JhnDU8HoLLiLoNHkd/QSdH8HgjZfXixTM52pIaK7ZdFYADqHBBOf9DeklW/qpWut7pPhOuDHgaLwXe5zFQVSJsCZlAOf8XFDqzurwa+LzLTZf/hnI9coSXzHMuqZFFRrFBLRMwTDT6HXj/gU/aVmOGLNTQMWkWyvNRj0lm3HiE1l3otTuNa9PWVFXCvNolmw7xcYdiTSCK7v3WDG5ibd19lROEu+Bj/Gu69f4RxwC3iL8HtIIOAfTG2CDsKBcLtq/2RvPuclzBjQea8dmIWH4R5Q8SI5GRmh6rlWLrL+vb1bw5CVw5eRY8meB5SyDdm4jYxnE+sE9/rHqlxEauHVo7AxPTx5ykpf72ecX15jGmL76uJXSDl2dqOToYTj0POxqU1P41AComjeV5C0dI+Yo7TFUfulCHvrV7t27vRFMwkqdFnySh4JtoM2OTOj1PWzYEEPVuMcE8R4rscoGnxJow1tIsyVkbV0MBO71l1371q2opGDZFnPEqjLuEmUuxVgFdJ0Id31Ow6I3otPxlyrxjrbB2MqUhr0mYy7TMhUkxdJYzFBO6GOWCuwukugkj5OCNjtvusY1gkxBKcXjfR/E+Ny7GYV/nhnmeixpIAH6peEvW7ZH6bNmwWxtzPVh5jGxt6l3Ig sA3mYaJP lJDDBYn5t5Jtha+D6Ld2swgxIvaFzHA8C6xH7YiJU6BdxuKIkNRk2/Q05K6iP/WvDOfvFtc2OKBfGN1WkBygj3fau1t1hYSRngJU/yx3UlssJiVArqs6FKYBEcTpLqvLZp/b1qccQWSqoH2BKAbDUTc91Cozv1LfoSThRdERC7SCX3eb9Ie37NpzXuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 09:26:01PM +0800, Peng Zhang wrote: > -static inline void count_swpout_vm_event(struct page *page) > +static inline void count_swpout_vm_event(struct folio *folio) > { > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > - if (unlikely(PageTransHuge(page))) > + if (unlikely(folio_test_large(folio))) > count_vm_event(THP_SWPOUT); > #endif Since this is a THP_SWPOUT event, we should do this as: -#ifdef CONFIG_TRANSPARENT_HUGEPAGE - if (unlikely(PageTransHuge(page))) + if (folio_test_pmd_mappable(folio)) count_vm_event(THP_SWPOUT); -#endif