From: Matthew Wilcox <willy@infradead.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Yosry Ahmed <yosryahmed@google.com>,
Christoph Hellwig <hch@infradead.org>,
Nhat Pham <nphamcs@gmail.com>,
Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
konrad.wilk@oracle.com, vitaly.wool@konsulko.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: kill frontswap
Date: Mon, 17 Jul 2023 17:07:46 +0100 [thread overview]
Message-ID: <ZLVnUhXeZ6ptNF2l@casper.infradead.org> (raw)
In-Reply-To: <20230717160227.GA867137@cmpxchg.org>
On Mon, Jul 17, 2023 at 12:02:27PM -0400, Johannes Weiner wrote:
> - pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s\n",
> + pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s\n",
> p->pages<<(PAGE_SHIFT-10), name->name, p->prio,
> nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10),
> (p->flags & SWP_SOLIDSTATE) ? "SS" : "",
> (p->flags & SWP_DISCARDABLE) ? "D" : "",
> (p->flags & SWP_AREA_DISCARD) ? "s" : "",
> - (p->flags & SWP_PAGE_DISCARD) ? "c" : "",
> - (frontswap_map) ? "FS" : "");
> + (p->flags & SWP_PAGE_DISCARD) ? "c" : "");
Is it useful information (to the sysadmin) that zswap is enabled? If so,
we might want to print a "Z" instead of a "FS" here (would need to
know whether enabling zswap succeeded ...)
next prev parent reply other threads:[~2023-07-17 16:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 19:46 [PATCH] mm: kill frontswap Johannes Weiner
2023-07-14 21:10 ` Konrad Rzeszutek Wilk
2023-07-14 22:25 ` Nhat Pham
2023-07-15 3:42 ` Matthew Wilcox
2023-07-17 14:12 ` Johannes Weiner
2023-07-17 14:31 ` Vlastimil Babka
2023-07-17 16:02 ` Johannes Weiner
2023-07-17 16:07 ` Matthew Wilcox [this message]
2023-07-17 21:51 ` Johannes Weiner
2023-07-17 22:58 ` Nhat Pham
2023-07-18 18:52 ` Yosry Ahmed
2023-07-19 14:28 ` Johannes Weiner
2023-07-19 15:22 ` Yosry Ahmed
2024-01-16 20:09 ` Andrew Morton
2024-01-16 20:18 ` Matthew Wilcox
2024-01-16 20:22 ` Yosry Ahmed
2024-01-16 21:35 ` Andrew Morton
2023-07-15 4:23 ` [PATCH 0/5] Followup folio conversions for zswap Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 1/5] fix-frontswap Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 2/5] zswap: Make zswap_store() take a folio Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 3/5] memcg: Convert get_obj_cgroup_from_page to get_obj_cgroup_from_folio Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 4/5] swap: Remove some calls to compound_head() in swap_readpage() Matthew Wilcox (Oracle)
2023-07-15 4:23 ` [PATCH 5/5] zswap: Make zswap_load() take a folio Matthew Wilcox (Oracle)
2023-07-20 6:00 ` [PATCH] mm: kill frontswap Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVnUhXeZ6ptNF2l@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitaly.wool@konsulko.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).