From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0575EEB64DC for ; Mon, 17 Jul 2023 16:08:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9250E900003; Mon, 17 Jul 2023 12:08:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AF638D0001; Mon, 17 Jul 2023 12:08:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74E90900003; Mon, 17 Jul 2023 12:08:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6236C8D0001 for ; Mon, 17 Jul 2023 12:08:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F3F051C8B3A for ; Mon, 17 Jul 2023 16:08:04 +0000 (UTC) X-FDA: 81021585288.11.F847FFC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id F3693C002E for ; Mon, 17 Jul 2023 16:07:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TRnlFIos; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689610074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=POTa2usJr85Ecy/FRU76IO5QdbP4btKmvKRtBlr6QsU=; b=HH3k0PMgo3LqEl/FUSiG/ScZ5bH9ttIeEqK0wl6OefpWEQq/aj0MW49r3dwZdMJ2lnrTRn /h/ljJRisYu2VMyUfUCYeo8aLMmgnYgvrW5pZl2yeN7MAmKmEOSwZq9sSgQqxD+s81C9Dc Di2nMm3Ku85Ijt/HPgcz5LGjz4MoP4A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=TRnlFIos; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689610074; a=rsa-sha256; cv=none; b=oT0xg0iNPsJCv9UhC2dNNJVq0qAN4uIKOg3SX0WO2C/0voH3LO1a4sbIBvaPFHHqkUvOC2 lOJEX5CehOeN/HSq9K0AP+GbyiHZ88wcs4l5m6V8b+kWpKpO86xyysZKDwVK1VJ6MwM+Mj 2mcyxswCDN1S2RfWprJRbsJCEkZsE8I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=POTa2usJr85Ecy/FRU76IO5QdbP4btKmvKRtBlr6QsU=; b=TRnlFIosnrQPqYe4cUBoBIXlQX 1JsxtdkBhKef9SawwdF3y9vpKE+JCCqz2VTQwjAd7WUSZfRL/zvoW80ogT9uaJJoegEpA/Q/Ml7Jd eS/5R04KQlfbzwvGF09gFu+1lF1bP81SBaqj8/vOHpjpxdl6iXcohb/3JngLjH/LM4b59oNc8z9EY +usuNpeUhaygkLWIwl+4O2Dl3sj3MApvFJZaMALZYF0Noh2ANW8cxz1y6ZLi/aISBu/AFKQfOrbOi wBFu/PiiUOHuGUU8AJkXDZFRjl/6B24NEMWjA7cy+1WdxVsXBEmVyj/VN0RTRTFAwaXqpQbxCUBvj bM6yhwCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qLQlG-0043zU-8z; Mon, 17 Jul 2023 16:07:46 +0000 Date: Mon, 17 Jul 2023 17:07:46 +0100 From: Matthew Wilcox To: Johannes Weiner Cc: Vlastimil Babka , Andrew Morton , Yosry Ahmed , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-ID: References: <20230714194610.828210-1-hannes@cmpxchg.org> <20230717141250.GA866068@cmpxchg.org> <901409ed-504b-9500-54d8-e42f832e07b0@suse.cz> <20230717160227.GA867137@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717160227.GA867137@cmpxchg.org> X-Rspamd-Queue-Id: F3693C002E X-Rspam-User: X-Stat-Signature: zbrutpxb8mhw71uzek8esgcp1in3ceoo X-Rspamd-Server: rspam01 X-HE-Tag: 1689610073-534738 X-HE-Meta: U2FsdGVkX1+0qp2tPEjjiHL/2XipFv0GFOlnrqXFmNGtevlhUAUHb5ML5X5wOmERu26E0OxEOykvdfJ2uiKWw2rkNDb3WgRvED58C2iZRg7Q1jNNDmfOTk5vt1qLVD3BCT6se66LzLEEtVv/XQ5bnSKDpIrQzvJAB633fqyb8FN07r9F89ZVQm3UxxJqBCmiSzFD/FpXGLZ4y73kqMHaBsD80lyhR63yax4qu6ZxWSYqrl9mUCQ4OcQep4lrU6QYpMuWDFa5ou+cmKLOQXFhfvJ02QI7XkzfC9N5tE+MbdmhhWDD0GClnFb1ODXFDNru0MheX5y2Jiw7keQ/wTptAPciDbqAwAQ60/TdQz3P+0+7js8kVr7b9ZX2ClZm8uJFyPl6IoRvn8R6Q1nktOtw7n+XydZBaogq+SuZ9xCSHcXk44mGlILyG9kyrzNV9xR+AkzaaXr5a9mUqCHL7ByP+NCxV0z6JfaYkov1nxdCBMRx6rjyW3otxzSkrrQM8D5AYD80Mu/youaUfuS/2wirZrvBirn1xJdiPIZirKqKbMdPkZW4KphoP2FxCLZ1P0I2BqOUfWOkps0rn6bFS9Wj33lggBEGt12ZKfYIfFpo3poeIDGXCfkyO3cOkUmGxjHYmWDSBfRfaogbVB+jpBGMvtZR7OuvHaJMxTEwMXsG3x0VyfvTGxgKnunWfYC2MrUonMBWOLwNTd1QTgZzwxCCG4CFtYRQAxtrYKA8Yz1+vltLvAjeZHuNrplejw037iXDQMrU5uuNPEZX7jW+YDnezO+07BMMi7NdaGEjNjE5UPu5gfpN2Mj6wFYch2OuNsGkFJQG1QinfMfVwKe9oHPcKPQ0rfhCtvC/eYlkn0lUrTXO3YxzDvSXYmFmzjLKGuFLpw9bJ0/XJu2Kb8BPPOT7kcVuiPKfpwKMSgrvA1HvHv+lJl6UVWcUJtR1QDGO1pyY5Wz+TzMoCXVzrKTXKLB 6C0q/Hda 66nt8h7sjS25F6UKHcvdTxyTQ2U2ip84v76df54B6LKH6c2wA4QN63h8BwayDhw8/xb02HFR8yDQjg5pqOwkyAfomosejg1R8JCgC4x0hDWGbBzjwYCqj5pUdjK+hU+TUHwJMWdC29XwpkZFu5tx4pIK9HRe2RfH2HFKB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 12:02:27PM -0400, Johannes Weiner wrote: > - pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s%s\n", > + pr_info("Adding %uk swap on %s. Priority:%d extents:%d across:%lluk %s%s%s%s\n", > p->pages<<(PAGE_SHIFT-10), name->name, p->prio, > nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10), > (p->flags & SWP_SOLIDSTATE) ? "SS" : "", > (p->flags & SWP_DISCARDABLE) ? "D" : "", > (p->flags & SWP_AREA_DISCARD) ? "s" : "", > - (p->flags & SWP_PAGE_DISCARD) ? "c" : "", > - (frontswap_map) ? "FS" : ""); > + (p->flags & SWP_PAGE_DISCARD) ? "c" : ""); Is it useful information (to the sysadmin) that zswap is enabled? If so, we might want to print a "Z" instead of a "FS" here (would need to know whether enabling zswap succeeded ...)