From: Matthew Wilcox <willy@infradead.org>
To: "zhangpeng (AS)" <zhangpeng362@huawei.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sidhartha.kumar@oracle.com, akpm@linux-foundation.org,
wangkefeng.wang@huawei.com, sunnanyong@huawei.com
Subject: Re: [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read()
Date: Tue, 18 Jul 2023 17:16:15 +0100 [thread overview]
Message-ID: <ZLa6z+vhK6aWYePL@casper.infradead.org> (raw)
In-Reply-To: <df29af76-fc8f-b4f1-4a32-a200b5d4ba31@huawei.com>
On Tue, Jul 18, 2023 at 08:56:16PM +0800, zhangpeng (AS) wrote:
> > > if (bio->bi_status) {
> > > - SetPageError(page);
> > > - ClearPageUptodate(page);
> > > + folio_set_error(folio);
> > I appreciate this is a 1:1 conversion, but maybe we could think about
> > this a bit. Is there anybody who checks the
> > PageError()/folio_test_error() for this page/folio?
>
> Maybe wait_dev_supers() checks the PageError() after write_dev_supers()
> in fs/btrfs/disk-io.c?
How does _this_ folio end up in btrfs's write_dev_supers()? This is a
swap read. The only folios which are swapped are anonymous and tmpfs.
btrfs takes care of doing its own I/O. wait_dev_supers() is looking
for the error set in btrfs_end_super_write() which is the completion
routine for write_dev_supers(). The pages involved there are attached
to a btrfs address_space, not shmem or anon.
next prev parent reply other threads:[~2023-07-18 16:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:25 [PATCH 0/6] Convert several functions in page_io.c to use a folio Peng Zhang
2023-07-17 13:25 ` [PATCH 1/6] mm/page_io: use a folio in __end_swap_bio_read() Peng Zhang
2023-07-17 13:34 ` Matthew Wilcox
2023-07-18 12:56 ` zhangpeng (AS)
2023-07-18 16:16 ` Matthew Wilcox [this message]
2023-07-19 7:46 ` zhangpeng (AS)
2023-07-20 5:21 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 2/6] mm/page_io: use a folio in sio_read_complete() Peng Zhang
2023-07-17 13:40 ` Matthew Wilcox
2023-07-18 12:58 ` zhangpeng (AS)
2023-07-18 16:21 ` Matthew Wilcox
2023-07-19 7:47 ` zhangpeng (AS)
2023-07-20 5:22 ` Christoph Hellwig
2023-07-17 13:25 ` [PATCH 3/6] mm/page_io: use a folio in swap_writepage_bdev_sync() Peng Zhang
2023-07-17 14:00 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 4/6] mm/page_io: use a folio in swap_writepage_bdev_async() Peng Zhang
2023-07-17 14:01 ` Matthew Wilcox
2023-07-17 13:26 ` [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take in a folio Peng Zhang
2023-07-17 13:48 ` Matthew Wilcox
2023-07-18 12:56 ` zhangpeng (AS)
2023-07-17 13:26 ` [PATCH 6/6] mm/page_io: convert bio_associate_blkg_from_page() " Peng Zhang
2023-07-17 13:46 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLa6z+vhK6aWYePL@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).