From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416EDEB64DA for ; Wed, 19 Jul 2023 14:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDA3B280063; Wed, 19 Jul 2023 10:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C89CE28004C; Wed, 19 Jul 2023 10:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51FC280063; Wed, 19 Jul 2023 10:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A5B9428004C for ; Wed, 19 Jul 2023 10:17:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 01CB414039C for ; Wed, 19 Jul 2023 14:17:00 +0000 (UTC) X-FDA: 81028563042.04.9C11D48 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf13.hostedemail.com (Postfix) with ESMTP id 94ED52002C for ; Wed, 19 Jul 2023 14:16:57 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QCgn5pm8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3WPC3ZAYKCEUzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3WPC3ZAYKCEUzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689776217; a=rsa-sha256; cv=none; b=UddaHafqdphT+RdrKx8ezpFN9pPFnD5ddxaui9PND7V9gXA0PvoPNajyDAJcH2ppMPeRqd 9W3gyUwozwkPWdeAmq0cnMQ5Ox5XGQLewcocCVS0s5ZnBoxX+kM0X6IGK4wWBenUBZ/L0v tJjie5qwFswJ/xfhuTbz4aPPHgPNUsA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=QCgn5pm8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of 3WPC3ZAYKCEUzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3WPC3ZAYKCEUzlhuqjnvvnsl.jvtspu14-ttr2hjr.vyn@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689776217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ply9vOQ7PKiPIjqcvpgXEIwEBxatqkRJB2ZRy5lS2Xc=; b=oerIVdkiCblvq28mWYkfwLGEWrliq54BAdXwNUGuSDdGAHSWttFu3pTTLZfaj2yX/ft7GF W2cOpW8pxYKUCdg2HBAyFARygGmNUmgbv1Vo9lOt+IoJsgxhyfNbAgI7UktgJlqCM3uhXp GXdDKctn1w5EQbG3T08HwEpe8uLfZNA= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-262c77ffb9dso5333089a91.2 for ; Wed, 19 Jul 2023 07:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689776216; x=1692368216; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Ply9vOQ7PKiPIjqcvpgXEIwEBxatqkRJB2ZRy5lS2Xc=; b=QCgn5pm8yPPImP/ZfLF2Ea0jJXDpcGNQ/LF2jNeNTBG71TLZwae17UnwEuo78ONGHP atCG9sArqHfv277Ky9HWUevcQtozR/I9rfoMFWMGzH2p/tn1UptotifJkTzwcjUzjGM4 2mRccC+Qe6eelyvVpzgsii1Dz38eewFROpWBRyPZo22w72yv1RXU/kRjiIgbgdf4vOiO m+eFtOZOtzemALwYg0UpO5hPIX4qNwingmWVGWsEqCwrs8u/CIQrQXsRy9c4nWVOA7nY TgAf9p3r7jbBOiu0L+1TlKBrMt3e7HNn72eYqwvkzNmnIVVzm8emG5isi9/yOnMB2w1e eLcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689776216; x=1692368216; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ply9vOQ7PKiPIjqcvpgXEIwEBxatqkRJB2ZRy5lS2Xc=; b=ILFD77VFnE/7VJyPIS1QtX5t1yXg1iHiKXrMCeN3V2eQMuuGWMxyeGB6ucc+gcw6we JeYJgyONkJRarft/g8EBG9Jyew/WzVSGwMFoNtlMXpenB/YnoiP+QnbmYaAdQmJ9OUJv 6iKMXTScOzmN28bkifYVD2wg1x9kWJxywO1+mwqYGqaW+L2jCCQs7fyKq34EVDbX7eaL v/QmPEwsrntGe8lNmaZBOanEj3q5jbWNZUvU40r8s3aSUMma+v8zf8W5MX7dY1ObhAYC MPbSW/+Hx9uCcuO8CAASXfcEeFGdGexcxSo8mRaJFR+BzHoWC1wKrO0u+V3L6IljoHhy G7ow== X-Gm-Message-State: ABy/qLb4stuWGFXl5lj06KVpzK5O3VvH9S4jO9Dp2GenzEUHz1G7OI5n 58IJcrjtImaJ5KPl8bztXqOVOV0szfI= X-Google-Smtp-Source: APBJJlHe5KmJdZof+vQtZ6M87xlqjK1Ejx8t4AB5DMX6de6h21FipxJ2lQkyFnlQoXRyf3eYpC2jq3S2bQ0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:e542:b0:25b:f9e3:deab with SMTP id ei2-20020a17090ae54200b0025bf9e3deabmr136275pjb.9.1689776216142; Wed, 19 Jul 2023 07:16:56 -0700 (PDT) Date: Wed, 19 Jul 2023 07:16:54 -0700 In-Reply-To: <20230719075440.m3h653frqggaiusc@yy-desk-7060> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-8-seanjc@google.com> <20230719075440.m3h653frqggaiusc@yy-desk-7060> Message-ID: Subject: Re: [RFC PATCH v11 07/29] KVM: Add KVM_EXIT_MEMORY_FAULT exit From: Sean Christopherson To: Yuan Yao Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 94ED52002C X-Stat-Signature: orfkh97bo14b7k3fc53b4bu6dip31dkz X-HE-Tag: 1689776217-277356 X-HE-Meta: U2FsdGVkX18N3eqTmSyr5CYzw00l4Rs0Y+y6+xUkLqfxBiXlo6KvNC+PTOjJJM7h3Egwqum5otMvHNLAvGcJ6DO9PO/zpE19gjK5wb6VVQsbFuYGq+YYKRYrab1mEvoqjPx8oxNK7uFmw2e4TqSJIyZedqmFs9Z0DMjH/cqmg8EPcYYB+JVosn7RBs03nRnWMvbEAL0WglzMBeaV3MklLKRiTbOyckaiQO3hpzVgnpWIfST1Rz+17YOcX7U8tDZwN3zf48IGuZP0PDkmwa0R4WxAI4n0kD3g97CTsll5J8bT/sL6ouv11gOzb1KkYHvxIPdwiLuE7/BFZIqNur45GZcteMXUwN6pZWgWflIrr/hg88RA16JfPLgnZZ1qIk5fBZNzOQc7joIJvpdTWlHHwPddkVqaffG91eGPa7QyRA8FwFp8ggx7Ww+sFB1pTZaLAcVgmXNQiwAC6o418tkVV6T9UkzAehVsb0JsDMOy6BwyoUJKTMAUXbNzPr7S7DB4YwkT7qfinuBJz8RZnDxhw6yO+IwRWBgooGh7AkeMpE+qTIx6VHxtl33aXkWJG2xkzphU7/piLzE1yKDZAg1TZlOoyoUJ1AMA4xWlfKETUjVPSKnUZpUg1u/MCN6JC1lsm7Alw1YzUFJoyIZ3o9Q/ur5+8diDEtZW2MZdLdCihziiVyIoEaZxeOPD2S+jeiOn02tYCETvGo9FkQdXnT9XnKJ91N66gO+KDzVDVRAMdgG//y4HO/I+B/EaD4tHwYAdbnBK2K7AK8DGyH9Cxlhn1vrvWi1yFmgdGDGfrycOgbSSuNE4+MIbQQLEbkXxKeTWpUsXBKeE0eI1PTAjcF6WyxWTMxB4RxNS/p7f9N/iAAc8k3VlXA8atIiiXuBIxtizVMTmGW+NbZ4+MWaqD005GnfuW3faU9Wui2Bm8Ootoa9JAc0LtK7xlzQCerUxP5Yhst8BUvOcPd+Vlkp6r4B CBqLRYuF rsK8Ih5UNflsFvkthbPn1X8EkRc0uuXCOLXShdLe7EYhAWa7XM0UelcXAcLhY9lw0jhfO9MfOhiD5EXP0p7p7iFIe/n2p7iyalUJAt1qmPrwsK0d3o7R+ThzhC/t2Gzrtfs5Bqe2pEkcLTRRKVM9pAvmjDXaNKMaGwIMJnrNQSMHNcPQR1SOpRNGr0rxzn8x2j5ZSXsZjTk3WVmuq2Fo5cFHdL3cryLsBoVSBRBe3QH9hnOgMH3tHSVLRsC1E1nx0JIoHD1n0lwpxYSoIPfo6uQZisv9V7CF1VBQvQxRZ+OWJYFMWzZNpSumjsaHXsvqV35Enc7ef2KciL4Oewp+gzNt4iYPfvCY76UxrlsXjpGUeqGfxufbIhhYikK6pBKMk8Y8NWoRFo/MrThhLCx6YNhQCEK1geKzMQhfXE2IU3Rv4sNRjqx6szkRS4gcudOrHEqZ1cD7t/Sd8PB5H6bv68O8t/QmCmGlLAMxCvqwMV3fX6DOHOgtL2sP0Mlf2lBL2c4YjKnK0VxN5e990I0CHM6U3ckGpw4vTfuNMeLkw0uW0uF+nwdciOQ6Ci7zzEFF8EiO8aPdcl5QXVRV/IQ5uWjzGwzHMCHwEl/9MLPUyRaPtxg3m95hznvASzoId9TrL1Tpxr0NZ4Ss5maqk8vin1Qga/fZy3Qh94xgAvI+9McXgv9sK/oxDux39rFRUQzNetEfij6lNs4IvFVVUyKZ//uRDouqOuXjVCMrL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 19, 2023, Yuan Yao wrote: > On Tue, Jul 18, 2023 at 04:44:50PM -0700, Sean Christopherson wrote: > > From: Chao Peng > > > > This new KVM exit allows userspace to handle memory-related errors. It > > indicates an error happens in KVM at guest memory range [gpa, gpa+size). > > The flags includes additional information for userspace to handle the > > error. Currently bit 0 is defined as 'private memory' where '1' > > indicates error happens due to private memory access and '0' indicates > > error happens due to shared memory access. > > Now it's bit 3: Yeah, I need to update (or write) a lot of changelogs. > #define KVM_MEMORY_EXIT_FLAG_PRIVATE (1ULL << 3) > > I remember some other attributes were introduced in v10 yet: > > #define KVM_MEMORY_ATTRIBUTE_READ (1ULL << 0) > #define KVM_MEMORY_ATTRIBUTE_WRITE (1ULL << 1) > #define KVM_MEMORY_ATTRIBUTE_EXECUTE (1ULL << 2) > #define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) > > So KVM_MEMORY_EXIT_FLAG_PRIVATE changed to bit 3 due to above things, > or other reason ? (Sorry I didn't follow v10 too much before). Yep, I want to reserve space for the RWX bits.