From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21335EB64DC for ; Thu, 20 Jul 2023 05:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DDCE2800AF; Thu, 20 Jul 2023 01:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98E6A28004C; Thu, 20 Jul 2023 01:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87D242800AF; Thu, 20 Jul 2023 01:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7A2F028004C for ; Thu, 20 Jul 2023 01:22:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 33073140137 for ; Thu, 20 Jul 2023 05:22:37 +0000 (UTC) X-FDA: 81030845154.06.1C8B2A2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 83940A000D for ; Thu, 20 Jul 2023 05:22:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tYgOcUvN; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689830555; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CDKYREQdRXyTlFXvhiTxHWPhw/v5r8WPhz7dV9fWKqU=; b=rImGb95Lkivn25UcB5Ak77zt18gvzZo2lxkLc2/dH+Op9WI8TVL4DyjxtCxVgr5OejDx39 Ccf+GJeCMWd4vXHE9OOYuJ65e0No7Dh9CzxBJuFXlqS5wAq8xygVC/cd8H0g1aRaYpWphY eDyKW6hP7v5R2coFM90V5aDLAb4jUk4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tYgOcUvN; dmarc=none; spf=none (imf15.hostedemail.com: domain of BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ae7cc45e83adbe90d207+7270+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689830555; a=rsa-sha256; cv=none; b=m66vKs4meahVi3HQ4RwLHAlG/WVtj5X6CK8axhHu42HMCBZVSiRshmikBnsVVw7GgeoHEl 8dN1iAUpNhntzqn/hqcQnFiwu/ASZX6/ZazCRlRpHtZzxs8LDyT43UkSnPBq1N9JBXSvfF MM9AGx9oW5yG3MxSrNQwtkG6YR8UqZ4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CDKYREQdRXyTlFXvhiTxHWPhw/v5r8WPhz7dV9fWKqU=; b=tYgOcUvNE6Cg4zr2JuXcJPczFB DXC6CUKnyFJOBQqHeqQAoN9bj3gxTr5+AmnZ4hxKsr0pmF2lACUlK2M+NNP87bo3wnJL/DdXoIzzQ gxj5v0eWICQYh1S1fksK4QIh50kNiKsq/HyxQmqjU9ewjR4V4nof6B/iuCKLtD/fGq+gZyAHheox9 JAV+ubv2L22CiXGk0iGyG8V2mVlLuSmkGJQifQSDHa2NEhb2lxtHn9zb52hlxiEbJtb1J4o1oYogK H9HumonrZHn7d9qmnaVYMi7pLSHJZn4LDVUmhZFsnbzUm7YpXm843JRMa/WfTYCca84Ddj6099c2o uxE0+aHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMM7V-009p1m-31; Thu, 20 Jul 2023 05:22:33 +0000 Date: Wed, 19 Jul 2023 22:22:33 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Peng Zhang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sidhartha.kumar@oracle.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, Kent Overstreet Subject: Re: [PATCH 2/6] mm/page_io: use a folio in sio_read_complete() Message-ID: References: <20230717132602.2202147-1-zhangpeng362@huawei.com> <20230717132602.2202147-3-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 83940A000D X-Stat-Signature: z6oesrwx37141kmgfgnikwitg9ruox8q X-HE-Tag: 1689830555-704257 X-HE-Meta: U2FsdGVkX184hhXGkuO534QZ/kAjnDyyzaeisHmHdaa5j0bZCghPEqkSsFZ4enJCd7Z/huIU2DojqahreIGeIa4yjycfMsUVGkyA7AA3A/7qJOhxeXHOnCqVSmTPukdHpOIICKUv9Ue7Fp5/q96ygFiwweab6/y4Z6GWD9JIhj/ygrWw3Lb2t8XpNSQ0quLBsoTf153LV2boAetHjimtfY8QiP+ah+3gh0m/pqHn1QY8mAUswAwGqH8dClWyApKvJHYsfVzDSMgoMsV1CVGruxDxOGGgI4oxxdjCADkZqy/p4/k1jJo3Xr5LtIyIytdsa5YwAQW++zEWhPjzHapcdQpVZr2C4IR5a5X2RkOjdb6hW7tgKEMRJwyADV8dtGyJHEHnAhZv6M1SEPz+XkLe+GcGkQFgKZzpdVDpcwc+YQn0bd643RtWsGNQoj9Xr8kSlCQ3teROgTIoLEB8Ph91prDNLH4vTNctUx9+lNZ3LoY6i+W5hG5Z31dKX9ACFkX7wNZqmBaYaLkg+24LdoP2QRg8RDdF1b6YhN3LIX+QuDcJYFkMPjy4voeO3JzCTBD/1NcsHomuk0HRMWpMCO8vyG8Kk98RAba7yWpYqSCB3WkUkVEu4cDJhyoiwiChkKo8kjulsv8W0mg3WPbfPociN0IB0M8oQXX/vFRi8xTdnRKsrHwmJ5E/p6FSzYmagvh5TpUilgXnrBiOf7svwlueCI8U+Q12AWFJFjkKDOUBAcQlbdPw9BwC6qb4hZmWvzcH0sXuEM8OuhvsDGtq+rXhFoX0YG0f1Ngvq1nnTxyZFa8ZeMV0fVYtrVhNU9cYHe3CQ8/1GZI+sxyLAkMIJPeRbBWfntFbly/DfTcwy2ZmB0kO2HoMLlRua24HnFGkvhGz5oJ4MSD4vW5O4P6TO5Idkg0vpSX5Xq2GzFubPXHxsTTgyC0mg2dsFke2HpHayXXvPqrmznd4hyolHClf5vj zgsVo/xh Y/VwCJcK7NjfY1JEgbUi2jMEzsJHlg1+TFefp74jz4HuaBj68MmLFHSUwddnQVSeGckoj1W6V/Vcha0g6Sv16OYw+8U5LeEpU9z02gYZzUVtrd0rKO3l253BeG8eY6UXgXS8OzmQeg6j+EHdRs+4aQPoBOjef1II37tkXmX1mXjAM+Ct2kTBDeYbjiurltizqf6eem+W7sSzA85LWZao9WwBfIXI5HIojArCvS5dG/loF7iRNR3SwzMmzcBLNAgQ8RSSvOc64oLcrgImiJvcdd5k+gt+UJDOZTbvS128pcbTXrcDLxzxBBMHOacFl+lR6dIHFUuzhgmWHw6EiC9tqeTu3HRws0bQJbU1KYbMTCpVz5gG/epga0q5Gwjjs4HJuq9YfNJ7Nw8gRKjILMJPwYzZ0WRD8Lw6PcZ9g3SHHqdMZuGZam/on21hYiEFEhRlp/qFZi7e1PluZiRzghtHJCO9BX3hR39sw+LHrEXz5UkrOuZ1UGb730TtP4X8m4Y9gR5HK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 02:40:24PM +0100, Matthew Wilcox wrote: > > for (p = 0; p < sio->pages; p++) { > > - struct page *page = sio->bvec[p].bv_page; > > + struct folio *folio = page_folio(sio->bvec[p].bv_page); > > > > - SetPageUptodate(page); > > - unlock_page(page); > > + folio_mark_uptodate(folio); > > + folio_unlock(folio); > > } > > I'm kind of shocked this works today. Usually bvecs coalesce adjacent > pages into a single entry, so you need to use a real iterator like > bio_for_each_folio_all() to extract individual pages from a bvec. > Maybe the sio bvec is constructed inefficiently. sio_read_complete is a kiocb.ki_complete handler. There is no coalesce going on for ITER_BVEC iov_iters, which share nothing but the underlying data structure with the block I/O path.