From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA8BC001DC for ; Thu, 20 Jul 2023 18:14:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D1C028014C; Thu, 20 Jul 2023 14:14:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 781DD28004C; Thu, 20 Jul 2023 14:14:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6711728014C; Thu, 20 Jul 2023 14:14:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 587CC28004C for ; Thu, 20 Jul 2023 14:14:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2068440243 for ; Thu, 20 Jul 2023 18:14:04 +0000 (UTC) X-FDA: 81032789208.06.B8A69BE Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id EB88E80014 for ; Thu, 20 Jul 2023 18:14:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZKZ8VZNv; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689876841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5FoFqUFeB/KEI6d1Tdr/d4rFzeHsyUVBldPSTkCumKk=; b=hd/muBi9BEhBCan6YL/4dHO+RclOrn4k+qQLMi5V1Rfwwk8CAM3bCaUd38c/9iZmZZrjPz j/F+rIOxtZm4agCpbjS36r7qNRdaQ6xb7Cc2GC6B+7wkA1tCA+mfQ9vZuolnhqWzd+6Thc cI+7/NSyQN89DsnagLWsG5OTCGNNQ/I= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZKZ8VZNv; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689876841; a=rsa-sha256; cv=none; b=FwLRHPohnUVOPFQd/K4YjQilkukhu+k+nVFHn2vS3NOdywlH4Wn22Ni7d3GGzI8q7LPNWS Em69IVjtnetaDdHHrT+s1ssLu6YGhJ/EHJ8Oz9W+q7KKUyCkcIFSLLDPnV+T9b9w+PjP+D zH46ef5mqxpeu8v0peKHVpsvCGN1oRE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5FoFqUFeB/KEI6d1Tdr/d4rFzeHsyUVBldPSTkCumKk=; b=ZKZ8VZNv84DJ7jUh969Evun8Hv vtentQJqqmy7CFnHE/mCKPLkm7+6yrD7+2vH9Hprzn8A1LzrVC0Uir/ZZUou7WUHY5cKVIcvHQuw4 nAVFY/x/GaSYvJI1hHSRpd06nEXGFbBM5LidTsWAf4faM/piE7H4veZ8Z1mRQbHlq4pPwjf2ylEjY NdLDeWR8xjGPaVUZ1HheMUzCfdfAxRpsFcykjriOLz+zQG+/a3rwQlA981jgIxGZQ5DXpHC622ZEu HkXQhyT7saFUTk2sJl21OJF16Q2suGMXk4YO/JBErbuApW/ewFBZylx3O14A+lS+++XEBjnRf06qx vpWIXnnA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMY9s-00BsQw-0G; Thu, 20 Jul 2023 18:13:48 +0000 Date: Thu, 20 Jul 2023 11:13:48 -0700 From: Luis Chamberlain To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Yu Zhao , Kees Cook , Iurii Zaikin , "T.J. Mercier" , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 7/8] memcg: add sysctl and config option to control memory recharging Message-ID: References: <20230720070825.992023-1-yosryahmed@google.com> <20230720070825.992023-8-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720070825.992023-8-yosryahmed@google.com> X-Rspamd-Queue-Id: EB88E80014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: heg8bztdemopb4f9hkkbisxkfib8esie X-HE-Tag: 1689876840-892533 X-HE-Meta: U2FsdGVkX19r66XwXiYz113kSQBQB9XQn2a4aDQAo1lmYoUbZ+0vmr4T+4gwkT+7FZrYd0K5dWhr0EK8EKMRmX46AqXI4qTnDmFUx9/YZ0353Gy3IrkyzKszxnEI2Qxk2mZ6PgEPKbZNm4tm7fdpTWOLONSvoqBgans9Z1lLszL6A6TYHn0V4s00Q+kcO1U5L2fEzBzS7PMMb1C0ul5ba24klALCf4MjWaZWVhZcevhobRJJaos0Aw08q/LE1LKpWhx296/LhfRgj0n1l28i77Jad53ID7/UADlYI02PUBGI2aotPIqFp+L5ZZTNFvb8GBlQ6kQHFRX86arpSp9WcTdNH9fHBFhG10I14JXsS4yKry69yz/pWMIYIkLBCkJCJlnrq6bxXRdG6WF0FLPEBNtpox6gf6idGF5JxCqPHvwPHRQn0qu8luftILFiuG6iy/zqpsbT11a2e6aZlk2m5i87AXRaPYmnnroh+5mMeq17+dTaO5BfHgplFxRtBXhYwtwChvr23xPlXZllDCW+2Ymrx965m3+yHv1Jo0NivDXbSz9P7XIyOYU9J/4BcPFU8+17i8H0YIi6gQoDLVf5hRvHHBpTn7TRiV3zAGSh2tzEJjrSwvi8DBz4+vLLnhagR2sMWaAgnFuFaubluLTk87iYU1fgSOxJXhsAUKusZBpArlwJr/Z246AhKQZG6hDVGQA+7bLVXHQmb5EkBDnyO0Dr8/QAta1ceMPwS79vadMszb/B2FFpMEEWvXRmoC+dR4e1Dy7iPuXQHcTgsDKmdPJ9pPMtVN8oIRXBwDgv+BwXgVO9VIjPMql9qgKfZ+hWWgzIihB0rtMOCHO9lwzMAH5ynbNidZw34tIZ5YVw6lEI8N6MNQGwZISkEDGwadavjL+dYWqOcRPeiVIvBjbsOL23Nc31Dlws3fBe2opAQHSgKHmtNoNHoU879B15LqteqTz0EwvjdyYhsrDcnHA Zl9iLLta WFM/bQz7BkmeFqVy/Q4tFyYjiMEuVeQbYK/APqLdYq5k/R2sGOPGjuC2Hf39oF3Gfl4Z6/JqedDibWTlgxpc5H3Z6lkS+pCjw73o+kQTjtG2Xc7vh//w7FwSyR3HTdTtyDxtXPoIAVLynadcVgCId9yX/K3l2GjRClPnNfJ1nO1+riwp/AmW9IdeE0O6r5NcnEX67CI96niRFbutR8wqhA0cYF9Cj/+IRJXm9xoM/6m2Jv86qOCfABq+49NGsAkKtKeTiGASEigzW41pxN1jmAONUcjC1xi49D1o5LS3cubDAkWUlhOQMSfD6UKxm4bNoQnxjFaub4GCUFWk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 07:08:24AM +0000, Yosry Ahmed wrote: > Add a sysctl to enable/disable memory recharging for offline memcgs. Add > a config option to control whether or not it is enabled by default. > > Signed-off-by: Yosry Ahmed > --- > include/linux/memcontrol.h | 2 ++ > kernel/sysctl.c | 11 +++++++++++ > mm/Kconfig | 12 ++++++++++++ > mm/memcontrol.c | 9 ++++++++- > 4 files changed, 33 insertions(+), 1 deletion(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 59b653d4a76e..ae9f09ee90cb 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -60,6 +60,8 @@ struct mem_cgroup_reclaim_cookie { > > #ifdef CONFIG_MEMCG > > +extern int sysctl_recharge_offline_memcgs; > + > #define MEM_CGROUP_ID_SHIFT 16 > #define MEM_CGROUP_ID_MAX USHRT_MAX > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 354a2d294f52..1735d1d95652 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2249,6 +2249,17 @@ static struct ctl_table vm_table[] = { > .extra2 = (void *)&mmap_rnd_compat_bits_max, > }, > #endif > +#ifdef CONFIG_MEMCG > + { > + .procname = "recharge_offline_memcgs", > + .data = &sysctl_recharge_offline_memcgs, > + .maxlen = sizeof(sysctl_recharge_offline_memcgs), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + .extra2 = SYSCTL_ONE, > + }, > +#endif /* CONFIG_MEMCG */ > { } > }; Please don't add any more sysctls to kernel/sysctl.c, git log that file for a series of cleanups which show how to use your own and why we have been doing that cleanup. Luis