From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F5EEB64DD for ; Thu, 20 Jul 2023 18:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C866C28014E; Thu, 20 Jul 2023 14:31:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C36AC28004C; Thu, 20 Jul 2023 14:31:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE6228014E; Thu, 20 Jul 2023 14:31:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A0A1728004C for ; Thu, 20 Jul 2023 14:31:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5700F140248 for ; Thu, 20 Jul 2023 18:31:05 +0000 (UTC) X-FDA: 81032832090.21.0F04886 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 548F1140015 for ; Thu, 20 Jul 2023 18:31:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k0wUa4Bc; spf=none (imf26.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689877862; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TVc0DH5y5ZMGm3BerZTpK/u+XD4hMTin0vDBzxNt6yk=; b=LJ4UhrINDKOQ3BDprloj1jZ1aY1ae646MO+o1g4Lg94biA/hgWN/bgOc030+lU7jAzZQF2 vap+K3LJfVQxWHi6WVOZi+YUB8WfVcE4jh0l3FeCVQnm0bKhWI3uJ11NwHtzRU/QAwfju2 TCKic45tPaIXsIpZvcEzWmfDG4zyP18= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689877862; a=rsa-sha256; cv=none; b=dVkNwAKyTVTeNZZb7h5iMdrbngBgqVd8xq0brXQjUDdpE55CVKavosLaYVaXJl5cZcVYAU TC4S+FkczVzkQztPYjaoTHnq/qrI+i2+ugH/cau3QfUEPeOWyJArwLV3Z0pKylIqn0nbGp YSeJHW46+zqVAEnpyJfbpELItGdvpc4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=k0wUa4Bc; spf=none (imf26.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=TVc0DH5y5ZMGm3BerZTpK/u+XD4hMTin0vDBzxNt6yk=; b=k0wUa4Bc0gX81i186z/h55eQuL vN2ed/onpM28iKxC4yEvpheHnOUG0NwZNNTD58Efa5NxWnv8JEi+GPkO0rBNzcOVbiOC0JDx4vExy 62BA0UYuhCnDDXCUAcHUFoby7XFd5M9jWSdS9lfREMafDc3OHhgbMYx7lejYTutJ2gFH9OAkhkD2q Iex0W2rl79yFoa2zJp4tUDJuQY6KkxOA+6Q/NVHpzYBA8oL3jzUcj/YbCkwN9ejIWCcVMrHZOMy/e oILegG1jfTpeFUg80y2sMHbIdrvmHw5WpoMbIiyPvoeDu0hQru9bMv/Xx+SN3p+prtgLGa3MNUuJw 4iYrGLKQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qMYQL-00Bu7e-1E; Thu, 20 Jul 2023 18:30:49 +0000 Date: Thu, 20 Jul 2023 11:30:49 -0700 From: Luis Chamberlain To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Yu Zhao , Kees Cook , Iurii Zaikin , "T.J. Mercier" , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: Re: [RFC PATCH 7/8] memcg: add sysctl and config option to control memory recharging Message-ID: References: <20230720070825.992023-1-yosryahmed@google.com> <20230720070825.992023-8-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: efspkhgxwskqqki69zc9umrwi1xducm7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 548F1140015 X-Rspam-User: X-HE-Tag: 1689877861-525155 X-HE-Meta: U2FsdGVkX1/wTzv0iJD2AQwNHCVYqVy5ufelJlBFjU3yKTAV9dy4WDj5w3Wa9lWDSGYPBMEWfpMEufWvwVLVep92dBzR4+h1hiMSWv+kVw0HRhbT9bewgUnLbw0b1b6yCwz185BRg/yyPnBmz+JhPxAOpXEh834J95OtHPCibH5FgBLD6K14qsx4I052A/+M3WwtFXutv7yN9v/R9x8XStS2Sb8Uc5LfKs5OMWsQAf7vDIcraIXFYBB7UxbpfKholJVZosB86ZQd2ZmTWwj7alXGwZo+bADdOvSGpsAmsSoszjf1+lmRouow2aZBvsyQt8ow5NmZr/QAj/2F0QiKtJCGZwlMgXRJrR3ck3xBSCSNDIGORML6YGjQmPNVj6cT3EwW2zHiufMDJVQod3QQIQNt40G20571pKwwBFwHwZq9CwTDigB0slhgOoUupllgevBrMQAG75N0aspEifOHEUFJRdE3HjhmKM8/70cKMS0hNaZCo2xkaoDCjuN6iktJ/Z8wMBf/rvCw/7UR2jsCK/r/RjzIemjOxPKqRGwuF13Lj7MLp93kHZF2fbYtIUqwzvwg0LAvqs3Hyc97SYOYw4aJi4R0ctU1I6MQyYM98vpbgf/xfCEebQU3lNpkajb875J3hh5mbpKSy+lX2djk5OBD8HXRlIOWT+lq5rmhWYsLuFPtOq/MOxeSjsneHONr7pYoF3IZlFrC8lEAioJ6JOeKEVa+0PCGPY6Wsujy3NDX9dfKEEP8pzZUNMtA1ZmH7a5X1GKFLcrmOvk9pw6823Xl33wGX1BCTk4+w56tEFrMFgq1Ek2nKjWa8gTKw2hg5Jx70pjnWp04rBlZ5bmPtPTn6FbHQK6ohQoSgEx7D+VT/7Tm0ZftxyiBeh5I6XUlwXgOy7yrtsSapYhocrseUVOubrm1f5GPRGtwK7Lu/oHc9CUbN7frmwOOuW7NHz4JvY25NffQrRB6qgnk2md xHYPVJjC ZIPp4gjQYfs1zOnU8Wfeas5sRsm1kbHrb9UTCYtTmOz6VqW912aJ8FlaBYVas6fzjQOiMNgZbLUChmEVHDF+MaAD9xLP+FiyPp5tjyy2pKwG6e61Z8dgYGL/Kb5kYZ+CzY5moL6lAvd4kZgenHUYrLC8QanC+NgF/Dyjocfx412fApibf1CP+lX6c6TYKw2KtA3DmYj9NoG5D2NoPTU43iwqqG7+xsH1TFTPI+OwPdzJ3Jo68UvlnT/Q8dgF6NupBbcqb3lG1c0EFqf7oQW+qUPpnKv+EILM5VmmKPPusIioUJeOb8FUOiwQ6VGwYFSTJUK1JhZNKjzT0XHMp4ZJkhewubQ9hY1ZXm1UUfsujNzcHODrLwDQbd/153ven1sc+TVtoY1xJaxAbuBc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 11:24:20AM -0700, Yosry Ahmed wrote: > On Thu, Jul 20, 2023 at 11:13 AM Luis Chamberlain wrote: > > > > On Thu, Jul 20, 2023 at 07:08:24AM +0000, Yosry Ahmed wrote: > > > Add a sysctl to enable/disable memory recharging for offline memcgs. Add > > > a config option to control whether or not it is enabled by default. > > > > > > Signed-off-by: Yosry Ahmed > > > --- > > > include/linux/memcontrol.h | 2 ++ > > > kernel/sysctl.c | 11 +++++++++++ > > > mm/Kconfig | 12 ++++++++++++ > > > mm/memcontrol.c | 9 ++++++++- > > > 4 files changed, 33 insertions(+), 1 deletion(-) > > > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > > index 59b653d4a76e..ae9f09ee90cb 100644 > > > --- a/include/linux/memcontrol.h > > > +++ b/include/linux/memcontrol.h > > > @@ -60,6 +60,8 @@ struct mem_cgroup_reclaim_cookie { > > > > > > #ifdef CONFIG_MEMCG > > > > > > +extern int sysctl_recharge_offline_memcgs; > > > + > > > #define MEM_CGROUP_ID_SHIFT 16 > > > #define MEM_CGROUP_ID_MAX USHRT_MAX > > > > > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > > > index 354a2d294f52..1735d1d95652 100644 > > > --- a/kernel/sysctl.c > > > +++ b/kernel/sysctl.c > > > @@ -2249,6 +2249,17 @@ static struct ctl_table vm_table[] = { > > > .extra2 = (void *)&mmap_rnd_compat_bits_max, > > > }, > > > #endif > > > +#ifdef CONFIG_MEMCG > > > + { > > > + .procname = "recharge_offline_memcgs", > > > + .data = &sysctl_recharge_offline_memcgs, > > > + .maxlen = sizeof(sysctl_recharge_offline_memcgs), > > > + .mode = 0644, > > > + .proc_handler = proc_dointvec_minmax, > > > + .extra1 = SYSCTL_ZERO, > > > + .extra2 = SYSCTL_ONE, > > > + }, > > > +#endif /* CONFIG_MEMCG */ > > > { } > > > }; > > > > Please don't add any more sysctls to kernel/sysctl.c, git log that file > > for a series of cleanups which show how to use your own and why we have > > been doing that cleanup. > > Thanks for pointing this out, I definitely missed it. Will do that in > the next version. I guess this will also reduce the reviewer churn if > I won't be touching kernel/sysctl.c? Right, it means I don't have to care anymore about random sysctl knobs. Let people knob it all up. Luis