From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D20EB64DA for ; Thu, 20 Jul 2023 20:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAFE728015C; Thu, 20 Jul 2023 16:20:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A396D28004C; Thu, 20 Jul 2023 16:20:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2B028015C; Thu, 20 Jul 2023 16:20:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7879428004C for ; Thu, 20 Jul 2023 16:20:16 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F81E1C8C6D for ; Thu, 20 Jul 2023 20:20:16 +0000 (UTC) X-FDA: 81033107232.27.7978491 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf09.hostedemail.com (Postfix) with ESMTP id 824D6140006 for ; Thu, 20 Jul 2023 20:20:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mbsHztlE; spf=pass (imf09.hostedemail.com: domain of 3_Za5ZAYKCD4xjfsohlttlqj.htrqnsz2-rrp0fhp.twl@flex--seanjc.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3_Za5ZAYKCD4xjfsohlttlqj.htrqnsz2-rrp0fhp.twl@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689884414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s1/m4T5EZ9UQZdIAs+CFQOUhGGMJn3z6NAlZtvxtssM=; b=UY+kOV6rM43akP0QRxPL6r6hmJdAjboDHe/2yNCuxhKYUBXTOnfNUC4/sz20iiK5qCgqgq Orlr1qz7K9bEfT5x/xyoCXX/18At2tnPVhFTdZwNZ8Dz9poTVQvPOoZ7wxzu5Q9nKRfjvx rqTuNPJ+9NFG2Rd1UPEl43fE83YYbts= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689884414; a=rsa-sha256; cv=none; b=bBVadjnSSXTr30PbAxKtUP0Y8AiUCTEFfdwFyPF3krGWFnDm7nnW7ner1AMZcTqNWwh9lW gE9k9UXCrbodYP2KN1R477KW3HYzZD9Zye8YAMNTJujLt55JKJDnms0jBk7HCMwYgAwO4A UcIRA97lUGYbNIGODX622eT6eruRq3o= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=mbsHztlE; spf=pass (imf09.hostedemail.com: domain of 3_Za5ZAYKCD4xjfsohlttlqj.htrqnsz2-rrp0fhp.twl@flex--seanjc.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3_Za5ZAYKCD4xjfsohlttlqj.htrqnsz2-rrp0fhp.twl@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-bd69bb4507eso1031177276.2 for ; Thu, 20 Jul 2023 13:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689884413; x=1690489213; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=s1/m4T5EZ9UQZdIAs+CFQOUhGGMJn3z6NAlZtvxtssM=; b=mbsHztlENnOTDgeCIXRdF8x4x9OfLSlTRQf7EJhk2yHC8ssudjPjJb663muGwwAUde HXusCSecX8QAy71He4xwRicW2VAZ7RFVOVmJQZun5eygpfocaFcEhJVdz1DXPqrP14f5 Q9r/63tqP/iMmto5FytBtXhV7bicbpwNBGhhzc7AVroN6uvn7SvVpiEQCLnIHWcphWhi L6PAVpT/JWEQDmjGRRbXmNFkgwEJImoyKV1xDjpLesAAmXECVa9yb/PUNJmSrVHElsLh RUk/Cxj/0yokxjf+pISM5EmdcaPLl3odQz7EeG720kJEtO6hviZvCg7ubhY+cpI9tJBr NkXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689884413; x=1690489213; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s1/m4T5EZ9UQZdIAs+CFQOUhGGMJn3z6NAlZtvxtssM=; b=COtle+xY1vIY1ZNS3fKU2CFMFI25rm68umNxXKJHdcZMBAQNHuKKD60Iih0b3JAXuN q7QzoEkNElkfOOosynMZJDxeePASn+50RUgjh7JZzjO82KoFA5EHDcKIc5zGK/TCihz+ Rvy7gsbYpnUteEJ9W/M11UD8Y1kN5YyxMNhEhHgn7vRwHFJR2Ynez6ZuWCZ6qxeTBKmP Egx+fVk+e14dYCtchKm21FNA9wxAWn+vU+fwJbHl5WGM5FfYV6zdPCnnrx7vFpHhYFz5 LIaRJ6J/04d7JtAanLOdh9wjGJlGNaJh/eNkzm2xoro7vqnmccPZrLog0vkyQ5iilCEl 0QNQ== X-Gm-Message-State: ABy/qLZTUsngCHYgYUuCfUluOqPojGssy+TfmFKMRwT9t+BOs8BcoPEl WGI1UiPPkRJyY7pr9PogGOdPFwc+Eh8= X-Google-Smtp-Source: APBJJlHJCm6H269xOtL/2AMirqWxt3kOhxlKiB8lLLwF2CbQnv6wXW7fNhFjFSiI4U52DqkXiLsyKn98s/w= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:4d08:0:b0:c6c:6122:5b69 with SMTP id a8-20020a254d08000000b00c6c61225b69mr236ybb.8.1689884413509; Thu, 20 Jul 2023 13:20:13 -0700 (PDT) Date: Thu, 20 Jul 2023 13:20:11 -0700 In-Reply-To: <20230720190211.GF25699@ls.amr.corp.intel.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-9-seanjc@google.com> <20230720080912.g56zi5hywazrhnam@yy-desk-7060> <20230720190211.GF25699@ls.amr.corp.intel.com> Message-ID: Subject: Re: [RFC PATCH v11 08/29] KVM: Introduce per-page memory attributes From: Sean Christopherson To: Isaku Yamahata Cc: Yuan Yao , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 824D6140006 X-Rspam-User: X-Stat-Signature: 4ejxeghasrtxw6urb8mq647w59hjmugc X-Rspamd-Server: rspam03 X-HE-Tag: 1689884414-136119 X-HE-Meta: U2FsdGVkX18uhoK1Z7dwp14Z8KuxsVa0SIQQ4q23sG8p3cUs4vOH+ZM6NNfSGP5ZKzJICBubY2aHKQgYQ8sY6IJYGqpoZUO851OujazUn3eOjILSxEJylM8Fpv2GSuYjDs+wryWrFqHhTWePg1QvP8bLPFj459SkFjUj7kiG5MHRlpAOtnMmmP5mfrVVYptY+0AcItSmOaXddVkWPAtV5k9kJpbwiOlbA5Fapnxl8nsYjTKPkekEfXRo90vOAPpVM/mCrMrumnzdYIcrR7TEXNDz8gBmf2GnsVDCcJbTlaUqjvkCF82lhlYDO7JWuXmLLG1aZuiy+7QkXMBQiykNVNyv3qLxYD3sPCPBpoLpElEoAqHhTKgSBobSKel0ocLnIQZO+varNdEKIZPpPZBos2hxacK84U205gae6QnWKkdEAcQ+NFHwo8BnfrGKzNlKAVtArq87A/npkWGeuH+nJPIVWbPx9kReKV2NajOBnu1dROt6ZosdqKm8tmV6FOZYLLg7jeLzzpSrjhvzm15jsLbHaoRbWnw1qSq2VOxFLcanXTuiTlpBTZswIxx3zF+bltaweDuFTeBqjvMzY3bckqDvkmDUa3rvydEDh8DvCjaQxJmaIF013noI9mh+3zK4dqY39OFw0y5JWOlAyUbOutfUZ1XVmMeXXugW8oVWnT8OUBgAJY4L32gOSpnMeuy3Vimpfti6xK1H35JFDD/3iqmpnwb0AllbLpIqoSJj/gFKg5eD/WGbwGC5EN98SliP2BKuEstI+v1FiD1KtpeKRxVua/1TLQvFUVHOvvHSGbbqqMLWXaZf2LD7HK6K0eBCFa4Z0/fu+uoTtW+BHKCLnGHzd+sZjadT3q+OFuucnWuFH+laUvRnVproBEMtbd2Jdk4M2WZLdIl9MkWUTi5R0Q3DRU7g3+JUlNQgXbxkP02nCnoge6tleoPCnm4ZIUHywTXMNM0h6vlZDZrCpSY Zj3joNOO dMXk2M31kDpQWYcECkmjOG85xW2Ll7rw1CrvO5FJNO4gtrNdHOqK5lqCls8+YuXwjemi3/+JhNoJeHAiBMTlWpa2UmSF0c42PMSMzdrBaXKjOSuulAGnKhmIPLBvzcGSH7ILvhy0McJHLV5264O3EWXgCh2E5nEbHgI2iuJPuWJ+pPzE6VqlyiRgRj+Bw/qFPOCx3s1d0qyZAlOS56A5mNMWuD3gze6XUoa7fIz3HF7HcMmcLtf7x7YwjL3B9JE3WKwVPGwBOumU81cDmGwcPcBDZXlcvc3S7ScXL4dHJnMT3h+QX7UP1igQIwMOgEUp1ITc7gdn9VxklIzitS2mR7Mk+W/7nocEH+na/IEvqcm+5EeyB4JfKkkOS9+ShUMb2Bxw6cJ6rwQH4OznQqj6XLVFKXHOUs5H+3CxlZcOmDv5OI01m3VytTD3n2nBzEgdFFQ7wLG69EREmslWX1L2yxnfQGUbftI5P/de9/2LGOwpo3Mlkv+I+ttjFiU8FwjZL+I22L0NAkoQX1WeA+hvyFV/uipcItCpk4aWEANFFVoDIL9J/o+jzodANqnZhqZsoyBJcQYbMOS0U05HAY8GNhujNJbERM3pH51gE6RNl3QvnZLQKeJnO0YORX7FExfY9N1BzEhYozRjwWVO7q6TLeUrMkfMG7OwzzwVUva99b1k55bI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023, Isaku Yamahata wrote: > On Thu, Jul 20, 2023 at 04:09:12PM +0800, > Yuan Yao wrote: > > > On Tue, Jul 18, 2023 at 04:44:51PM -0700, Sean Christopherson wrote: > > > @@ -2301,4 +2305,14 @@ static inline void kvm_account_pgtable_pages(void *virt, int nr) > > > /* Max number of entries allowed for each kvm dirty ring */ > > > #define KVM_DIRTY_RING_MAX_ENTRIES 65536 > > > > > > +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES > > > +static inline unsigned long kvm_get_memory_attributes(struct kvm *kvm, gfn_t gfn) > > > +{ > > > + return xa_to_value(xa_load(&kvm->mem_attr_array, gfn)); > > > +} > > > + > > > +bool kvm_arch_post_set_memory_attributes(struct kvm *kvm, > > > + struct kvm_gfn_range *range); > > > > Used but no definition in this patch, it's defined in next patch 09. > > How about add weak version in this patch and let ARCHs to overide it ? > > It is guarded by CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES. Yep. I don't love the ordering, e.g. this patch can't even be compile tested until later in the series, but I wanted to separate x86 usage from the generic support code.