From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4B3EB64DD for ; Fri, 21 Jul 2023 19:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 721FE8D0002; Fri, 21 Jul 2023 15:29:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D1148D0001; Fri, 21 Jul 2023 15:29:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5987A8D0002; Fri, 21 Jul 2023 15:29:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 494708D0001 for ; Fri, 21 Jul 2023 15:29:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 16E34C03D8 for ; Fri, 21 Jul 2023 19:29:19 +0000 (UTC) X-FDA: 81036607638.03.A672CDE Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 360DF16001A for ; Fri, 21 Jul 2023 19:29:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=GfaxQaKw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689967757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6PVgaqPhmt4wq0AWBCFQwFhvxfFvbSlDYNh4o0Ppojs=; b=XcnDkayIXvcx46I2lc0XAbRuHMQyjAiZ20MKAPt3rdAEeK8jYt3CclIDpCQJz4FK0UNYIW 8mTZw8/CH/YyTCoU1Mz3ge4MsXQSM0iZi/+4K/hzFkTyRscMK5Tz1UroC3WFw986UncvCR A/WCCtplJhloQsu7QyvatZGPaeHVtIg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=GfaxQaKw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.210.173 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689967757; a=rsa-sha256; cv=none; b=byfA8vNnZXCdtCHrG0cpivAOkyPQfHiDq38JAL0xJGb5L24JNwcl1aWfvbjU8yazx2RQ3L 3yNrksK9s9S5rHSU8P0iH/R0xq9Rtk6rKSqZ/Ur7CmX5nh7Ym8jgtUs13uEthwPjqTrxn8 meYvj8efCZjZ6x2BUbWWZmh9/4IjPhA= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6687446eaccso2003811b3a.3 for ; Fri, 21 Jul 2023 12:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1689967756; x=1690572556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6PVgaqPhmt4wq0AWBCFQwFhvxfFvbSlDYNh4o0Ppojs=; b=GfaxQaKw5x3cV3SfUeA/pzqiy5kUPg0RiENjQHq5dJ46ftZgr6GcEH/8NPMVHUyb15 On/HsOGxBo53R9kz/XnoR9KMjvnJ97KGyHZILWXEZUXDlYAOXodZDrfICC/dFZ/SBWkd 1A9RMfpQiCSehrZEKBRYWCGM6pKRLOddyYpQM6Qny0c2Dyrj6km1I0ScE3lw/3LopZBU mHYA9vyZkoPJGJHI+Ym0bW0XfaN4vFlO0PPvWesldgcLxIRfysJNLp6bSRDAquiwOdvT eYGeNlDw9g03rR9btRmI3899ViEqGdpcH6xzhKko4eGdvLMWmTIAcasv3gC2fW/6G2ma 6EnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689967756; x=1690572556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6PVgaqPhmt4wq0AWBCFQwFhvxfFvbSlDYNh4o0Ppojs=; b=DOGWW/dHi1Ps4/Xx5fDugaqR8Q5/ithv3SIO+sVySIJENydTyOlNPQJU8bEX4iMV1r /G93XAaQyJLdzLh805Y/iyuwh4OHmKdSvAGPSlLtjjURpdvs1fvG9NeAQOLHM8+YHqZf nA3QvcwiwXEShcGAEtT/RTp0LxNh052rl6XJNBVLPicp3qIEgIZclFBmsYSLVw9pDN+L 1u7yS8Lvw/k5xo8NK8tjucKN8Q7z+C2rnfvsoVxCI/lxX/Ailcg/7E4/YkhWpX7zFJVd hXtgzVQmyYmCBbW8P9I4KcXU/yj23r/Uq+O1UHAQsJdAng4VHTuiWCbKzqLE/dzeriTn 4LlA== X-Gm-Message-State: ABy/qLY+/n/l/WrFhMuif96VKqZ2G/rLcdyhJtd+ApG/FaBcMYfHVth/ O4zK7+ExT+8GY3bPB3T1kWq7sg== X-Google-Smtp-Source: APBJJlHhX/ECiPtAgKTdPj/SAH5GJPTRrsthr/G8wSLG2KG1XyYAjgc1lH1BQS59ustvdAeajObIAA== X-Received: by 2002:a05:6a20:8f15:b0:137:293b:f9c0 with SMTP id b21-20020a056a208f1500b00137293bf9c0mr3542725pzk.33.1689967756135; Fri, 21 Jul 2023 12:29:16 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id i14-20020a63bf4e000000b0054ff36967f7sm3181162pgo.54.2023.07.21.12.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 12:29:15 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qMvoP-003IF4-QK; Fri, 21 Jul 2023 16:29:13 -0300 Date: Fri, 21 Jul 2023 16:29:13 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: akpm@linux-foundation.org, ajd@linux.ibm.com, catalin.marinas@arm.com, fbarrat@linux.ibm.com, iommu@lists.linux.dev, jhubbard@nvidia.com, kevin.tian@intel.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, nicolinc@nvidia.com, npiggin@gmail.com, robin.murphy@arm.com, seanjc@google.com, will@kernel.org, x86@kernel.org, zhi.wang.linux@gmail.com, sj@kernel.org Subject: Re: [PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range_end() Message-ID: References: <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <141e786b68527b1db9fc5a3259066c360448e7a4.1689842332.git-series.apopple@nvidia.com> X-Rspamd-Queue-Id: 360DF16001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: m81fus5suashcsjbokbn8sfxrg5d374z X-HE-Tag: 1689967756-539764 X-HE-Meta: U2FsdGVkX18vMNOZvbTayLlJCs6AZKmyP9UUmueAV3p61AtPeD93sGWPTu00DVH4H05wOuxK0unL/PQhLdV5m5X5uUT+XiYBPtxnA9KhNaZyAmgOvOsHKMYuD2p9+nHfBvizzxrM4EH4MDSAGPHGdPSKKLswiVUB9YCIiQmBUlYSfxDHtsWfRWNr7JUo9WVJmsXyuygiINIKe7v/HpRwIrg3VvydHGkoxbLPejYtBpbXJnYYTNZDil8Re+YBBYp2r6tIXhSauTPvwh7yRheih0Iel76smNY0zMWVauq9LRsDkExMnFkKJTD8VuS5XYklF/BUJ6xxo+U8EAWZnyB0JAhQA4/440Ki1qQ7V3KQTlPkB/W4bZ7INiDeNTWIUG2veEQJwc3+sp3qU/OghQHnL2aYDvLVyQf2aJZBdCpqpmQAcZ1Rq0siHZjbc9vgeiOMw7shsAzG2yL5aSZOOZQOnzkHBmye/3SUSvlcUKqI4QQWGquwr9lzdLMAPy3g/UuQNHFkHZUGLXuMIf3x7T5Tfd/SZ4S2HD6C8mhLeWxcuthSXwr+A+dvRnJWwEBVnlls2g8BjMGYg0XYO1TcEpkLUEyNXjbijfItuMxzDg9P1Y3q1eSCpSGWd7mSv3pWJ/fZ3KbGFmmSl9d69IS7f+XZIoRoV9bTuRpCjNf7bCh7tn21Gq5zAOP4d4YnfojnZrrtdV9oLRmxrCe7RLMj50+/7qBva0oy814v0TtFWLj07s4nfk1tfrNwz91m5V4KfnqrBVfnUBXCiu5ef48C12kfKQhLQNh1ZUt4FbwJND+xlsu7W/qQdoLnMSb/1J1egqQaQlhZZtdOfUOlgn5iu8lYB4cVIQyMLlGLevdHTIaPd716XfgzxFgbpJrSpdPeroyD/CVLh87viLHwA1OWFYgTL9JdeiSQC80rHWMHQl73ySpinhISngf27Kqj0OeCZ23octeUtglu9o9gHE694eq ZBjQ97w/ DJWE3e5T3UKgQVLQzLZeq0Gy1pGbrvDmjE56u58BfwwM7u9JjSbHtUPXPLTySAPA4tFtDeFJZkw9K7jincuCs0jHq1bpXlVKMxXsM+CTlQWftCWh/Xbih8byHVq5lZSB8HQuBCyrqealqwN7EkUlyUNijUbAJ74LcS3XdUMbhjVhIqvVyOmurFKtCul+wxE28p0uxim1NBtwXCzPa/P2bf9Z6paRabVsPQv/8LCCzPAU8rzW4+eCXF7dwuNnJhUOo6VjUKbmie5ZYWJShlZdO5GfSHTbkJ0PWG6ldYW+H8sZaflSPs760fR76yrKdJ3eymMy+/KgkLXW4x2mYXsoH85ZLAHMd/jHkHFBiTXF8nfBruyPNqkeklA1BaW/52uy6xvGYv1xYTNggAXnpEc2dpJErAmJzDL7JYn1+ygFJzlk96aeedJhlNatx4hqr6+oEqZWrcnCJX7mW2cFHaxfoHimUzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 20, 2023 at 06:39:26PM +1000, Alistair Popple wrote: > Secondary TLBs are now invalidated from the architecture specific TLB > invalidation functions. Therefore there is no need to explicitly > notify or invalidate as part of the range end functions. This means we > can remove mmu_notifier_invalidate_range_end_only() and some of the > ptep_*_notify() functions. > > Signed-off-by: Alistair Popple > --- > include/linux/mmu_notifier.h | 56 +------------------------------------ > kernel/events/uprobes.c | 2 +- > mm/huge_memory.c | 25 ++--------------- > mm/hugetlb.c | 1 +- > mm/memory.c | 8 +---- > mm/migrate_device.c | 9 +----- > mm/mmu_notifier.c | 25 ++--------------- > mm/rmap.c | 40 +-------------------------- > 8 files changed, 14 insertions(+), 152 deletions(-) Reviewed-by: Jason Gunthorpe Jason