From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87245EB64DD for ; Fri, 21 Jul 2023 21:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA3778D0003; Fri, 21 Jul 2023 17:04:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2A1C8D0001; Fri, 21 Jul 2023 17:04:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACA9E8D0003; Fri, 21 Jul 2023 17:04:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 983E88D0001 for ; Fri, 21 Jul 2023 17:04:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7408E4043E for ; Fri, 21 Jul 2023 21:04:46 +0000 (UTC) X-FDA: 81036848172.10.CB38219 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf20.hostedemail.com (Postfix) with ESMTP id A91071C0028 for ; Fri, 21 Jul 2023 21:04:44 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689973484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2TWvFaC6AvxQczFQknimLznH6e8RL+Evefj60YX6+Do=; b=JlNMY2TjtGszLJ8Qpqc6FU01sEazVSn8cqk2jOdj6LeoO7hozKYQJ8wNiBVhWAI8bYBQkr ulVSFFsYU2ZP1uHsglRsk2Yg+n3oqO/afyuuMzGKQL7ZR7WduajWgPwdarolUVKXtmPHSU jryeIs5PUdMBSoKxaTuyzAe9iJxXVb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689973484; a=rsa-sha256; cv=none; b=F1Kzl/3sSpjJbIbajjno1won8ZCfvzjkfdEXf3VTb7WEqRRB0UUkviY6CdsNXPFzDoO6qt QUJbHU2VKMxuD0VaCBtpibjT5WsIOCXw8S56phaocIJDbEvgrj+mrPzsPe265byZ2U1lcR u97Kp06w2anefThBQZk2xpo8wp6F6ok= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-78847bb8940so99867539f.0 for ; Fri, 21 Jul 2023 14:04:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689973484; x=1690578284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2TWvFaC6AvxQczFQknimLznH6e8RL+Evefj60YX6+Do=; b=gIkLw5UiBpzrrYvgt4ZqYxZEYo44S3x6Z/Pxu8m1JA+Z38C+IAfBdYFqGunzMfYEm5 b0U+GlUmr8mUbbii4Fiiknz1VSKpNZm/ompe0sx7Ivl0yyrfgs7MXtZlqJ54oSHmjO47 gc2CSvAWkmsN1pav0MbXhNq7fmAoX+345HJ+Ug1sUf9+Gm2ypI+tuvE0VxQtjADc/KYL dZOJeL+VibkUEky4ulEvYVRrsFIUx1EkmfzX3ypqiRRQE2BG42K+OpkeovMrcXdZvBYk qaBM6rqiRd2HsWWM0E8/e42RjgDXWMeha1e9iuuaEftvsdcPDPY1HCmK+FQ+QlwfFrfd 3qiA== X-Gm-Message-State: ABy/qLbS3wAHGSDsoj3MqvP2+en/ld9ExNscC9wAlEy0gKoMDSQD3Div 4UQPwUiQ7DnKHYUAPgbCQJM= X-Google-Smtp-Source: APBJJlFqtgkPnRDMjZf1te86CNa/yazgLKME7V8uGOU/ofEdeddbXOq24m+GC85MN1R4NKZgGN8nYg== X-Received: by 2002:a5e:c110:0:b0:787:17d6:fbc7 with SMTP id v16-20020a5ec110000000b0078717d6fbc7mr979927iol.13.1689973483785; Fri, 21 Jul 2023 14:04:43 -0700 (PDT) Received: from snowbird ([2601:282:1800:1f50::d356]) by smtp.gmail.com with ESMTPSA id q7-20020a5d8347000000b00785d794ec4esm1338952ior.23.2023.07.21.14.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 14:04:43 -0700 (PDT) Date: Fri, 21 Jul 2023 14:04:38 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 0/3] percpu: some trivial cleanup patches Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230721131800.20003-1-bhe@redhat.com> X-Stat-Signature: 5keo6zkrhpddgxctfpar6arif3gjxfhi X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A91071C0028 X-Rspam-User: X-HE-Tag: 1689973484-353385 X-HE-Meta: U2FsdGVkX1/oK63x6JZl6DIgq/FgUs8bbOgHtoUqlMXF56lZaO9UGk2sThoxreHRXuUIlLApLAGgSRPNXrFdLdnzXYnwmVg17tH+isN83mJJGJ82PQWXTTZp4nYRJB/LniUmPK5fz8rE1bKznsnk0tt/vRJsTuwDNfMXlUuHhjPTDRMDf018eJcVcYqUSy/guCV2GSDWDWI74XJQrhKaIXZDl6WFGWLMJHno8bB7TUndRjWj82vvZeOyqIzzclT+jZht2pNJSxYpb5Na+V9zWYm4n67juP/x8gaASQnFWQKRAo8TeWBP886CPtNcg1c7txiH7elRmEPV/EYZYRO+bEa5zBN3rS0e8ftgqD4+RtNs0zfHD8c/khzaNCRIU+TFy4PmmFt73bTr8JerScDxkjXmD/N+ERG+cEjrQT4KNZU74pYXmGmj5T66bErP+YE3jBlL6m2mVS+uPtNarjRYpcY9joc0voOl9IFxhG/a0AuPLhhtANcOtP6jE/5E/wHSZmhuAXaqzbPUFyewIECf1vD6FGTXPa4PMC7/3heLwe8L+/CDySN7jgLv97ld7SYj1pC6qBijWGKQ2IUjwQlxb1e9O24yvkGktzI0RFYMezioFxeRaq7I1PFe6BlgXn5qRDoRZKXHeSxr1pPhaAXG9uQlM8ckyC2uC7M9kDJBKwWDy6pc8tLdyqeIIdN/Ns9sym/1xbzl9n3yEiBfgE2SFx75HqLpq9Abgp+aLj9OIIIo0j2Pi7ZZX1VyfYkqCSPh0g0m1P9zylGbn+7e2Ar+xOFIY5KvxkFKoYhHnw5NodoKVG1cZN6/eEqFZyPm0GXrEuElRF5oypt/2R8kztw434bJNK7sGxAR8Y8/1RjI1S9w9bswJsxPYKdvAC66pTE6ekM1olcc8cDHlBnFTp5slmr3cYXmFkdoN2ttpDFA3lHvbjtt4mbAvglRc4wrS1KDNQ5KKwZaJzpdKPkce4f E5Y+5oRq 6xt25VuzcwP817rb9B60aBzvxOkbmR95VTosXkZq+fw04+XYPYRiFBVY83cXliYWU6kvq2DJAKAKZXrbwascoBNR/1a9taAQxOF4TpN2/kGDToJJZQY886Nih3jBCN47NI4ezY2abiMfZ3+C2+9Pa7dvTCVJhTV2Hbg05xP9Q1XYneoumHNcjkdlVblqr9gyhDj4Gi6B+8EESRuDaI7hNtzdXnpT78+3IIvDmJ6PePiJjVBXvbr8l/NtGkGdt5jetchEKll6euJAoBYGxfArrGAJ57q2nvhe8WqBzpDCWkWw7pii+MmLs1ItSdPUGCZQzE4xT+sYTpjBMRyqlxuKsVJg9rNupkb6bQWca46q6fKrxufIw+PX3bueKecNDRAacEnZgrQt6vhHwHsg3z8bwuuClepTAhdwDPm74hJBAKY+ydiNyZznfBJ+iX2f6IRKS71JnCkYNWjxnOuhZ1d57flSkNI5guoitIl8RQ9QlmCwNUZJopJhIQUy3FmWGMxcP0EKnHH0P/H8JVeQY0IQgztIl7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Fri, Jul 21, 2023 at 09:17:57PM +0800, Baoquan He wrote: > There's a left issue in my mailbox about percpu code at below. When > I rechecked it and considered Dennis's comment, I made an attmept > to fix it with patch 3. > > https://lore.kernel.org/all/Y407wDMKq5ibE9sc@fedora/T/#u > > Patch 1 and 2 are trivial clean up patches when reading percpu code. > > Baoquan He (3): > mm/percpu.c: remove redundant check > mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little > bit > mm/percpu.c: print error message too if atomic alloc failed > > mm/percpu.c | 39 +++++++++++++++++---------------------- > 1 file changed, 17 insertions(+), 22 deletions(-) > > -- > 2.34.1 > Thanks for these. I left a few comments. I think I might have some stuff for v6.6, I'll figure that out in a couple days. If that's so, I can pull 1, probably massage 2 and send that out again, and then I think you'll need to resend 3. Thanks, Dennis