linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Dennis Zhou <dennis@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, tj@kernel.org, cl@linux.com,
	mawupeng1@huawei.com
Subject: Re: [PATCH 0/3] percpu: some trivial cleanup patches
Date: Sat, 22 Jul 2023 11:30:14 +0800	[thread overview]
Message-ID: <ZLtNRsDuN4xEMSMB@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZLry5gupx9mp1659@snowbird>

On 07/21/23 at 02:04pm, Dennis Zhou wrote:
> Hello,
> 
> On Fri, Jul 21, 2023 at 09:17:57PM +0800, Baoquan He wrote:
> > There's a left issue in my mailbox about percpu code at below. When
> > I rechecked it and considered Dennis's comment, I made an attmept
> > to fix it with patch 3.
> > 
> > https://lore.kernel.org/all/Y407wDMKq5ibE9sc@fedora/T/#u
> > 
> > Patch 1 and 2 are trivial clean up patches when reading percpu code.
> > 
> > Baoquan He (3):
> >   mm/percpu.c: remove redundant check
> >   mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little
> >     bit
> >   mm/percpu.c: print error message too if atomic alloc failed
> > 
> >  mm/percpu.c | 39 +++++++++++++++++----------------------
> >  1 file changed, 17 insertions(+), 22 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> 
> Thanks for these. I left a few comments. I think I might have some stuff
> for v6.6, I'll figure that out in a couple days. If that's so, I can
> pull 1, probably massage 2 and send that out again, and then I think
> you'll need to resend 3.

Sure, thanks for careful reviewing and great suggestion. So I only need
to send v2 of patch 3, right? Or I should change and send v2 of the
whold series? I may not get it clear.



  reply	other threads:[~2023-07-22  3:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 13:17 [PATCH 0/3] percpu: some trivial cleanup patches Baoquan He
2023-07-21 13:17 ` [PATCH 1/3] mm/percpu.c: remove redundant check Baoquan He
2023-07-21 20:55   ` Dennis Zhou
2023-07-21 13:17 ` [PATCH 2/3] mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little bit Baoquan He
2023-07-21 21:01   ` Dennis Zhou
2023-07-22  1:14     ` Baoquan He
2023-07-21 13:18 ` [PATCH 3/3] mm/percpu.c: print error message too if atomic alloc failed Baoquan He
2023-07-21 21:03   ` Dennis Zhou
2023-07-22  1:56     ` Baoquan He
2023-07-21 21:04 ` [PATCH 0/3] percpu: some trivial cleanup patches Dennis Zhou
2023-07-22  3:30   ` Baoquan He [this message]
2023-07-27 22:50     ` Dennis Zhou
2023-07-28  3:04       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLtNRsDuN4xEMSMB@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=dennis@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawupeng1@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).