From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C88EB64DA for ; Sat, 22 Jul 2023 03:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B1556B0071; Fri, 21 Jul 2023 23:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 161BE6B0072; Fri, 21 Jul 2023 23:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 028D28D0001; Fri, 21 Jul 2023 23:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E7D406B0071 for ; Fri, 21 Jul 2023 23:30:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A7FBF1A04B7 for ; Sat, 22 Jul 2023 03:30:27 +0000 (UTC) X-FDA: 81037820094.21.53B1FC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id C10154000B for ; Sat, 22 Jul 2023 03:30:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NiXCsrR5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689996626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UQcUTucxYD9NggKH30+z4KZSkDmNi4HWKkE2UQtXruw=; b=OcqBH7wbvGHXYT8e5eoybC53XE5JioLwMQQRWJKPWOPLg9qJ3PZOKjRVcSgjusytypSZ3C YpB+tHUGSSvcZ85TJpGP/zojdqmMEB9E44cozY7RB2ih3U6zx9CZnEGgrRbydjEXoKLG1U RY5WyGtz9NMhJ97oRGKaVA4Pxx1BC9Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NiXCsrR5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689996626; a=rsa-sha256; cv=none; b=35+8Igu5V8VFT+dsCDfmi3gHl46qGkCoOwydsiHcA4mrFh6cJRdCUoRwxe5LiZzpdeL+ud ljwvbNeJv1LVkG7VAd6/qhfzo8p3JFC6mmfSRcGhnHBdIIps9GzIcdF5Wwwj1whnLh3KlI PIBgNrsDaB90uNF1wy0QH1rNS+ekY5o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689996625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UQcUTucxYD9NggKH30+z4KZSkDmNi4HWKkE2UQtXruw=; b=NiXCsrR5XNf55Pj8KgZQagW1rAyjc5js7C1ylx6jzfIFZ32tsUVeNd4HFCnpefOoPvymvm yIRpAm379LlQNwiWeAPsoKbyRopH2u5K9087nBym1Ekti0AtuHqcVn/YxIavOcDZC6ULHF XbW1nu9AIzfDQFYfd1+6lq/m+lSiGAg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-690-vxQnj3-7PrSxChngzlucYw-1; Fri, 21 Jul 2023 23:30:19 -0400 X-MC-Unique: vxQnj3-7PrSxChngzlucYw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9AF0B185A795; Sat, 22 Jul 2023 03:30:18 +0000 (UTC) Received: from localhost (ovpn-12-31.pek2.redhat.com [10.72.12.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCD09200A7CA; Sat, 22 Jul 2023 03:30:17 +0000 (UTC) Date: Sat, 22 Jul 2023 11:30:14 +0800 From: Baoquan He To: Dennis Zhou Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 0/3] percpu: some trivial cleanup patches Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: C10154000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: rdzrn6g7kgbi5njca9hopxsytiqcenuh X-HE-Tag: 1689996625-958848 X-HE-Meta: U2FsdGVkX1+rJjDfXhu6sSsgIxVRLVjL5XDJj897NtaLk9HUoOChAd4Iw5/XA48+xJtQTAdhrbaj68nrqait0M51BMSIUGinEYFMPc8tuPuVK16zJQ5t35VGvHVNXdRcxu7vMFUHahGW41fM1GKLsn176JK4X8EtUSMSqBWNsVwwoBwuc6Z+a/atup/eWrGaUwTCQ3CIg2lA6FdNXOklm7YMStnMnfYdmheTuZ+S43/EXB/G4xnEHOzoGlSsilRukpES0WC03lQOQiQ22HKnnCWmy1zN6ObVsqKYDFj9cMh+ZXAX8H4v69N6iJP9bp709l0KKR/EYYUzy62RZOEvY01MRvBVmrJXZd2ueKhkXE4g/KThd/g6FNVh8OEblp781cjs1iS8IsRQziIhAuiFN1Y0pX/kLOfsYAcZEUPfWQ12XDRuD/yCZGF9kxtW9blc7SpjJ1C00E9pY7UmjmOEuQPUgGiG+04GT+FzwqyOI5PcO/4HKV35wrh65EvuDVFOrYARBWMuTQdxPdnxJ0vgsVzdM1VX7yqlaPfDTUkVPLcHHru8eQfo/f7swyKMCESt4UNLVJCsLfxw6ylGObjk8E/ACPbmgOqYJNRwongysmgtjVu+Lo7G4csZqCoCPF2kirZ7ny1/MzPj4ZScB2YdLn1IHz6AEavzsyodXG6777cqJy04SsO1aGtNS+a/4ge65nEZyulMVSRhAGamLXvSpj9UQOS20lTezN8qRCZpA5XshLwj0Ewt69OLaq0TYIEPj6KmoJ61pGK6XhLVKhwobHb+eV4QZDBdI7GIgor+bQWwK9fgffWdaJkfsL9vE3Mr3Cu0VsBXR0vIgjE0EYHm0WZpNzHGc9SOj8OoChWJSTVu4FMSiekdEnf4gtm9UP/OboZwo2quqKop09cFdWavX90wVlezVpx7EnQ1lS1QFqaG4nscBSdMHsbg6EXEeh1qncv4VXm82mnDOD3sxek Nree7g7E zTcig8SJBursUAKVFwVNXWG9TmtLgR60Le+Xll7KUmmcJIVw3D6gYg8R6OKTDjHol4DmG4LF4tK41blL2SQy+Y5Oy2H26NV7o3HrvPrNWghZggWDcOKU2dIZqiZ/+cwROMgq9j1lUniVj2N1ssZ3H7i55Btfdtt/N1lZiC62pza/7qwyun2UWLmCGIZ4Ws0oHyNzlNS46wfwHZQEZAq1iDS3LgB9l4Ym7Y57awi828B6suvn9YAgorX/RolCA2Oi+XWc/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/21/23 at 02:04pm, Dennis Zhou wrote: > Hello, > > On Fri, Jul 21, 2023 at 09:17:57PM +0800, Baoquan He wrote: > > There's a left issue in my mailbox about percpu code at below. When > > I rechecked it and considered Dennis's comment, I made an attmept > > to fix it with patch 3. > > > > https://lore.kernel.org/all/Y407wDMKq5ibE9sc@fedora/T/#u > > > > Patch 1 and 2 are trivial clean up patches when reading percpu code. > > > > Baoquan He (3): > > mm/percpu.c: remove redundant check > > mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little > > bit > > mm/percpu.c: print error message too if atomic alloc failed > > > > mm/percpu.c | 39 +++++++++++++++++---------------------- > > 1 file changed, 17 insertions(+), 22 deletions(-) > > > > -- > > 2.34.1 > > > > Thanks for these. I left a few comments. I think I might have some stuff > for v6.6, I'll figure that out in a couple days. If that's so, I can > pull 1, probably massage 2 and send that out again, and then I think > you'll need to resend 3. Sure, thanks for careful reviewing and great suggestion. So I only need to send v2 of patch 3, right? Or I should change and send v2 of the whold series? I may not get it clear.