From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
linux-mm@kvack.org, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends
Date: Fri, 4 Aug 2023 23:34:03 +0300 [thread overview]
Message-ID: <ZM1gu3+x9uLnDwVB@smile.fi.intel.com> (raw)
In-Reply-To: <71ce8516-21cb-32c6-84d3-b3f9bb3d625b@rasmusvillemoes.dk>
On Fri, Aug 04, 2023 at 11:31:58AM +0200, Rasmus Villemoes wrote:
> On 04/08/2023 10.26, Andy Shevchenko wrote:
...
> > +#include <linux/types.h>
>
> Shouldn't this at least also include compiler_attributes.h, to make it
> self-contained?
As I replied in the other email, this is guaranteed by types.h.
But if you insist, I can add it.
> As Marco said, please just declare no_hash_pointers in this file as
> well. Perhaps with a comment about not accessing it unless one has good
> reason, but I suppose that's true in general for all kernel global
> variables, so maybe not worth it for this one.
Sure, thank you for the review!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-04 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:26 [PATCH v1 0/4] lib/vsprintf: Rework header inclusions Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header Andy Shevchenko
2023-08-04 8:38 ` Marco Elver
2023-08-04 16:55 ` Steven Rostedt
2023-08-04 16:54 ` Steven Rostedt
2023-08-04 8:26 ` [PATCH v1 2/4] lib/vsprintf: Sort headers alphabetically Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 3/4] lib/vsprintf: Remove implied inclusions Andy Shevchenko
2023-08-04 9:36 ` Rasmus Villemoes
2023-08-04 20:31 ` Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends Andy Shevchenko
2023-08-04 9:31 ` Rasmus Villemoes
2023-08-04 20:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZM1gu3+x9uLnDwVB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox