From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35FDC0015E for ; Wed, 26 Jul 2023 14:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 781336B0071; Wed, 26 Jul 2023 10:25:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 731986B0072; Wed, 26 Jul 2023 10:25:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D3946B0074; Wed, 26 Jul 2023 10:25:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CDC76B0071 for ; Wed, 26 Jul 2023 10:25:04 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 266D8B243F for ; Wed, 26 Jul 2023 14:25:04 +0000 (UTC) X-FDA: 81053984928.23.40A4B23 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf16.hostedemail.com (Postfix) with ESMTP id 5CE37180005 for ; Wed, 26 Jul 2023 14:25:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KwMaCkiB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3vSzBZAYKCEg2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3vSzBZAYKCEg2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690381502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mt8/YY3u8LjsBjr8d6/ke2ZW25YHueLUKLJjDJYMc8s=; b=MN2Ha2hbloXLtj/qsGWYsLUpAeEFm6w+f3bKy43omObD7/QBO65WZK3sI0AbGaa8R0Y3Sd mfl470jpeUg4xkHexAqbrEkCkJgL55ha93ZVSmN8+9mRhe+wjSbJIp3YrzlzJTUXhq/q4R I3lfSyfCFXp0ecLWE0CzYxZLxFIZoAw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=KwMaCkiB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of 3vSzBZAYKCEg2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3vSzBZAYKCEg2okxtmqyyqvo.mywvsx47-wwu5kmu.y1q@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690381502; a=rsa-sha256; cv=none; b=Nvw/BIA3oiPOGKFBB6HyMCemXdjGrH/zRZkgBZpe1oPj//lRRups6tCv5aFnfxPZjXnkLh 0DdZ+EYnYmbglCJrmGcC2ZjwODEtci26x4H8M3yHcMstvymnPaG0AnZOiTMUrcszEylhSN qDXWzeaIWkUYNg2qYURbfhCaxCPWew0= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-583d1d0de65so50523957b3.0 for ; Wed, 26 Jul 2023 07:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690381501; x=1690986301; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mt8/YY3u8LjsBjr8d6/ke2ZW25YHueLUKLJjDJYMc8s=; b=KwMaCkiB4xAqGBUh9OF2kV0ZTXZJ9t/BQNvELYTboh2nFXRCb/O6mzI5Rf4+JkOSUf GbfKDvzjuzeoTYk+8UzFDnEFGCf4Xp/4j132VlBFiOap0dqwF0d+IWavL7GkLuWIPxaf FtFh1NcigPTHGOQymzspNYZcGJWMeYjGrAKFBYQg3vkICZKAIWBqnifvNeqq77Udkh7Z xGehHXpHV6lJVR2/PB6tUzMEDhiwA5lq38Ga3ndr8/43j3+UY7kRIeUxbAwefFFreB6b OU07H0FnfDMXq+of8q/ygEkV9SZmVl7edMM6TzYoGxGd/1xqW6Xr5wUrtaTzZVCwe9dk Dlpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690381501; x=1690986301; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mt8/YY3u8LjsBjr8d6/ke2ZW25YHueLUKLJjDJYMc8s=; b=RnXRoNPXK5wA2LTOWvX+rJbjk43D2F+qMm92GwMGdwP3c08BUC1BKH63QEw0XEOYNy I/35P8COStDGiNGCY8RzU1ZuoBTNgCcVKQeqc8wijjzYyjDjfzXManXRdOw8lc9CMD3j L123bvMXosZ1RGl9y3SqjwxfnfaF94cKMbjiu6BDTsLt2LbeUFJCARixs8eI5yd9adUo S2+KmuVqcGjsy64AYFdJYZHdw5V/ZbIIpjWSXflr1lAR41Wd6VTIJOjE+zfSDU4EFyz9 tXWdYBsoXjP5Taz1iQlF+wwbEl+msYr15oQzelioBMJPZTU79IdsrOrQ9t+2SQG2xNYy DDHQ== X-Gm-Message-State: ABy/qLbKGi9IkXFTRO6N0eHwAGpEkDdx7MOTzVirxLGbiSkek+GysqbY PpXSZlvzqZf4VjjjD7UquZmAc9lIpf0= X-Google-Smtp-Source: APBJJlHpunM1lrfEfJpa6UtG2AaqQE17ubaKuYzputooU8ueGDVFO/y80053uMgFIUrJA+dTGv8yhoGEgv0= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ac60:0:b0:576:de5f:95e1 with SMTP id z32-20020a81ac60000000b00576de5f95e1mr20181ywj.1.1690381501073; Wed, 26 Jul 2023 07:25:01 -0700 (PDT) Date: Wed, 26 Jul 2023 07:24:59 -0700 In-Reply-To: <2f98a32c-bd3d-4890-b757-4d2f67a3b1a7@amd.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <110f1aa0-7fcd-1287-701a-89c2203f0ac2@amd.com> <2f98a32c-bd3d-4890-b757-4d2f67a3b1a7@amd.com> Message-ID: Subject: Re: [RFC PATCH v11 00/29] KVM: guest_memfd() and per-page attributes From: Sean Christopherson To: "Nikunj A. Dadhania" Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5CE37180005 X-Stat-Signature: q9xneaye6y6mnuaftu3h9hneiktti534 X-Rspam-User: X-HE-Tag: 1690381502-561150 X-HE-Meta: U2FsdGVkX18r4XYE54E1Kaxt4NwbK0djONEpgSxew22RzvtGQZJZpXCeNQZLYpl9DIrcQ4Y+I9bjfmEQ9Adsa17cbunYjeGkOOW7Vo5QUa610uXnW2fkteQf3rN9AdY4Yp9HsImvMh0SpuWXHgN8F/bBs8tRdtMI2MDMh7npwoJA00dixKi/TNaOM7gMnkFqMwYFD+FLRvRy7vupJNiZPBRBLgWT+/lfo2U3c3y1btfa6dCp6OZt6ZEcrrJnnY6vvyApBefeTM0SFT2pPSKqpzW+ZhCv/z5++n/MIH5h0wJKM2qdTvz7res7OwwTAXcOk+e/nv6hpm6xg2d497Itj+j6uLfBhlnrXY0a9CMX7Vc5QeABYsbEu+j3T8xOy5kDufftCRFuikBE44JAQGVOv8kIauGXZw0wF+U9puDErHnLblX0wKCPbl0Z+hOrtLolRB4VR9cqzCXXgr/GmN6Ok8iXWz6FTH2lFzRzxOQuVH8VArm4/LFNMb+3QF8oDZgylxtYbZMJ9Pu5bIBoZbjlRM8eOSBY2IuRjrHV23Y03Kr4gOKOXV52WJXfjGzskGLluQgu3CI4MCHxTP2iHejsyiR4Gzn/kaz/CGIu/Za9n6B7uLqWI+/SXLWqy+b5llAcnOxFj6hC4FTIPOSGSWh8nhUFYPQYAKjilEws11cfKNmPxAhqqbnOeJl5SS+geCUbFfgtL3JpQALYcVvf+15+wc2cU1xre2+RjfTNekwXgdOwFt0t/E/ilVpH+nVgZIpRkAtb82TduD5B4AbNT79AAb3l/LLQOPLG5FLyK2qzAbKvpsSCJGBxfWxOBfEHo5bhf9M6rbBnVLGm0KgQTiKTe+mHPTo11LndA09KsiRF2VbToqrjHpdDvv+BRciNfHofIwXQi75LjAqllviB05DCUhxJ0fh6hyjSCaQTkQhlfmLdpHwXtwwzoyNlG0RY1X7JOhit10xNpagAd/SEY2u 5rCHtV5O XcGNoqZuoM+/oFVt7ISs0obGYPBBoubdTGa1SoGdaXeoasf3UvaIC/BI0XwXLzCWrd8K6mRqwAeSl/hNjxuHnAIeCD8FV3vNilLGQ9i4IMUiF/FzwPuOWRCKwkpqXzOUkeai4VIMC9SPeQGz7WxpbISyauESYnQIdcrq/Mk7CAP7BBXLID1MgR3VZQqe2gnK/9NWiyXC2J/XyGbuNRlpsq9mWYHfoQHr4129kH7/r4REjVv4Eu3POcZJiDrbxsewpdAnxh7bOtmtFlkem5BmPFVanglprmKWMnRCQmNkO8nJVDuTwFbjX/sht39QJfQu+hMNRUYf8JeiF6ALyGONB2lR31AdUt2RzBwT3/WcNGd6L/GvmOibuKXx6L0gHPcgfB7bVi3+Ws4XfBxEVmyavmv2t1fCxrcOWJVYvl9cKqxdncA3OJv9Gr7qY/jJkLQN2itxrECVXpwkbkLH1ZRvIYFONfPVt6++Nr1GGxCfl1x1nztl/IFL3/D/yqQiaJ/yjWYg8clWloJpPUokBfZYXlTdJwCgBLFcGLRLCN4zqE1LDu6tmN62+tbug6UcLCE9m2g64U7njbOVV0U0wVkkDX3kQFan94lQvy88WzAIVesQEkC3dovHg8yZ8pd5ONUruzB/rtKPQAQCVZSemUDJShR8qfdRY+p2ZXWyEOYkBcrr8Qh4aD9xXQkrMmqUf+7wxHo3A7fgJckw5I8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 26, 2023, Nikunj A. Dadhania wrote: > Hi Sean, > > On 7/24/2023 10:30 PM, Sean Christopherson wrote: > >> Starting an SNP guest with 40G memory with memory interleave between > >> Node2 and Node3 > >> > >> $ numactl -i 2,3 ./bootg_snp.sh > >> > >> PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND > >> 242179 root 20 0 40.4g 99580 51676 S 78.0 0.0 0:56.58 qemu-system-x86 > >> > >> -> Incorrect process resident memory and shared memory is reported > > > > I don't know that I would call these "incorrect". Shared memory definitely is > > correct, because by definition guest_memfd isn't shared. RSS is less clear cut; > > gmem memory is resident in RAM, but if we show gmem in RSS then we'll end up with > > scenarios where RSS > VIRT, which will be quite confusing for unaware users (I'm > > assuming the 40g of VIRT here comes from QEMU mapping the shared half of gmem > > memslots). > > I am not sure why will RSS exceed the VIRT, it should be at max 40G (assuming all the > memory is private) And also assuming that (a) userspace mmap()'d the shared side of things 1:1 with private memory and (b) that the shared mappings have not been populated. Those assumptions will mostly probably hold true for QEMU, but kernel correctness shouldn't depend on assumptions about one specific userspace application. > >> /proc//smaps > >> 7f528be00000-7f5c8be00000 rw-p 00000000 00:01 26629 /memfd:memory-backend-memfd-shared (deleted) > >> 7f5c90200000-7f5c90220000 rw-s 00000000 00:01 44033 /memfd:rom-backend-memfd-shared (deleted) > >> 7f5c90400000-7f5c90420000 rw-s 00000000 00:01 44032 /memfd:rom-backend-memfd-shared (deleted) > >> 7f5c90800000-7f5c90b7c000 rw-s 00000000 00:01 1025 /memfd:rom-backend-memfd-shared (deleted) > > > > This is all expected, and IMO correct. There are no userspace mappings, and so > > not accounting anything is working as intended. > Doesn't sound that correct, if 10 SNP guests are running each using 10GB, how > would we know who is using 100GB of memory? It's correct with respect to what the interfaces show, which is how much memory is *mapped* into userspace. As I said (or at least tried to say) in my first reply, I am not against exposing memory usage to userspace via stats, only that it's not obvious to me that the existing VMA-based stats are the most appropriate way to surface this information.