From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA05EB64DD for ; Thu, 27 Jul 2023 22:50:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1E8D6B0072; Thu, 27 Jul 2023 18:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCECA6B0074; Thu, 27 Jul 2023 18:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96E96B0075; Thu, 27 Jul 2023 18:50:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9AC266B0072 for ; Thu, 27 Jul 2023 18:50:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 635A58055C for ; Thu, 27 Jul 2023 22:50:26 +0000 (UTC) X-FDA: 81058887252.01.B22A719 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 9E3B620006 for ; Thu, 27 Jul 2023 22:50:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690498224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Ck3lyZGLf+F2YFdZHPFliqXqnqZBVSPAOZfVe+yCL0=; b=WHd5fHBWml9yRDmzhKxZoP7V6qEEY8XuF3UJJ9DH0BTl9DKZrKOC2puTIpS9P0uzzBHEe+ pojXesUL3cZgEa9jv6sLh5PLsBFmgF0mByWRElCLspnJVV+0cfUuGg6vaOF349MB2VuVA3 Q+0N83OZDce3ef260BsCOxW17xyoWJ4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690498224; a=rsa-sha256; cv=none; b=xG8ByNhieFmnjl7W0NKiuRIG/IcttvmcaI4hB87nTOf8K83EJVijM0qnbYJFxfocOdC4lC YoXDEOMcPrc6cJlsvTQRHWYdnsdh8sXBEvqo6M3t9XSn2I3062PnKxjzVt0H1UIou99xQ3 aLZp/yaXMIAmXK3bOJQVbNekboOjFTo= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1bba2318546so12222485ad.1 for ; Thu, 27 Jul 2023 15:50:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690498223; x=1691103023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Ck3lyZGLf+F2YFdZHPFliqXqnqZBVSPAOZfVe+yCL0=; b=fKjHh65PFw+MXTt9AuEann3I+mpQYOXpKCB+a3gbW1bdaIW/skJfHv64xgxNyf60i8 R7PelFSef6TcjVdBkFHmai3U+DvjIqAwK+E35CFcKR7kb8dMcQzJzDtukukkj5dLePPZ +y4m2Fd7uU2MtE0PbBnDy5xxn/mCmUFobSba30s6BqANOjdhQQfa5Fy4KmDkPJ2IGzBe OkUGYPPjbcTDx1LRo8eD1tkaDWyaXCoR3pKXi+X7BXh5hBJmALgUhozz5R4C+vH3slYb TWzx3/fr/EeB30DQxfhI4NGi6P6RKx12T/YgDx9uGIrY67dy5Q8O7L775T9aoDjAVfOP 0wEQ== X-Gm-Message-State: ABy/qLZUQPIpa/RKuX/8nXQCXQiSd4jmEvoO6g0h3i1byQYnl2qLhLr1 jIJlppFX3Gl5lJ0dMY+dmPo= X-Google-Smtp-Source: APBJJlEIPFubxJ7JROG/8yCHhxVJJ/qEZLipx8hx9MDkty48geWZ98Wod7ei126CzzI9nVgluQMsJg== X-Received: by 2002:a17:902:d3c6:b0:1bb:c69b:6f6b with SMTP id w6-20020a170902d3c600b001bbc69b6f6bmr634913plb.6.1690498223158; Thu, 27 Jul 2023 15:50:23 -0700 (PDT) Received: from snowbird ([199.73.127.3]) by smtp.gmail.com with ESMTPSA id a7-20020a170902ecc700b001bb20380bf2sm2160120plh.13.2023.07.27.15.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 15:50:22 -0700 (PDT) Date: Thu, 27 Jul 2023 15:50:19 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, tj@kernel.org, cl@linux.com, mawupeng1@huawei.com Subject: Re: [PATCH 0/3] percpu: some trivial cleanup patches Message-ID: References: <20230721131800.20003-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9E3B620006 X-Stat-Signature: ssxn7uwxxbysfcszahtzj3cjrpy8xzh6 X-HE-Tag: 1690498224-557078 X-HE-Meta: U2FsdGVkX1+26CfDPNY5a2TWx7cc1kd2YwNr/Y8E70k3ZyOueX7fqi+UuM5xw+h79feeuCsasphUxyB2ULx1wAGdbrtU56/XL9IkiIkVmycYU/ajjMCmk7LNabTLAQ43ytydT2K/kNYUIsA/8zmBINAZJxhHJPKEE90p7bY7iIoyk5DLjWxR/aXLsN5RkG6Kz5CS+4XbqjqhGJUginrCe8axHgLcMmfOAxh+7UrrMkcim304FLhta7vEjg+Utj7jXpwlJEsxxdsWOFcblhwgfta4qPlbLJdJmfZaH9bEo8L8ziNvQgqx5Z7OkGeKmO5JWCT5zEB5bQRtp9J4YNS7eRX1gBtEHafh3nM0m+vpqv9aaRhVpD7fMjsw4TlDJKNm80fN45KJuC9TGd/Qum8a5o2fC1LsW7bO1Gebgxm36ujr8TH5K4RZPd0Is4nh67RgkZDRfZ8SW40HBJHmZyr/wAW0BacsIdplfNKPYZfhzO80xr4oWkqLfUfhs7J5mjHIxW9ooRFIl3AX9zL1IZqBGX8mmxkPDzxFeYxe+/o2IzLhGqES8aNHSN86mPGeAhNXHqlq6NHjXGCLpM1uix7jQAPCviimO/NkmFUABtFZphR64rG2XUfYLidxxcmrOx2/9co1b7JiVBsU9nyyBNFopw0i08LSYRiidk2pdZs60K/cf4fVwMJqdYkQfaGw2R/CMhXB8/odZHzp9ABALXAmFYoBOvrgTuQxV2pTQogKPeGbzEunT8iw4Ha6xiqhueWGhD+6EF98RgWL+PM+e8iz3cmBl5Z6VhCxTei2M7xUVIPeu7wj3dxvJvJ9JgyzyU8y8UmIe5VhFz4A0d/3fAbuCibj33Aj6RiYdRF4HuIGjexXghew8nMq0P+fOh0S7Qair6/q33yJ6qT+V4dv6WLDU8RDWipQ0fI9FGCazXSvt1g+SBmKbK92bXarJY2ISGQdEkPuv1sdkluDfbS9wfE NhQVVSv7 fO7JCbFU1695xcZYPbzT3EX81ykG0qIfe/1SZshLfbGwjW8hhMhzDqaI+IFGDl8ND2fNVpNxEgjXpXQPgZ+7l/E8Muidhd4oIL9eAqt76FhR4RnLMhDJbWf3kbXd0fzUcXa/y8T/mmVLW4z4zO2QfDGjwrPnUSap0AOaTe96rVXZBLyjap5YBcQyko4p4hTWT3IEufJXLDG5tZAK/SFQSWg5PEud70MsmRC9Wwx7sEWEH3dWMuxDI2tl6vOG01VytDkA496g7qzStqiPBQL/iBm1QpbDSYQ84A+SzJ/3hWtP/zVh5ET8Iq/p4eDq3n9UbdvwVJ0HuAXi4VQqCJuTfiy8ocOPxCUfs6oJTclK3pWm7FWB4zUVy9Yi+E5zTEMBTQ2noZt0w+Wl2HAVDZMm9CcvwrL3p0adDcCBtvcbqdTePjphf93YGL3JjuoFlEzCfmNvNrTEWHgq+2rcpCoJa1hezSrMnj/r8pZ8nvlek7/j/ODMky8R6SJMcIMmuxqK0+6J0xcz0f2hJq57vZwxERGEKdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Sat, Jul 22, 2023 at 11:30:14AM +0800, Baoquan He wrote: > On 07/21/23 at 02:04pm, Dennis Zhou wrote: > > Hello, > > > > On Fri, Jul 21, 2023 at 09:17:57PM +0800, Baoquan He wrote: > > > There's a left issue in my mailbox about percpu code at below. When > > > I rechecked it and considered Dennis's comment, I made an attmept > > > to fix it with patch 3. > > > > > > https://lore.kernel.org/all/Y407wDMKq5ibE9sc@fedora/T/#u > > > > > > Patch 1 and 2 are trivial clean up patches when reading percpu code. > > > > > > Baoquan He (3): > > > mm/percpu.c: remove redundant check > > > mm/percpu.c: optimize the code in pcpu_setup_first_chunk() a little > > > bit > > > mm/percpu.c: print error message too if atomic alloc failed > > > > > > mm/percpu.c | 39 +++++++++++++++++---------------------- > > > 1 file changed, 17 insertions(+), 22 deletions(-) > > > > > > -- > > > 2.34.1 > > > > > > > Thanks for these. I left a few comments. I think I might have some stuff > > for v6.6, I'll figure that out in a couple days. If that's so, I can > > pull 1, probably massage 2 and send that out again, and then I think > > you'll need to resend 3. > > Sure, thanks for careful reviewing and great suggestion. So I only need > to send v2 of patch 3, right? Or I should change and send v2 of the > whold series? I may not get it clear. > Sorry for the delay. I've pulled 1 and 2 (reworded the comment). Can you please resend patch 3. Thanks, Dennis