From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641EFC001DE for ; Fri, 28 Jul 2023 14:07:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9442A8D0003; Fri, 28 Jul 2023 10:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4D28D0001; Fri, 28 Jul 2023 10:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BD888D0003; Fri, 28 Jul 2023 10:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E1C38D0001 for ; Fri, 28 Jul 2023 10:07:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F42141A11BF for ; Fri, 28 Jul 2023 14:07:50 +0000 (UTC) X-FDA: 81061199100.10.ED9AFC7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id B708D180070 for ; Fri, 28 Jul 2023 14:06:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="RV1/HdoO"; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690553191; a=rsa-sha256; cv=none; b=1lTz4GjvBDyb6bOejdjWoKbz/G/ugUsflUFQWOdo7h8WfzD66MhSfSPj3RGK1o91SHmpFX Ol6r7Gwr//jKdNRyZWRNKuH8jY9yd9/lXcUkIGNK6lV5zDp7kLXl1tCbUt6QXq1AOh/HV/ ggA2lAE46DLoa1n/ZIBXtF1iBEABSTo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="RV1/HdoO"; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690553191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zfhLlZEY9jrlQ/2kEYtQ+IcpResvxW4Nqgr5z97KTN4=; b=11KL5b1slnR42HCdiF7slseT6De6sGesZtZgdavL1LpHX1yTtmOqJ430OFaGde3EJRBrCr SO+N+rTxvmdZp5ZjxA2d3M1KC0Ykmqz6DwR670MkPkpae0CMvLVPhE5yKeMvYWCicHMiOy GpWLdXtf6LUpa709NfR/9Ho6DTXsSIo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zfhLlZEY9jrlQ/2kEYtQ+IcpResvxW4Nqgr5z97KTN4=; b=RV1/HdoOOaLQNqjA6/byw1rzTB YtfU6b1OVsO3YHk/qeJ85dCatzu6sFtmWuQNyc+l9tjmmqzcUfeIo60z5go1TammYWptXZwqwb+E5 Hws7Kw/6mANlTUxkWpI6OR0YjVBAdGNnG3epD1niymrzrD9dWSJhv9+GQGGW7uOeN3+jifKy7GUnj Fh/2YF7kE0xcDFgdrsejedNpdINcW3mqKr2e9qaVDOxsXMCKNM5X17VjlU8YOtE/Fu9ph5KGB6SBW 5h7RfSYucQAjZx2BERsNQmnVNEWLGQNroJT3NyzbkyJdwDRXAwadtTZiRj809vVF6lVZdDtiUB5wf JCfK7hzQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qPO5e-008YJz-Fg; Fri, 28 Jul 2023 14:05:10 +0000 Date: Fri, 28 Jul 2023 15:05:10 +0100 From: Matthew Wilcox To: Yongqin Liu Cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 04/32] mm/pgtable: allow pte_offset_map[_lock]() to fail Message-ID: References: <2929bfd-9893-a374-e463-4c3127ff9b9d@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B708D180070 X-Stat-Signature: arsah4fyfkd6dcq4t6xhor47neicieu5 X-Rspam-User: X-HE-Tag: 1690553190-43614 X-HE-Meta: U2FsdGVkX19DyKMjSzZwdZZaoqVwgX5wKU8rilERoswvJAsHC6lirV6kx1d7mbKfSbwAZCCsjFX3KvGBKinYYPXPrYKkMmY3mMRbl4uQv5nPMnXlsxek87uZ3j2SKDCVWLF787W2Za1XO5pJRGckU28OlINZlZ9qqqrcxiZ0U3uvl5QtUvfqswSjjN9MSTdvbZmY2ZLQZg5mlTR3jP7t6+w60qbtZ44hpWgLP8dWs71w7edsVEQnTPpwVWbtg5y2FDZF/yHDyIfxrfNCbNn3QP/TECO4MIYXpp4GOajETsLEuy6wBSUUxPzMuKn0mTmnKYcqKBCRSAX8oeoMWMslifNUvrywji+vnOTUprm28sEvnrjFsbVHHV2N7uEZswBBgLv8U9SMzCOdm0EU3BSm8tRjvEKLJ+iSaW+ahlMpcrXSPhI+31i5MvCsFuUG7Zh0npCOuxCplrguzpdMTKMdefueP1jVyCjNndK1gaW0Lndl7ProIsaXqkl5TUP7Td+hlSGxhmkPhg0fLv1Wk6zBo/Kc8bw1wHZLc4bvh+/WGGno9ZE4PIc+40bdhqiP4/Td0blwvnXaf428GPmSWqAlQm5NM0YKFfvf2rOjMJKISdiOiek+M9V/B51pRpIEM4ZhnBtQRPfUaxABcAm2DlcpFRuhPsSyUBO2ar8nASUDfmSClPQ7NgDCGG3zvu0OEdRAUb2Em3H67JfEpucSL5T53TpE3fYXD4oF0ySxuPE0FVLI8itAsT9XnGegozumRAPPwTPh9VMz5iAVUVmYALKhmzJJY7kfuHPO1V8LdFgv724bZB32D/TdE1sI3IZ9G6BrF/mOAfW78a7O40U9aQgAO8XDSvOd7n8CI9H0abtZFlCoBYFwBpu0TRRqgvhEE4jI/wsrfHbmn4pfRh6uo6om56IkPQMqJUcYpY8zuKVEKug//Q0zfHJWChszcdi+Klmai1fsUOHZjeoBTM3VSm6 ZCVEz8iF +plNkCc/9JhiKqTnM7+YYTYbNzB1VbBip12ybjbl+Skl1HGPACux0yU9QFL13X9P9zTNBt+qInrBiQMfCv8siE92wRFvmUsV8J+s7H6GIt27IXeNVmzMB1Ex7EZy1FRRWsdxuSky3rj0RzIvJepDxb39L+qrzanmbJgZux9blNN+qnsE03PeW7JVLQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 28, 2023 at 09:53:29PM +0800, Yongqin Liu wrote: > Hi, Hugh > > It seems this change makes pte_offset_map_lock not possible to be > called in out of tree modules, > otherwise it will report error like this: > ERROR: modpost: "__pte_offset_map_lock" > [../omap-modules/android-mainline/pvr/pvrsrvkm.ko] undefined! > > Not sure if you have any idea about it, and any suggestions on how to > resolve it? Please explain why this module needs to map page tables