From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B072C04A6A for ; Sat, 29 Jul 2023 23:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DAFC8D0002; Sat, 29 Jul 2023 19:41:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 064798D0001; Sat, 29 Jul 2023 19:41:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E46BC8D0002; Sat, 29 Jul 2023 19:41:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CEC748D0001 for ; Sat, 29 Jul 2023 19:41:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 84EEBA061B for ; Sat, 29 Jul 2023 23:41:42 +0000 (UTC) X-FDA: 81066274044.30.616ED28 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf14.hostedemail.com (Postfix) with ESMTP id 3B7E4100009 for ; Sat, 29 Jul 2023 23:41:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=l+Nw2eJG; spf=pass (imf14.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690674099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0v0jLwnwzDh79wxSK826et8eo4TKKEDlYscJEeAlfEU=; b=vPfgeiLaMv8hjq/YU9ZLPX32plRvMI+NbmR+oSegUCsPpWE/ff+rf+sQSwIWTo+eRCLIGa BnUFfUQLqhb6jqVnFGR6jNphAOus9me2ebdnw5yZsglBIRi7fhEvh/HLiv3G797oyM0Mvo M8X+s4v52Y+8XuvoJrRZ3P3f1FXzekA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690674099; a=rsa-sha256; cv=none; b=TIFM5eELposqU+Lr6hSaY5uVdngA1c5NXDWPUObOh93yOdu/YcD6i8MC2UYLdFq1DCBsJe 88dykdfQfW2ETJVMLGf+uCOdRG2EcTWSXAnX9o/ms+pPm7+vEErYc1+QGN1WKJqX6B6qFh Ap6P3sDYh27CGxFaLDGtQR//itrEuzw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=l+Nw2eJG; spf=pass (imf14.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-98dfb3f9af6so516559566b.2 for ; Sat, 29 Jul 2023 16:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690674097; x=1691278897; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:from:to:cc:subject:date:message-id:reply-to; bh=0v0jLwnwzDh79wxSK826et8eo4TKKEDlYscJEeAlfEU=; b=l+Nw2eJGJRlse4weN+Zg5DIXZNLaRZs5vFgzEiDdgg1NVBpJBPAP8OzwvRbggZoW9D 6MK/na7e5zNYF59WMdm41sY/wunXt8GSdQzyG//9j/nGqMdIe9f3ieqSRGHjnObEbs3p RvwylckQKxUUNifHqKyQZvNuhVEtoDASqluSKX/cSHmrTTsrrqUSAS+QsBzgne4N29HE ggliqqsd1AaVRC7CNdnz+d3ySVpggDjQR+1n+RuZS7WOQ5UkVLyh8aI3d9NI6ptsFAw3 ysggpwzxvF5BItqzHreMz7JvHvLs2wh3MYR4bGsyVSI0DdLdwZQn2QZ6vIZrMDD83545 0Mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690674097; x=1691278897; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0v0jLwnwzDh79wxSK826et8eo4TKKEDlYscJEeAlfEU=; b=DMmfr7Z50UGExrzIgFmCGlAM1GSKSZis5VJbKROy3fjVjGLewpKAZOARLg+ifP4Q66 xrxyvcTv4iK6Cg4LTnk9R9mLHFe2Yiz7mYAnsz5MgsUhZg8n5/XAKNk3ZI0pNiesoEzd ycvZ9nVvgM9XDPTqfU739MdM53XwCaVA9SlnQ6IicGTVMyg6FgAfiqlaSmjQ7mqFZaHi NsOf+O2WvX2IQGLtZQ8JqC+nuncOX92nukH+VqM6sxv9w2tS+N2vn1Fkh8U7JgTSOsGH I70xn02GaRY6S3KS+l+pN0WvGEzLRoWNRZeICb+ulbfgVafD6DXI9qylYHoLCMPEO0in 4pPg== X-Gm-Message-State: ABy/qLbhr6mPhJjGZrOXdP75tQoX6Q69jhHQPFy/PdSpKMJPpC/CXlII expu4qsNMjwivYAWUJTHEZI= X-Google-Smtp-Source: APBJJlFsRKC2mTKeYT3mQLgnmZXIJXKso0YsRWIcZ7kk/uzkfjwxyoLrgvAG0n8G8PGEavbjC6R0nA== X-Received: by 2002:a17:907:75f0:b0:99b:ca5d:1466 with SMTP id jz16-20020a17090775f000b0099bca5d1466mr3445829ejc.66.1690674097502; Sat, 29 Jul 2023 16:41:37 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id b3-20020a170906490300b0099307a5c564sm3874472ejq.55.2023.07.29.16.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jul 2023 16:41:37 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id BD1B127C0054; Sat, 29 Jul 2023 19:41:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 29 Jul 2023 19:41:33 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieelgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeevgffhueevkedutefgveduuedujeefledthffgheegkeekiefgudekhffg geelfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdei gedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfih igmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Jul 2023 19:41:31 -0400 (EDT) Date: Sat, 29 Jul 2023 16:40:53 -0700 From: Boqun Feng To: Miguel Ojeda Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , Andreas Hindborg , stable@vger.kernel.org Subject: Re: [PATCH] rust: allocator: Prevents mis-aligned allocation Message-ID: References: <20230613164258.3831917-1-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 3B7E4100009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 76ux16x1a4scz9nubyzy1kmw1ig4eb6i X-HE-Tag: 1690674098-715039 X-HE-Meta: U2FsdGVkX18CzRhLDuwDLh+4f8eYbe1ciTglFtkPcOkGfyIdyxPuAz2oWGDVFUOSWmuJAxF/UYvTtM4uQQKGirCdPmX9ehKReF+PZtkZ2QgT5Mn3rhA6LumzY7OEggn5hC0H0X2nxkcSE/0wtgQJJtNW24W1n6S2U5DxiHA8faB0kowdppqwOQ9GCZlsPf1q/Qh03joxYXvo9PLMc1GFfY9/wyWjhTEf8gHUE3pSj8UiLoWvb5CJNCU+E6vch1bEv+q0LJycYWWQT0V5KXNhoO/3qIYrCCGA0NMZtniZZKmC/3wRt91aI3xqNcZWctbLcrW8mdp5sRzRhrO60bji1GiTLC5rNOx1hsi0bl1YzErnkzIN3MCz8A0rUY0PZxb9GLzrhAwCM0geF7cfEvz5InKc15bXwbLVyP47m9EIEchLIC8avYc/UkT/yb00Jwuj16Rapb0KaoLRGkfJy90mu3pAdb+W5rgVSJS18VBP8wq4aTQSlo5hsWS6DwD6z9wzjh/qLWtkoDGEeLBtXZEKvm7BHZKLOBP4SpcB0ATNfuVJnrkmg0l4OVwd5Kv1/V/tOFX0It1x7gxOpxZ+7q9U0BWY0tJUNXOG/J01FiaLl4i5Bpmji5ymTGtlXAKrGFc6jMvgvmfUqUKfDqSce4jdq71oEY9lP+TmgA6IXb/XxPf5dtxKc5N4pFfsRkoH4tHTRiuP7BWyMGuLsZJ3QmMGaLgjcjJuIiuyA9TK6W24pE21zfhA98etARQAJ5CGbE09DpHSc4NV/GxjWsX2ZI+qMdIXPoxWzspGPiBM4w1CLFdr0yggiReWzEbhyiuxo9yPuEhUxAxAN7wt3fjdMbAr0SpLqhr9x0aRBaohmfvb2ouGm8btDtqb0XfBug3nJePI4CSxNyIZiIagDH/fMVjAcHPxCTpGlorfkyCPGnJKfXqcncbivXcmitKHM/D7S5pKUrNULWz8rgEpwn6JQR3 IPMMayS0 PV3pJ5MhsHku9sM16cuxsl9NafTU6HNAsyC6paa5uITrU1ZwFmzwZvrSTSU6vab2Pf/XsB+C3WOeAbR8Az2mhyz85JpRSk6p1s0cOUSt5ZgsOIZzhUeaLq9NqgfMhTub6BDftdU1+Nqyc7Nr94Q00BfWiSrFUHy8yam5iDUANnWkLCCCwOeOkP79jqZxK8K3yFBsakbSL2L7Ce+iRvwG/UrmsARB8bzsto9lWMX4EyzsTC56n2rK1746mj+G5VCZNGae+i3VpKgl28noC8YGdG9+UDK7QZbhncP1GZzyaeqNS6U/tayFvhyU+RmlnEO9j09xSbufg2jbd3l3INCZ4+dOfAS+lNeR3exdqIcq0uvCk+bnZ8pxSDrgKp30+ITPiopNXpXezTqgknxO7VWRjFD4NAAN7ofThGSvCY9E4J1PvU6L6Z2UigCgdq/cAhqQ5jcWmYFNl1EOtpbTKoCSeISCHY30J8NatIi+p8fPIIkkIzixN4Z2tydrQQXKHnwQsbyC2Puy/jUF3coYvQLPq+zovW+PaA2WgfK76X5B+X0sbm/OkoHZRKHSa7vOmgFx0aTIiV+wcwzvt0aGpljuEkfoN8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 29, 2023 at 04:01:03PM +0200, Miguel Ojeda wrote: > On Tue, Jun 13, 2023 at 6:44 PM Boqun Feng wrote: > > > > Cc: stable@vger.kernel.org # v6.1+ > > Applied to `rust-next`, thanks! > > However, should this go to stable? The actual functions being called > are the `__rust_*` ones (until they get removed in 1.71), no? Thus Interesting, I wasn't aware of the `__rust_*` "hack" here, so you are right, this doesn't fix the issue in stable kernels. > this is not actually fixing the actual functions being called, right? > > If that is correct, then the fix should change the functions below, > perhaps adding `krealloc_with_flags()` from the other patch (it does > not need to be a method, by the way), and calling it with a `Layout` > like the generated ones do. Then I can rebase `rust-next` on top of Sounds good, however I think it'll be better if I resend this one, and the other one originally from Bjorn based on the introduction of function `krealloc_with_flags` (I will name it as `krealloc_aligned`, since it's a function that returns a aligned object with krealloc). Thoughts? Regards, Boqun > the fix that adds the `krealloc_with_flags()`. > > Cheers, > Miguel