From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20839C00528 for ; Tue, 1 Aug 2023 16:58:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A831294002A; Tue, 1 Aug 2023 12:58:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A341F940010; Tue, 1 Aug 2023 12:58:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3AA94002A; Tue, 1 Aug 2023 12:58:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 80CD2940010 for ; Tue, 1 Aug 2023 12:58:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 473FF120556 for ; Tue, 1 Aug 2023 16:58:23 +0000 (UTC) X-FDA: 81076144086.15.56350AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 2BDD844113 for ; Tue, 1 Aug 2023 16:08:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BDUGVodQ; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hM541ERP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690906111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yWOPkGc2VQ+gyDNVe+LM0eiFFyEn/D0a9ZnSdC5vf9I=; b=xjZghiNLTBlkiXtA5p64XiyC7tJKs1j+Lf4OBej5Z02/uUIdVbUNwLYQNGJToWqAn/E0HL ulOAvFoiiu3pPB8Lo9NH9qh/MoSTCdmNe7Hj40+J2aO9iu6iuKW9hZYU/7hm95Bbg8nefI O4yYR0IgURe6cS1oLpu1COVMf1hLc88= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BDUGVodQ; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hM541ERP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690906111; a=rsa-sha256; cv=none; b=cK4tTL03RJrHAZgHi2qUCyRY0BYPzfzSdrZLvWL+6kALcOiarJFpqfYKKgR+tW+W+moglz O3FhNyVk66Hr9ySHcwK4BmukbqBLLJNpKVrgu5NfNWLNLLL9USSycrRwqMG0oV5hmAhdmz LzFmzJIcHIe/8NxjOWyvCMQH36QE/D8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690906047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yWOPkGc2VQ+gyDNVe+LM0eiFFyEn/D0a9ZnSdC5vf9I=; b=BDUGVodQtVryaNFPBqIQHVHNGSrDaV1qZLRVL3AUx9M48tb1/RLuh/T16BgmKQnW2NlCdz CS2VNlaoFD38lPoRWH0idIfyv5lqd2/9y/2BQLMWwM0gi/iZobolsGLohddgJlhzrlciGm LH8TnEBZWkzfZMRHnzHGRP74OGVO2wg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690906095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yWOPkGc2VQ+gyDNVe+LM0eiFFyEn/D0a9ZnSdC5vf9I=; b=hM541ERPFn6bsx7H9QNzUGasyblSqjj4bDx98ued/aGYkPChK/t9EyHz6eunpH0amFiILa 2i0dnieRz0p9+tZx8bkUsd3LFFsTBwPuQL8vmrLQoqginvH88HUy2ECTI2nLZACeUJ6KIA xvoUVvqshKkl/82BWv8QZit35G7HRZ8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-H14Mzh8TNf-W3q4ySAKZnw-1; Tue, 01 Aug 2023 12:07:24 -0400 X-MC-Unique: H14Mzh8TNf-W3q4ySAKZnw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-76cb9958d60so38541285a.0 for ; Tue, 01 Aug 2023 09:07:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690906044; x=1691510844; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yWOPkGc2VQ+gyDNVe+LM0eiFFyEn/D0a9ZnSdC5vf9I=; b=KM2HCk4qgBxqdopJHH4zsNNNUQkw07Fa8vLelTPr37UyqHnjWo1aFN1m+L3JJ1n/nW mwQ+lfEuFiOZ5ugd/6FEM7Irjgy47y3+9vD6azDmB/amvlfjbJEh6bCQaVbAPAPGHu6z CVYNyBAe65ycGwGgtNGTtV8KXPHpw4Ad9ls7Lzuc78exKOQfnR7F0ta7w4J20o5VwUrQ M9nilpKuiW/pLGVTMizw+UnORF2p9dq8FeRbyS6HQT25zeVNXzX6pwDwjHNkMBHI4u/J 7zuGliegN3u7gczR6zM8DVQS07TmB9XjyZ0IA3cs65OX+xMHDBZeoi8L7lV0Nedo/n62 1wBA== X-Gm-Message-State: ABy/qLYqRaGcVGpEp3uLx3bZBa2WGOjpmbMRz58wA95/SzJrQo7mwiHp j0Em+bgabjeFRCrwVPYJ4tXwtchcfyWTFfOvTmumAVGx/p5x+y15raK/hzZEDHnnOYCoOzfAN3V AKQxnSI2GNn0= X-Received: by 2002:a05:620a:461f:b0:767:170d:887a with SMTP id br31-20020a05620a461f00b00767170d887amr11729622qkb.2.1690906043926; Tue, 01 Aug 2023 09:07:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqB7mU+Qbt0x6u8wDG4VYEiiNsMIxzWprLKmcc5Zc3mCLE/Anc8W8CylOrTkOpU586dh/Caw== X-Received: by 2002:a05:620a:461f:b0:767:170d:887a with SMTP id br31-20020a05620a461f00b00767170d887amr11729595qkb.2.1690906043654; Tue, 01 Aug 2023 09:07:23 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id z5-20020a05620a100500b00767cf5d3faasm4237042qkj.86.2023.08.01.09.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 09:07:23 -0700 (PDT) Date: Tue, 1 Aug 2023 12:07:20 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Linus Torvalds , liubo , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() Message-ID: References: <20230801124844.278698-1-david@redhat.com> <20230801124844.278698-7-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230801124844.278698-7-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 2BDD844113 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: x5spcdhy9hetdmkitk7hh5p168cseh9w X-HE-Tag: 1690906107-790228 X-HE-Meta: U2FsdGVkX19Tmr/MrJUEFq4eyBMlu+e5Z7E+qNf68WoF/Uoln027RMg6MPliK9IuZSJjus8Sjooeh1zDL65S0J7pFSOGE6RFpK/0w84/DJhjQm9xa+5elx0FQhBbPZ/WiraEOEnrM4C73eTV/unzecPdeG64Jbl6eaDdkIqV/8S4VND0wL9Eqg+BExyv6py5rNxZ9qJis9Kx+/o+2ED+lKnCCUppUDzP40k4pEhrXs8emFVHcEU0sX2RBFkJv4HIXJMGlsF+zMEP5wGO9FDyVYPoiMPNvQheaYC+euFy3PyZnknt07ZFfQBqS00prU1WHJVwhvbOsolys1OC/IzET/dBt32Gr6XPFrIUjoHu7FjtIIPKwIXujqlpGG9A5Bpy7dcNqOo8nfLnrnV/Epg4JhEyA8xfg7yAndt4u7UqLsKwklYg8B/0d/Oid9tMVeHqZnlvGDUVrnkpvUe1AEMRAsRGz+zNCfaUhbe2tC7L1DYMmkSXZnaxQ7zVETyvZXC4mfzy2hDF5rSNnV4KyZSWru5c6Egi5eahJiF2AJcMDFeXYDXh2oIvr33duCdGVXxdXGf87XH9ox+BIypQIGuuApy3JTOrA1/Rs1LyWiX0IUmUMRJvZA7QIjm+2BQ7XfSW57bzRu9ekWUysxHXv3OOLAdTy5bJ78CiOidKwM4T1wePafz1+e3XIBQJzZqLuERbUO8350dNZUEWLhT5TycDk9HIcA9IurT6ERbehOIy4Y7j5w2BwQ5ca4lgcfFrI3Z8anGLWZohdH/S1dPyZLtctEZI8EPkklG+LmrBPBV8DruwGF6NM1TDzHatxDcpUDtYOUzG2dQ17K+2JNgphcX8h/mN4QkOuDPe4MnMz93rUpPD6oBc/ku33577yNBox15qzCVXFkO0ha9pMl7FHiivx3qnabI0OMge2iNNNLoBBdypuDfyS7bGe5KSnBFCIYGgeYvz6h7y7TFKqdsawVU phVdAhVe RpleoD+uAUHVXCzz+HgeCm8zDG1zUZW25QnqjO9T+F/LnQuyQqIwIw4QBg1ZCNFm1Zj5ex3aD66U+DdOHm18gHK0+5qSkYTbgiAXHxReZaqUWKKOyI9xaAa/yr8BladjJQ/KJMANHiJDa7WfTKzcTZ19jDcWn/ghCZVecjuvvEGSRn1jMJTezSllhiYy8OfS8IeOnH7xivJ07xZxRPe2jF1YPAHyTZgRmIz884OBc8YkTjoKd3EtdQEScTv1czk3B9GJ8XlswoLUnBMmUcmhEbcJlFYqe+icW5+VwggvFk+Of4TvUVsyHaPkV5BLh4YJYNNmpooM/tF0D8tAMXTeSIE4y6CKkCNweRdhbCjhpuJ5OFKEWl/PeqG4uT0Rai8ikqOBZpUlXTzhLsCs6J1f298ZGrRfRlyegJ+E4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 2cd3e5502180..0b709d2c46c6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1467,7 +1467,6 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, > if ((flags & FOLL_DUMP) && is_huge_zero_pmd(*pmd)) > return ERR_PTR(-EFAULT); > > - /* Full NUMA hinting faults to serialise migration in fault paths */ > if (pmd_protnone(*pmd) && !gup_can_follow_protnone(vma, flags)) > return NULL; Perhaps squashing into patch 1? Thanks, -- Peter Xu