From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A3EC001B0 for ; Tue, 15 Aug 2023 15:32:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA07D8D000F; Tue, 15 Aug 2023 11:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E510A8D0001; Tue, 15 Aug 2023 11:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D18B88D000F; Tue, 15 Aug 2023 11:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE8018D0001 for ; Tue, 15 Aug 2023 11:32:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 62B0D14097F for ; Tue, 15 Aug 2023 15:32:37 +0000 (UTC) X-FDA: 81126731154.02.882E032 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 2D00240003 for ; Tue, 15 Aug 2023 15:32:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oz7Ch3Qd; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692113553; a=rsa-sha256; cv=none; b=GioeE62AZccs7apicuH/sE6iEefL76aaBQGUOKTxZ69sP+ItM3UFcphoURtXjBeWNkp1nP lwY5vrDnq3FpFVXrNVu+Q1o9OA2LWkDqtH5RyZWsn1LR4qSLkc96X0f9uFI7Iqwy+7baiS fGZ4mqq4qdGIET/ZCA0PVfDpbi8z/co= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oz7Ch3Qd; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692113553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q5wk83xdysE8z0uq3teCC6Wat5W06qSOKL17sNuBLdQ=; b=1+YPUkD4AFgVFe5rX1TcW2g+07jb37J5+IZkBfbdvmxp2YSEXvx+btE0dE+CDoQbvDPkRr V8b6IQrtpiKR1XNzWvxNeqMdwjz4Pj3zX181UktY+vi3JbWBl3qfwEUawTrNHTv0yKOgJ8 bFHyaMWyKbBfrmxkRK29EWcnwsUEaMg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q5wk83xdysE8z0uq3teCC6Wat5W06qSOKL17sNuBLdQ=; b=oz7Ch3Qd9zSWohQJDHFLQS2rq2 n53BuX5w/26/qPIQfHoRwjojwr5Q6srtzfON3zk1x7KoS5ojxyTwBawEPZS608jDw0HyURjfDsSlM lmA4/u+fhNuRCsReiJQnzOVLi+7AJjRNlw9kRXokFg5JqCgJDhaZmPmWBqymkgWlCo2KD5V+oVlrj hcs1pzPcm/y5NCzUk3v6q+IcS/ZmTTnC8HkliOaopDU5VtvtMpQHoRAhmoUbp0VHnolJsHTaCO+mS 2yRNAghrGG+KouDkB3Y93zqbC88UMIOJzAkBRmODDLq+wqgNr5DRiHYICnwsDtJ3thxuG8L/A5M9+ 1fZbQ1vg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVw1x-008xbP-GG; Tue, 15 Aug 2023 15:32:25 +0000 Date: Tue, 15 Aug 2023 16:32:25 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , Jens Axboe , io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 7/9] mm: Add deferred_list page flag Message-ID: References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-8-willy@infradead.org> <7c1bb01d-620c-ca97-c4a2-2bb7c126c687@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c1bb01d-620c-ca97-c4a2-2bb7c126c687@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D00240003 X-Stat-Signature: 34cwkiq8jwnn7ud7k4i4hh47oqonrzab X-HE-Tag: 1692113552-992434 X-HE-Meta: U2FsdGVkX19+yb/Q/3wWBjBKc0smjHO85rm3/g2twnrzeqSyOr5+x2+EMA3Eq6Plc6946AEzShm2t6bH17QrBHgDgcY+gemJRy2bt0kgxCAmXW8zK+5B+kTYltgteo5VV7XNQG8fVWEaY89asYUl4dZdc72jYGv1IkDFYh8QEDEKkkVheQJVVVs2hC75ZK0PXScT9yezgQ6Nfd4SOhlcAc/+0i0IzB9FnJz3jR+k3KS6YASm4iGVVanSoLOuQISunMqcpzf9QJEpowOII9KveKwbQqaFuTGLBKvP4h1Q/qCUI+B3JbmlrYdCJn+ybkQdqCi4EPYLpSJfPv5yZBe14pf86zY7497ZtWebFi3aIedY9NC7mcwd5Kbv6/hVThIJ9ZjD2MELJImFalEcIJ5wNZEYkfodtndJoaYq6j0akQ3n6pmAvjSuw5MPunOIwHurI6RUTvMlFs7Rn3RFNCkWiXqepyEJR4hTDMPgJM9uZp93i414PQWAwSVlQBwVlXnKFKfc5aKdesLv3F5+QuDlfhB3cuEibC7QPBjbeKv3LHMUUltzdHuE5anWNEhgkZ5pZGOvuvlTkpKdiyBKunmU6x+dgzrmUG3iS7xuzo8sRxGjFJFYxrQxzD2i4CqTvLeZzwB3UH3tLUvQMACEp/awWR09P/cdCrwVifO1+zhxDFgN9biffPIJYQVGKJ6D+TBmHnFi6dVEdi2O85VH+80EGjO/ed7Ynf8TroInJLMumWxz5ECzuNVf8grF/ac7dYns/d+ByJX2BuMlqaqNHUBqlVGKN0U2NowLhEXn9tnwipAGlGqEgwuEpQopURXytPqg7162E2QfiMNfv7BZixScP65d1NLsITY+wYR55vW+njQbdy271Up/uvCAg3lE/2ADVuGwKMqbp8S/3JHbNrcti7DJ2SOaJKW4W37l1v7dY7Q1SP0NT6WsgbCxUbmzvNY3zgvCmTGV4F2dCxMbSc7 LbZaw1CM RoN0BjKekobJAvQIyi6bLqy5UvZC4mpHLy+6cqqzxrlO4gH3/g+peggbxHO+ocXYlbvo9wzAdaPfjcfK7NDvhl2N7HyBK1Mk4OBIWAeVWFPstlfd0lmU3oUlCbQaQDwY9VgetWzmiHSRtNyuApziREPjHgUynBVEUhznnpsubfsIWuMsuwO27njq6qzRJLfhpYOL/g7nSLaa2VK0UYRchwJ9GgCJKYCxYko4krGKKceQtWO0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 09:54:36AM +0200, David Hildenbrand wrote: > On 15.08.23 05:26, Matthew Wilcox (Oracle) wrote: > > Stored in the first tail page's flags, this flag replaces the destructor. > > That removes the last of the destructors, so remove all references to > > folio_dtor and compound_dtor. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > [...] > > > + /* Has a deferred list (may be empty). First tail page. */ > > + PG_deferred_list = PG_reclaim, > > + > > If PG_deferred_list implies thp (and replaces the thp dtor), should we > rather name this PG_thp or something along those lines? We're trying to use 'thp' to mean 'a folio which is pmd mappable', so I'd rather not call it that. > The sequence of > > if (folio_test_deferred_list(folio)) > free_transhuge_folio(folio); > > Looks less clear to what we had before. I can rename that. How about if (folio_test_deferred_list(folio)) folio_remove_deferred(folio);