From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 056C9C001B0 for ; Tue, 15 Aug 2023 15:36:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46EAA94001A; Tue, 15 Aug 2023 11:36:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41F188D0001; Tue, 15 Aug 2023 11:36:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333FF94001A; Tue, 15 Aug 2023 11:36:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22C218D0001 for ; Tue, 15 Aug 2023 11:36:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D37C940DD3 for ; Tue, 15 Aug 2023 15:36:50 +0000 (UTC) X-FDA: 81126741780.30.2A0A2D5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 8E13140024 for ; Tue, 15 Aug 2023 15:36:48 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=usmNcF6c; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692113809; a=rsa-sha256; cv=none; b=ULEPP1MC0MmFZ4CsIWuafRTlLp2teGHG2mQSpm8HuFoGYvIABzefVE12AKLaxaj+V/738b tCg0zX6qi/IGBDCnuVAtyXvq55oSoIJR1cc+cW5HCZE96pkVuMw9wEn5bVOYaxbpjCHY+G AQjodEMi3dy8aAfDflLARJCWDYCibgg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=usmNcF6c; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692113809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dhoNRTbE8KQSwud8rLuSMmzGtsfUaSQNBP+y+CbJZrQ=; b=WZ+014/hctPvZQMQB2sOB6tqH745NDzOuoce6lM//LbDFViyttYublqC0j/XTz7suOXVWY 5kiXV+TAs2PZdUPdsyjKXxZPiIv5d+X1jI5GePLNQiWEiaaooj0gArOAlDHFpiPFwIl0VI 99ZSG69SWM/hEPBtf7lPk0dlUNTV2KA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dhoNRTbE8KQSwud8rLuSMmzGtsfUaSQNBP+y+CbJZrQ=; b=usmNcF6cZGPZXeCDLQsrRKaYYN C8iJ8SuSfY1vygojI8QLzMfLd/+GuAh4BUD3x+AHG9cexsT1Ian2EVyCQK7UUgMrFVHbFDRahAALn AIJMRYoGiHaL8zhgO0L2qjV08zUmm3n1LdDVT3tmKL09RrBGArJD5R+F9yFLbPIUn5XiZBbu06JWs uPpZbk+lb7+15xLA8ikr47TGTacwN8gcHeF+43Xu9TzOZB4qJ3HJcg7AA/01XNELCQrG3jGZPow0C ww806I7kyTgGtGvE5mk9ZD+wW+p+ZxR4weppGJWfPLq7x1GgycQe+HZnXLtXv3+ZgNgY3REUhEzID UtZdzcqw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qVw69-008zzA-5L; Tue, 15 Aug 2023 15:36:45 +0000 Date: Tue, 15 Aug 2023 16:36:45 +0100 From: Matthew Wilcox To: Jens Axboe Cc: Andrew Morton , io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/9] io_uring: Stop calling free_compound_page() Message-ID: References: <20230815032645.1393700-1-willy@infradead.org> <20230815032645.1393700-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8E13140024 X-Stat-Signature: htjkz6f89x9naebdjs6off86rdacw8by X-Rspam-User: X-HE-Tag: 1692113808-468604 X-HE-Meta: U2FsdGVkX199uNx03Rg/nEqykMvLI51CsOz+7sXBJxaQjXzoAdUdfDNHD2XlHztp4MTlejnMUcTUbxQsF6szGqY+Az00wyHStJa3DKLlO7OCwoDbeQ+dnTCn7mAXx+zZnqNNJ/PCEDCQxZZj40BOpatIh8rSI8V0HeWhhijQY4aCg1/XpYkoVpArAcc6H94E2Y7Ai64Nt+ZAXG90S3CkhZNHeTFz1c9MfJXyJK9kSgwrN+ZyymNo0bf2GpY936O/aGSzu5OgFlv9k1uCigjfnzHngpQXG2XNa9QXTRmH3cY/zejpuO+HNIY0NTl6HHcK8KgZCNS6HFVe4Xv9roHQyh5MP978F0TLhX5LRH5MXlM3MUx2f/IZ21b9G/sMvAzit8GyZZiHTBU7RmBjP4EmKwb2R9yr/Bdff+0Hd0a4Kn/VY67PduAEm86yLnmgo68B62t4OCr+fQX3WvKP9jjFNtOCIWDQy/0T6VNMNOp9yvXx53v4W9pYIqgmpoLgV6wJ/S1rLPLnHvcJT6iy3L2MCznnLHg85ya9IfnYI+fJeR1b8yI0rw3kmkdSuOsXjYDxkhKtkL2aoT01o/1RScPPNWUotseCY+yNyUYiqbkQ2jYrlzWUnNaRcbiNOY1ug2xX+M4Zc316NUbMntvmg8CeOLUDUOpoN5ClaOfebtlFLz68R75J8pSrDL5zQge4bEPAcCO08tOlu1mngWpXFh6k3XwqSLAJgu/Dzy2HKv+11NHd/IxK6KZuy78NBvsimcDETznCpApSErIFsxiRikKKrgt74KWu2tdG8pBRilqUiJQmhzBmUXzhzqps31/+r24vT2wrwJLza+E315IbAQNOab65zQugJjFF2WVspGjNuisiqnSBzSW6IoHqo7Z7PEhalnP69SwJYOPFmmjlXUraysntwOLCDAQuAJTlVZYK17Z0MR5USRUd7cuiMB1ORbpX83bvjt7D4Z8kMtSUNMY yq2kluTD n1NBtd8/Za8LNXycGOeBeiX01aA9/7IwGzY7K+N5jW4e/LfI+CPZJNiV045U2eLvmAgmdH3+2JjD6p1UFNG9rRhBw3BHrqGfDhAD8PShK7TghdYTFNq1koz4Y3m45c6jQxAZi1+VAM6uhUx68lSloTaRe3JSJjKs8VFYpK3/xI7sRI7DPQWAoyXyJFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 15, 2023 at 09:00:24AM -0600, Jens Axboe wrote: > On 8/14/23 9:26 PM, Matthew Wilcox (Oracle) wrote: > > folio_put() is the standard way to write this, and it's not > > appreciably slower. This is an enabling patch for removing > > free_compound_page() entirely. > > Looks fine to me, nice cleanup too. Please use 72-74 char line breaks > though in the commit message, this looks like ~60? With that fixed: Eh, I just pipe it throught fmt, and that's what it did. Probably it has rules about widows/orphans? > Reviewed-by: Jens Axboe > > -- > Jens Axboe >