From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D335C71153 for ; Tue, 29 Aug 2023 03:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81588E001F; Mon, 28 Aug 2023 23:54:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E31858E001E; Mon, 28 Aug 2023 23:54:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D20838E001F; Mon, 28 Aug 2023 23:54:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BA7898E001E for ; Mon, 28 Aug 2023 23:54:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B3AF80678 for ; Tue, 29 Aug 2023 03:54:55 +0000 (UTC) X-FDA: 81175776150.04.F8315CD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 8689780004 for ; Tue, 29 Aug 2023 03:54:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qypBG82Z; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693281293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMp/x0VkYc4Zey0ZBUSOtAzI93FMpN6TFWN2LIHdEJE=; b=zKU1vMaZDgw+jL55LupeaGV9JOBzhQns8Vg/c5UqDU+trnQNT99NyfB63OwmUQ91Jorow6 jaqH/TOPlJeh9AWHBVTGUIGd2ES/DcA3SRM0E5BRvkYSesBFrI2+/lK36vlb6h8TeaxxUD rHXishsdDk6wCTDuWkt1nkdz+LQFcEU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qypBG82Z; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693281293; a=rsa-sha256; cv=none; b=YGb2FQqS8hQXNcavbykcNuu5rF5Oi/cP7mnMYf92t89jMe9Emwqld/cA2vHHcWzo1HLRQf kt8muSZydRTGkR/w/O8yiSCB9Zi+dnIE+oQdm+UgfGDyJXfHGiAxbLsmdF7DH9GzuH4zik /Sn/qXUYM7IqXt55kjYXk1mLq8ZAqS0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yMp/x0VkYc4Zey0ZBUSOtAzI93FMpN6TFWN2LIHdEJE=; b=qypBG82ZV9M0XDWrHKOlbg32hU KNKkDitRDRncUwYGh6LLomwMy1xG/GauQy2CdkKZhiXAR/swhmQvMa9FiCsNEKWdjOn53xjCMqmkc J+1TJqp9gZ1D0G5EcmOTA6ekok/GPTYgXRSHNzWeJYLzuX3z1SRUYFiYQbHXSRYHPP25BOU21NKKq Xf+YJ9484pEQ6U7zfyqVDSVAw4d+4WeaK3+pRt9vzSUxcc2vCc1vuIjsa7weh6a3PWAp1GPtBxHzm hMIjwoLCx9VWMDAg6F3VbN0zsGgPmcGfOHVMgRLNS4MxhvLzlX7LCiIrYsnaySQ12nP18oI5kK7vp rFq0WIqA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qapoU-004JpN-OL; Tue, 29 Aug 2023 03:54:46 +0000 Date: Tue, 29 Aug 2023 04:54:46 +0100 From: Matthew Wilcox To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Subject: Re: [PATCH v2 7/7] mm/compaction: factor out code to test if we should run compaction for target order Message-ID: References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-8-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230826153617.4019189-8-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 8689780004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tagroh4qtbcekdmzri43yccpsx8afrm7 X-HE-Tag: 1693281293-704337 X-HE-Meta: U2FsdGVkX1+or2ilGHlHKbA1/OLbt0XjD6vYYBUZLfqa9YRjN/pubyFrgJJfCtju9BRSP3B0nu71w73feFRLTcdvhIMi8W8IEfZo/gEjPgrJVGM+7E1oSs+MbwftpbOsRlPp1lIXAgXfVPTmIL2eLsdc9Rr4HwQgK7nstyiiGc1vstn3fMRCpAi1RIM3FoCYUDnxwJwKKnv3i2rPx2pizjVTrmhqA39e2Uncs2JUmA8rDtyM0QJ895ejnoC9vt2eVgfKcCdLeeRB8VEdJrFyBrWc40oh8KOD/y0LS2I8Hg25KBKwA5ZqsE3U1jrGHHK5RUe5OOCSo9iHs3BKxBqSuxoawhOKIR8Quutew/3Ev04jD9abLm0tkVRejIjo88kt45sl460/NihLJ3moqrH2DHuO8F0dZfBYr7vs8oT1CEeaKKbStrWEypPrdHmsFSQtyS3rOCzsL003Y4vLTtZmpg7HDHq3QYaPvRyo44DSDt+lJRrpoCSvujZbtLInj0d+eS/QAx/1xl85QwlGODvn6qOSd/85wmrbbLSJlpyuuVdwVHIVnv9HOVqIv3in4b4RRUW5eRP/k4+Lh0AOnocTDVjs87jEMKxaVACaqAT2d4x9PzdX8c7VDk0PATNBgFl9Kbgi9FsMnQd/gaBuERm7KSgdQXaQ/KIicK9uTizOUltEq6WfURgkEb9wg3u6c6VH6EAhZKnm6la2MVPitoRr+7LuDr7GqClhyuUI25WYiojTQAYGrbl+DVYsDydNNgmA+RYXWBot6olv8/KJeQCk3LzHJ5I1jHioXGaXBZHN0bHwH2FCypCTJEnqfrnpU/o3gCrNqnCQd10C6x6NVI/VSQzitYodKB+6vv6YE6KxDFryY59zimFQAwYepulKiNwXEW4Rb3TG7uZCRpKvsU+cC9nGHQwW/mmcIlDHIwYv4uA2LRMidpWHvw0HGBhk79ocV2pQvrCXdlx59Rol5On B6ASvyus N209bYfV92o2zfSpDWG88tnDCM7kC4bB5lbvlGGyeATxQXCyx2jhUJppFKqg+tY97zxKbbQRNF6lIqPE2cCor53rpYBK44+wvcx/nGrrMYu+65Y5wBjuOwvdTJspaAvrQM9l3UfS9hsFxsNbo1M0l7LyyETrPIwdxq1YvkzpMNaWSut3tCqNiCW6ggfEKpSNF2J4SH+f1bVUYSGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000180, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 11:36:17PM +0800, Kemeng Shi wrote: > + if (compaction_suit_allocation_order(zone, > + pgdat->kcompactd_max_order, > + highest_zoneidx, ALLOC_WMARK_MIN) == > + COMPACT_CONTINUE) The indentation is confusing here. It looks like COMPACT_CONTINUE is an argument of compaction_suit_allocation_order(). How about: ret = compaction_suit_allocation_order(zone, pgdat->kcompactd_max_order, highest_zoneidx, ALLOC_WMARK_MIN); if (ret == COMPACT_CONTINUE) (assuming there's a handy variable called ret) You could also distinguih it by indenting COMPACT_CONTINUE by an extra tab, but I think it's worth an extra variable just because this is such a long line. > + if (compaction_suit_allocation_order(zone, > + cc.order, zoneid, ALLOC_WMARK_MIN) != > + COMPACT_CONTINUE) > continue; Same here.