From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA10C71153 for ; Tue, 29 Aug 2023 14:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2DB8E002B; Tue, 29 Aug 2023 10:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E92FB8E001A; Tue, 29 Aug 2023 10:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35348E002B; Tue, 29 Aug 2023 10:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B936C8E001A for ; Tue, 29 Aug 2023 10:25:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 889E41A0147 for ; Tue, 29 Aug 2023 14:25:19 +0000 (UTC) X-FDA: 81177364758.15.66E31BC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id B955EC0021 for ; Tue, 29 Aug 2023 14:25:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ni8iwXg3; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693319118; a=rsa-sha256; cv=none; b=RQ3eFllB2aZ/bWpvJ0AGhB/Gm7oUn895Qwxa2twWg5jAaBTlc+v33jwGyhXX6hHdCZdYOy Okd0Mbwqh+OE3ssbDfOIzDDyCdgdbPv+1WTIhieCR+AcOkqF2ErWahoXnl1hbWtoClSxGt Lq7ciWDyifD/2oW4ptac+HbcBhSO2oY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ni8iwXg3; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693319118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CVKHTAOju4/Kpfxf3rY34wfjvySGLxW/e01pPFR8Jb0=; b=VCcrezVBwDXOlyLELAotNWeafn4iQnTJ7fU/lWZyArkb8py+Bq+J41XULV3BuTK7bw1lX+ 0esy9WvM7coSaea2xpZpQdnQ22OGsIZGoa/ScjQvCcRoUqEbzCXWKIAPiZhq71puDwSjHb aXp5eMDhZ5TzN2UXu4mNVl9GGHKA7LU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CVKHTAOju4/Kpfxf3rY34wfjvySGLxW/e01pPFR8Jb0=; b=ni8iwXg3R/pSgOwiM/4UWsVy/+ JU7IDy4YZ4CCuTp7Xdjn67Wn54IkOF4kkb8N+jhQwpljIpbECPz8/gofMM3Asc53AvkxwQIqhR2/F FTjmMfASMTB6XW8Tw0oaOHdPAFZ/dwkE9ROEJo6LvbIOQ3zbCmiiF/dw9dJCmtH2r33/yYXDRQpsO wdnTlP95VBtRAfjIQvhP35ajSdxBrUIhT7kRSTMshf25sGJuZJV3bO5Pop0mQOETeCYfHOBepebLo KJkP+K/lqpLv38PngbOhInZ/Juk5VJ8bWbqLFGhv33Bcyn+t1UCM/TZtsMEHYN5SSpvgAsBO8YW/+ C2qBCGuQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qazeH-0073hu-Un; Tue, 29 Aug 2023 14:24:53 +0000 Date: Tue, 29 Aug 2023 15:24:53 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , David Hildenbrand , Yu Zhao , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges Message-ID: References: <20230810103332.3062143-1-ryan.roberts@arm.com> <20230810103332.3062143-5-ryan.roberts@arm.com> <29099099-7ef2-45cb-bab7-455f58de47d1@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B955EC0021 X-Stat-Signature: kefkh3noihb8wycgpqqrgwizfp6xgg6p X-HE-Tag: 1693319116-613304 X-HE-Meta: U2FsdGVkX19ZczqolXW76uInnAIDbpTybIcDTnxEhkgYKxxcuS/fjhdLU5JFZ7vPOrKMmpIXQOq8aTX9y5ZWrrtBNHp3tyweGujVZAdHbFp2HVPDzEkcs7qiOrNgBHa1qtyBIgMd7/AIU5xVqFNI4JCwWpDAUezdrtZeiOqUtEgde4YHMOslRB/FQqRQZ2eLMcZoGXRt0AADuFnxWfkPCFQy61DG4Jq1iKDfYxfxkfIHSJR5Xc/a/juQKuJ8X2bg8MHuNk1OnochnmLcc+DPtGlB2wigSXV0Lalbbq5CUym5P3n7Tbg9xGOxeANMDmv8uDrBAW6apxcn3++d1MHOq6G0k4YNdoEYRAbvQVTt7JRBAIWsHP4j1GCVQa5H9PiHfhvqJNThbfWH0i9BLGh1orZjBS7LcjSMbaHiv0WaeyHf4OGXpM20Oo1fYevTrQpnJPoeMlfLhrpvYTttzROc30G6Usy3sq3mZNhv5B2IyfdJAEv6+Ex96C9Xbl1gkmEYVkY01pOrMrpQPCyHEc59Vx3eiQQBGB4kMQxVSnSGC0ddmGXrIkrgzo1DLaZSYTS8IQLVSdQBI/ANa9hpZtQUgiHWXjL6jveCRCEqiz5MGxHsIdUCK3aaGRnfNvZv0h9Ew3UMMFd4La/J5EOWc962bgIFsla1UVri4b/24RP8O/D54C53q72RRCmhMToUp8mcciHhJJxUtj0JG6VvWFJ3NjnbTgbCV9D/bWGJVFgsVhD8+VeJJ98QODcxUqGliXef/nH/ACSiBKD2UuHpgGxo1Vdkx/E3W/6iNmBXfdFIQSmBp54vmZQRcoF7CgUTL3C20lEPB7RdB5cH41GvHqDmUggbdI/o6PjqVMW1jCz5VUgfvBj3RcakaZtJqOH0BuyDeF2cb71u8gLTo+lGE4vpDp+Jj4jknSelQfWVaKd6FtexBsf7KEed9DSfUJtV4EqceaaU4EoOIVTmIAHqQh2 xC9c30tp pAkzyfolHCFQJtgS/WOSDmW7Ncr3vOfXRfH5PgWI9/fuJC4l3Js2EcZ+5N1oer0kDqWiLpxbdgcuSLSse75xKnQCZACodWctrcVSWq0ZP9Tmf9W3y5g02Vv2uyS1mTMhjLnRm7UKaLKyJgFKgLeEvltCnzAlpkELq61p1FHPsiB3IYGS9Tbw/yFGWBdAHqCfKWH+te3cZ17ze4PWzptSq00UOFLhgT1S7WpT65DZVHgEZXrUhNaxOU5Y7szqKSIwMF+P2tc0DcZd7TFcXAfiLBeVTKj5dkDigMne+v2T+8EwLzHKpcc1/fPORaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 03:19:29PM +0100, Matthew Wilcox wrote: > > > You'll be glad to know I've factored out a nice little helper for that. > > > > OK, what's it called? This is just copied from release_pages() at the moment. > > Happy to use your helper in the refactored common helper. > > I'll send out those patches today. No, wait, I sent them on Friday. https://lore.kernel.org/linux-mm/20230825135918.4164671-9-willy@infradead.org/ is the important one from your point of view. It's __page_cache_release() which is a little different from the current __page_cache_release()