From: Matthew Wilcox <willy@infradead.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Will Deacon <will@kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
David Hildenbrand <david@redhat.com>, Yu Zhao <yuzhao@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Yin Fengwei <fengwei.yin@intel.com>,
Yang Shi <shy828301@gmail.com>,
"Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges
Date: Tue, 29 Aug 2023 15:19:29 +0100 [thread overview]
Message-ID: <ZO3+cQouje862QNu@casper.infradead.org> (raw)
In-Reply-To: <29099099-7ef2-45cb-bab7-455f58de47d1@arm.com>
On Tue, Aug 29, 2023 at 03:02:22PM +0100, Ryan Roberts wrote:
> >> + if (put_devmap_managed_page(&folio->page))
> >> + continue;
> >> + if (folio_put_testzero(folio))
> >
> > We're only putting one ref for the zone_device folios? Surely
> > this should be ref_sub_and_test like below?
>
> Good point. This function is originally a copy/paste of release_pages(), and I
> obviously missed this. In fact, looking at it again today, I think I'll factor
> out the vast majority into a common helper, since I'm currently duplicating a
> whole bunch here.
>
> In practice I think all devmap folios will be small today though? So while I
> agree I need to fix this, I think in practice it will currently do the right thing?
I think the devdax code uses 2MB folios.
> > You'll be glad to know I've factored out a nice little helper for that.
>
> OK, what's it called? This is just copied from release_pages() at the moment.
> Happy to use your helper in the refactored common helper.
I'll send out those patches today.
next prev parent reply other threads:[~2023-08-29 14:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 10:33 [PATCH v1 0/4] Optimize mmap_exit for large folios Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 1/4] mm: Implement folio_remove_rmap_range() Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 2/4] mm/mmu_gather: generalize mmu_gather rmap removal mechanism Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure Ryan Roberts
2023-08-10 17:34 ` Yu Zhao
2023-08-10 18:31 ` Linus Torvalds
2023-08-10 18:54 ` Ryan Roberts
2023-08-10 10:33 ` [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges Ryan Roberts
2023-08-10 14:44 ` Zi Yan
2023-08-10 14:55 ` Ryan Roberts
2023-08-10 14:59 ` Zi Yan
2023-08-10 15:05 ` Ryan Roberts
2023-12-04 12:26 ` Ryan Roberts
2023-12-04 12:28 ` David Hildenbrand
2023-12-04 12:39 ` Ryan Roberts
2023-12-04 12:43 ` David Hildenbrand
2023-12-04 12:57 ` Ryan Roberts
2023-08-25 4:09 ` Matthew Wilcox
2023-08-25 7:13 ` David Hildenbrand
2023-08-29 14:02 ` Ryan Roberts
2023-08-29 14:19 ` Matthew Wilcox [this message]
2023-08-29 14:24 ` Matthew Wilcox
2023-08-29 15:59 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3+cQouje862QNu@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).