From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69802C83F12 for ; Tue, 29 Aug 2023 14:19:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C70818E002B; Tue, 29 Aug 2023 10:19:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1E3B8E001A; Tue, 29 Aug 2023 10:19:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0EBF8E002B; Tue, 29 Aug 2023 10:19:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A24B88E001A for ; Tue, 29 Aug 2023 10:19:49 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7045440188 for ; Tue, 29 Aug 2023 14:19:49 +0000 (UTC) X-FDA: 81177350898.27.B792D3F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id CD2404000C for ; Tue, 29 Aug 2023 14:19:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wGtTAk8u; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693318787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e4hMctN6emCgrqiKuxK7UKWS85HR+fi7fjHSuR7TJAk=; b=Hiu6YNCyAwuz+BcA0v7OUmD0Q+4ewLSBOKA64mYSrLefNJqVV/QzOxyMKcW0P0d5vzxP7O qa4/xHe2oG2jKOF/HZ/T2ZhXSCs6E7jA2Ey6LZfDxKifyEpN2fECZ6wcpwJvtpmMNTlrb6 eQnCOlzMqKs1k4Rqax2UI0bmV91fWuI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wGtTAk8u; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693318787; a=rsa-sha256; cv=none; b=cZJyx/LjoPXglHK3+atqWIvqCu0H0QP9AToC0NZhM6QWkNo+pOWL8gyITdOiB2UPpv41ap xozlf3U00bKIoYA7mPYwYLd9LMdOVT4WDUx56QoITHqk469nXqaNx4xYfk6VjBizuSgdOs 6CyDO6iW0QhPNyvEFzk6WXULckPe2O0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e4hMctN6emCgrqiKuxK7UKWS85HR+fi7fjHSuR7TJAk=; b=wGtTAk8uXg4+MUSjXCkamKt4+O ytIr3Go3FRCrQRV2Bcs7qEZBhVZFDleCQWG+1fal6IxDqrNIt0ba+7uTclPUN+JjINfL4tcjQ6Zsa DZ3r+hv7v0cmIFAdtbdSEMI2R0mYXbvScPCX9noQQwt9b0xKmrcbC9cASH2QzzZeuOR/B/6qH/rm1 RH01II3NoRdmwioVWAszh+NazastL1w4SczDpXbMTAbiyrMLkP5ggtXn+T5W/Fm86zbgj2hFIie+E v1AiH79QxLeZUjd1IC1bxvRCcWmOYRaQDTmxexp7xFANkZW+mgYjkclwR73BELHEQwiqiPSyg+5ik Sj/lurOA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qazZ3-0071DB-D2; Tue, 29 Aug 2023 14:19:29 +0000 Date: Tue, 29 Aug 2023 15:19:29 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , David Hildenbrand , Yu Zhao , "Kirill A. Shutemov" , Yin Fengwei , Yang Shi , "Huang, Ying" , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 4/4] mm/mmu_gather: Store and process pages in contig ranges Message-ID: References: <20230810103332.3062143-1-ryan.roberts@arm.com> <20230810103332.3062143-5-ryan.roberts@arm.com> <29099099-7ef2-45cb-bab7-455f58de47d1@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29099099-7ef2-45cb-bab7-455f58de47d1@arm.com> X-Rspamd-Queue-Id: CD2404000C X-Rspam-User: X-Stat-Signature: 86h75xbyubuece7pxiw4q4f8jg6r1dg1 X-Rspamd-Server: rspam01 X-HE-Tag: 1693318787-820121 X-HE-Meta: U2FsdGVkX1+Cq3Sc3b/n/P7e3GPytDSIDLojRuKsPOa/UJXmd52zEPBLf8BtnK4qlsNnJSc4NmzZfTg+eWcWCxVbs89Dc4/5PVo9/UpHVYcqoMf6NjvVre9w0N7+al4ZvXxAX2/JiMPnn+1ztUmeG3DkWtYJhKeuoURIxnTFQl7jc+uTTJCej2oNCO99o/t9wPE+Yfqb68uKJmRwdDlMK26l7QwxAw6zISIFh/ZZxoeACM776Z3Uw7TPTY2gDTS5bBKpRCxT+EKpL10afRxQm+52DW1ZmEbJa3UOI0stUVnfIGF725HgJ1YrvtbDrNxrb8deM00knjZhseD5lrSzJbOmT3H4OlXCOqnm3tZGPv5kaXLW6hAOfCCT0I+p6Lb3jz8lwLGsKEbk2DLQ8ZFTtfmNfs54RjYc3RR8VuDZHmmx8Q4XcYcmIiIgZdUqp/xscJhh+EuQX3YAp0nESgnIFSpPevAiZdnL2YXj/H7rz4OQX+DH0X3tkKvsXiXr1dJ98Pc7dVjrjIrRAT7fV2/9LTeTlpTTj6T9S+L0UTJRagCnEjVbLoleKinVM5G6rWWTWWseDJBsgY/s2oIe07gsdidEcn+0YGFhlCbqH7oTdhC1SLaly5zpacXA8IJLDpE80916zB1xo5bA5R1ld1iI1KSNIqH93P5+9avS+DZ5+g9K3WqALnHARaPdYyEUWcA9cTkC3ZbsjvfzBbYUM52KMZuzYBZHcgS3N0ZPTCUYgx26niPWVy9bDNpuSOsACN3m4phtBhmjnrzOABbPFaTxgRW185IOW7zpbjbggpRCRBbqLPaVglzfxwP/JLU/nKHlzJn92rJwQDBopvkMhigGKyA1mauEHuhUlKQtc5SbiYohdjJHYWNHfKP4jLrpLwTxT/McvjCzUerX60nq5gZ9wNW2KE5snDMVs5ZFgIzLtS/G2R67NOwc3dIMLV411FJTa0BB9OCgS7Yn8GE9AqC bmKDmdkG Jy29xC85bpo+q8rFpeAdzqNeEPNtMrV60mlEJ9wlMT0ezIvFHlesOLzSbx7PnX1qvpmGCL9UXNaf1js/UoDysI9jv/lLhIwlqhVm8KU514HvrPeWTqaDDhRjvdP8MgUrbHRPwc0OXrphHOVlmNLO/nQSgjCpr17dnkxfJc3lBaY/qYum4gMxCSH43uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 03:02:22PM +0100, Ryan Roberts wrote: > >> + if (put_devmap_managed_page(&folio->page)) > >> + continue; > >> + if (folio_put_testzero(folio)) > > > > We're only putting one ref for the zone_device folios? Surely > > this should be ref_sub_and_test like below? > > Good point. This function is originally a copy/paste of release_pages(), and I > obviously missed this. In fact, looking at it again today, I think I'll factor > out the vast majority into a common helper, since I'm currently duplicating a > whole bunch here. > > In practice I think all devmap folios will be small today though? So while I > agree I need to fix this, I think in practice it will currently do the right thing? I think the devdax code uses 2MB folios. > > You'll be glad to know I've factored out a nice little helper for that. > > OK, what's it called? This is just copied from release_pages() at the moment. > Happy to use your helper in the refactored common helper. I'll send out those patches today.