From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C18B5C83F14 for ; Wed, 30 Aug 2023 09:33:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3953B8E004D; Wed, 30 Aug 2023 05:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 346108E0009; Wed, 30 Aug 2023 05:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20D668E004D; Wed, 30 Aug 2023 05:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FEE08E0009 for ; Wed, 30 Aug 2023 05:33:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC877A0369 for ; Wed, 30 Aug 2023 09:33:03 +0000 (UTC) X-FDA: 81180257046.06.6CB9AFF Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 9ECF440022 for ; Wed, 30 Aug 2023 09:33:01 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=wn33VWvr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693387981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/pN5Sj2lXQgLLmHsNhZTE0RFeJiDl6tBaSGS7xws0g=; b=yLJVAjF9ThzwQg8kHEhftsN5Locr37TcAHONYeSvIxJszaeX23dqhnZrWcCgBh0LBrJS+t YYpWp9vK3Q+tiYYSecy8FPidiipKuIAXCJ74ZHzD30m1Em+138/zMpyu2FHVp0fo0Wjqhc pTsT5V71eYjf1KI4JBhAisYDnbew9dg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=wn33VWvr; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693387981; a=rsa-sha256; cv=none; b=YPHZ1dibLmqyG/9vM2iYduPB7a3LKmAUlufKBvQjYeSDZpaESpYene/NMTTUDvG2w7Kyf+ X3Q79P2LfnMD5ilBtXLm/SmTFy5XJIF4NyjY61Z782giDABRtHFHJ9zBDibFOTqJtgm3BZ 0vzJdjtUIaQaC1c7cdryRlPqQGTm5pI= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so48213115e9.2 for ; Wed, 30 Aug 2023 02:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693387980; x=1693992780; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1/pN5Sj2lXQgLLmHsNhZTE0RFeJiDl6tBaSGS7xws0g=; b=wn33VWvrVXMNdw3y4Ih+sgMfD7Gklo+ULUK4ooM3QEPU5vlJSvpz9wfaWnfLJLyv/g em9NmzEryJn3gKVUxR4gAFb25P60CbW/iMQwtDG09TIP90Ly2VXiDLLn9HUm1c9PzkHy cs5kh1yx/leEqkjeh7wfBiMQNJRVKBqwYKpPOBbCS0fgcfBeuyq7LQ1WXEv0iUXNwhac yrs6B0qOuvxuDWjopBa4Fzb4zEQo7hs2ophVAGjqI1QuYQV0t6W0cY+v9mqh2csWn9PE RwhoZ4ljSL8Rkzc9rNXAnGn2MC57nynKFYf3X2KYlLyHviZSoTciD0rJ3YWUTuqLiudr A0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693387980; x=1693992780; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1/pN5Sj2lXQgLLmHsNhZTE0RFeJiDl6tBaSGS7xws0g=; b=H1N5I/BwSNdNNwdZeHqgiiobqlVZOUQeqU9GGeRW38dhy0SeSYTfq5z26NiMvO2n36 s3s+FXQcCjRlV18PjlGlknyqrsM95uq/lflAJNsJkHffOXN23R5eug6JwFkvz/hEMTLZ w1skZ8nCsjyLKWSCfdQnv6X/qcKCewXLKHbpeD17/rslzTo2h4+XJJZfakS8avOqzSKv h/0tSj92BeGY/jFFTpjd+lhPm3zgELRTDZH3xJ3BI/AIrexh9Muc3/f+cRlHZkbVXgmP rx8u8B/F5D7hv61TpjugUjd9f4Xpj0lwI8L/VcHC93QzEH2LkDs9Cy7HbTCfENaYgY3E vUFg== X-Gm-Message-State: AOJu0YzRHkaG+vrx2buqZXCWGyKND+MPixaS5/DF+JMlTLC5Cg9nU4SE 496Dq5y21AqUACZHP7Ym9kQ/8g== X-Google-Smtp-Source: AGHT+IH+QVH/eBfvEpQp78cWzC0C2VRwqkKX01uSV/Po75AljOi0NmK2kL/E5Yu0gp+Jvbv7DSfigQ== X-Received: by 2002:a1c:7217:0:b0:401:b53e:6c57 with SMTP id n23-20020a1c7217000000b00401b53e6c57mr1358749wmc.9.1693387979964; Wed, 30 Aug 2023 02:32:59 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:3380:af04:1905:46a]) by smtp.gmail.com with ESMTPSA id m18-20020a7bce12000000b00401dc20a070sm1668612wmc.43.2023.08.30.02.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Aug 2023 02:32:59 -0700 (PDT) Date: Wed, 30 Aug 2023 11:32:53 +0200 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 12/15] stackdepot: add refcount for records Message-ID: References: <306aeddcd3c01f432d308043c382669e5f63b395.1693328501.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <306aeddcd3c01f432d308043c382669e5f63b395.1693328501.git.andreyknvl@google.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Rspamd-Queue-Id: 9ECF440022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oroks63b8hc17yi34b3m3hton3kgsgiy X-HE-Tag: 1693387981-611055 X-HE-Meta: U2FsdGVkX1/WLzit5iywMlY39gBHIDVHRtPb1aR9kcqEVevHleB3MHPZqqzIH+nJ8o6yLJEcx/px+RNsfAs5TyOq0ug4WY1z7VchJPuWhW40f2g81vMyouaYci8uB0eMdI44T4rVKux6jnrD9ZTROWGroAk1dfsvL6XIhzGmas6GR544eVLCPZBm15yiBdBIze8xcSHopZg+ieJeAg5KolLBieNsx9nqhypmosAOxxHMRXhUocAEHlOC3bBJalPjEEeKowvRlIZe67nNYOu0/IUYn55h917ZOXAI1cGmutBhReeUJSKNnESmCzGK2rbcobVVipIcRjKRbrxfEYtSWkizdd0NTHFGAsuTWtlReZRRa4Jm1ao1bYXMUrVwL1B33aE2WZD6QHMGF2tawBCVVKw71WTGfwtqdSBrInAEetKJI31eRQF+OBItFtcwWUJG2ZYfUy8AD+gSy3fJ/dHIQB8poJa0W3muwDpd9uHDn10X8iJrGy3DlLLsE8udL7imlgOs/I2dcyyssJx88QY8K4ykM0ram5/WwNU8CJPVjx5Y5ZX8g2PfyPrT5Tgm4feZjv2pPQc2rPzZQ6i9qGhqFfLerCxvdV+vczDgIelCojdedQJr32rK2JhINJV0kzJTREBlssI1UOG85DRM+nsdGFX6/U6gDbcNe6Y5kz8mRFZQnAzfkMJGWhalPaUQgs5F6JHQDtutc9o585DF3b1fBvpmkKXibEqk/ECeKhQGE/DF0gRO0I+7fK9QzIvjxaEzsCIBKaxHAFEcVwOMl0Rr/EFIYEPjOvocbNf1CcJaFlxtwQA0BljNjspZnwCyip8/GRPaHodoKt8WJQ/hXLNyrxn0XSco1ObcjeYV1ZyZqQU/PqUpdqNIHkGOXivHmjN14OgKkR160UpbKmFDZm023lLZ7rrYojlJSuQM7Svtm8XOprOdmeYgHbXwBrduUD0pvPzf0lzDzL5mFVzwlP0 ouENpD9J 5oxkll+fjfAKVbA29LGyVEjwZSzoqwJ/9J84NVpdnh6il0inx4jQk3YNQ0fRdO5rj6f5QkACxp3AsxXmc6LO7U77z/IlD8P5ioUKT+oz7yt5tEYoremwW5jtbKP8YDea2tInE36mLQem0GZu31xTs/6zwMw0zSZUL2dzRan9LItV88ZC6XHdqXzPNJYttJ7eM3WpTGC42Iye5m4GjtQV/JhC53Qq8mvusjhOrWlEG+XAJni3orqxN/D20zX97Lzhc/47uTouweVMDrPu3wQPQx8V9EeTQ7LIEmeJmLL209VSvbUZInZpVWqotjO++P/tWTPeL1de9ozayfHC9jCSJIPYXNeAPuwJnS+2z69TshWYC2wzNUREtiLfOHiHZudXL3Hc1Q+DBlLgfthMmVZR+IpGKJgkk18h1Odk2NgWO3S/D3x8lV2Qb4HdQLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 29, 2023 at 07:11PM +0200, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Add a reference counter for how many times a stack records has been added > to stack depot. > > Do no yet decrement the refcount, this is implemented in one of the > following patches. > > This is preparatory patch for implementing the eviction of stack records > from the stack depot. > > Signed-off-by: Andrey Konovalov > --- > lib/stackdepot.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 5ad454367379..a84c0debbb9e 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -60,6 +61,7 @@ struct stack_record { > u32 hash; /* Hash in hash table */ > u32 size; /* Number of stored frames */ > union handle_parts handle; > + refcount_t count; > unsigned long entries[DEPOT_STACK_MAX_FRAMES]; /* Frames */ > }; > > @@ -348,6 +350,7 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) > stack->hash = hash; > stack->size = size; > /* stack->handle is already filled in by depot_init_pool. */ > + refcount_set(&stack->count, 1); > memcpy(stack->entries, entries, flex_array_size(stack, entries, size)); > > /* > @@ -452,6 +455,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries, > /* Fast path: look the stack trace up without full locking. */ > found = find_stack(*bucket, entries, nr_entries, hash); > if (found) { > + refcount_inc(&found->count); If someone doesn't use stack_depot_evict(), and the refcount eventually overflows, it'll do a WARN (per refcount_warn_saturate()). I think the interface needs to be different: stack_depot_get(): increments refcount (could be inline if just wrapper around refcount_inc()) stack_depot_put(): what stack_depot_evict() currently does Then it's clear that if someone uses either stack_depot_get() or _put() that these need to be balanced. Not using either will result in the old behaviour of never evicting an entry. > read_unlock_irqrestore(&pool_rwlock, flags); > goto exit; > } > -- > 2.25.1 >