From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E4AC3DA66 for ; Thu, 24 Aug 2023 01:10:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D522800A0; Wed, 23 Aug 2023 21:10:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A62D28009E; Wed, 23 Aug 2023 21:10:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2471F2800A0; Wed, 23 Aug 2023 21:10:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12B5128009E for ; Wed, 23 Aug 2023 21:10:43 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D793FB1886 for ; Thu, 24 Aug 2023 01:10:42 +0000 (UTC) X-FDA: 81157218324.21.9A4EA72 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 42656C0009 for ; Thu, 24 Aug 2023 01:10:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LxM61d52; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692839441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U1J7EBDmZ437WQyjyis50TgdnETeFOOr5O/yd8dVWkk=; b=gF4Lmb8Inz7jCm0r4M7U4fS4sokq0kKqrH40iQuupNXIWYryVHKrG4LvnHMX3tjkFt+PSF y8EpN51P6/+o53NSX0rGoT6jQF2hXozgh2PUNbpX80+PP8jHdXxR0EgzlyWC9zrQ94ory5 ND/ex495b6vKubOgYSysyMoMZgxKnXc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692839441; a=rsa-sha256; cv=none; b=J2M8xksUj6lVLPjKJ4hUzPeYwRWE4KHc0dkRnqJymA39eAHRPJB9VKOR6jc+fw9yOum//r 0Y/dB3okoEkj9eX6qfFAQYSJfdMa8OQA3IJfRNcDObp0MWT9ErBJ51+v5F5OzqS/NbUyIL gFaZEzr5XwNhZEYIzGkM81frWgZ2Bik= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LxM61d52; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=U1J7EBDmZ437WQyjyis50TgdnETeFOOr5O/yd8dVWkk=; b=LxM61d52DCHOcfbWVud0IgEo7g HlppaWOqSx8FiSvNsHwOdmAZZF2Pt3uORyqeuUqKhgU8jsSR+V9YJubJhwuj2BZKsNBPHjWarkTyu 8P3M21V+xOZr57cYiziAK6jBPJ4E0aifCULZCNbl/9ToWyQT6g78PYZaEo/jmq0fBKRpyd2noXaZ2 Mz07nOZl+RG4V1YyOLfxu0NPWox+FJ8bncSs769IlplUH6HbsBYRTbAbH90crimEbj2H6MI0Gmqym +nhi1HYpM6dJBcRVIcPjYY4YwQVKQvtluPsPF8woosWHFbaCpIjRU2gk5NZCepUSrR7ntR3tHrCXb MoiGQ0sA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qYyrn-0081MF-Cu; Thu, 24 Aug 2023 01:10:31 +0000 Date: Thu, 24 Aug 2023 02:10:31 +0100 From: Matthew Wilcox To: Mike Kravetz Cc: Muchun Song , linux-mm@kvack.org, Sidhartha Kumar Subject: Re: [PATCH 3/3] hugetlb: Convert remove_pool_huge_page() to return a folio Message-ID: References: <20230822162808.4131399-1-willy@infradead.org> <20230822162808.4131399-3-willy@infradead.org> <20230823224813.GH50463@monkey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230823224813.GH50463@monkey> X-Rspamd-Queue-Id: 42656C0009 X-Rspam-User: X-Stat-Signature: h1hxw9bktfy35imwzkpacoxmbzochwpf X-Rspamd-Server: rspam03 X-HE-Tag: 1692839440-138306 X-HE-Meta: U2FsdGVkX19dbhmH3sOA7vzUlAEV2t5Rads/X8PXcuTjAlp/7+Ira+/g+8uOjh98tz6kACqufHakAeG8O+DksaNVbDyHN6tpv3Yd4hzr0BOQ/uFKJaXvcuEYThPc+cd7N4Asp+5vDsEjqq8pmgl8GTvmY11FzMg3D6KRU0LFkWkCPySIfUX9mxXRptNSFE2R5ubf2I8A75xORAXiZ6vTisq814/WzT4PNfnomFaacY6P102aY2cfldARBgYZPAvzyyKLfA4bBXQO9irC92gZ5hwh6avl2Iy5Sj6o36DWu5foUKkJmM9cjt5Mb8LBGcTt33MPSL+Nt7y1r20QOgz1vcu/JOHpDpILStemTytwT57GhLMmt1e+88P8E8GrklvrYTKKVWIbb1NSJw++NXsK9erGaTMy5Xi0WL1bsT8YZPHWIvQZNbN0g6K51fqFP4t7+mJ4BIA7rMQ1vPrQZAuRSjm9dypelfxsKvotRRucKkmQeSFgByUPVxDl2B6vIv4UG47TGEsJr1/CaLRCIiFd9Y/MNwSvUwWeKWBx5NDK1U9S2xd5H2mbOreDzazPpIEqhzQYjQXE2gLT21TZoqxmHH1XSFhwWKXIa8ETKINmvYbkkmNSeoYlvkwWz4bGA0N0RElO0oaAyDtoM1o8jMRNHVGMFwDDdmsR82Mc/Ay1LakUREqsqkH6P0I6ANYPs8aiak+RilksnfR1MR8ayE69xCrv2pfpMRVKq6mM9jdPl2NRFTtUV1Q8YJsUsHDaA8kRDkYIrSRQsIbGW6BP1ZVrTsQEakeKzq+TP+IGtKRzE+etvBAD1tdL4yhtZ63xpwMeVPpzSEFUZvsr5ks56wc0aZWM37Phy/Gb5DNu6WZN1LdgWBOsIN8uyQFwxLY2mzBkW1skfrYjJNCZDihSIDKC/kBbzicYPNIYvr40N1eqKDgdwpzp6swELaToZuqWViZOFqkf1nj0hwbzmgi5mAk 3qpOQjtF LY+roIsMZbkbi5hdB1Bd1NdvXJviuBksNNxTDI6Lqk+F/5A49mKSJH7w9osZ9bcBy+yVuaHHVZGwTy6xv98M3xgjORWuU6N7fBnRYYvnole/cUTu/mT0i4k4/GI4CtUX6jevuHb378WArac/R/BhNYxTPQfln6xhRhT+B5OZ/D0rKc+VgwsJ3sSRn1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 23, 2023 at 03:48:13PM -0700, Mike Kravetz wrote: > > -static struct page *remove_pool_huge_page(struct hstate *h, > > - nodemask_t *nodes_allowed, > > - bool acct_surplus) > > +static struct folio *remove_pool_huge_page(struct hstate *h, > > + nodemask_t *nodes_allowed, bool acct_surplus) > > might have been good to make a simple name change to remove_pool_huge_folio, > but not insisting. I wasn't sure what we were calling it now. I can go for huge_folio.