From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C1DC83F11 for ; Sun, 27 Aug 2023 21:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6B6228000E; Sun, 27 Aug 2023 17:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B928E0001; Sun, 27 Aug 2023 17:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE4C228000E; Sun, 27 Aug 2023 17:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AD2318E0001 for ; Sun, 27 Aug 2023 17:32:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6255FC01D8 for ; Sun, 27 Aug 2023 21:32:57 +0000 (UTC) X-FDA: 81171184794.13.774178A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id A71F81C0011 for ; Sun, 27 Aug 2023 21:32:55 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vTYL9F6n; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693171975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/6hpsLsV03ieW4vELbhOk4pxiCIUuyn6Bpw1V8QuWjA=; b=3rtK3HZIB3maMEkPw6bZVg4p9w095S+r+0mIPXh+jpAw3/BEzSX4kNgzLnanBpsnqwt7GO vuC3LSeh+2P6GdtBFusn3yi/gpstFdKSCdd6IiqToe6Ub4kqJkO+9ghG6OgCunruYK8RB7 HAQqzmbkPXbBmt3cavqEPd2JIWgruaM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vTYL9F6n; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693171975; a=rsa-sha256; cv=none; b=AuWlbPvTjqtaj3gfWbzxyoQydUyIl+iAOziRRBmXf4ynLM5euup+k5VaQFpInoBHbYB35Q 4O5LOLF1rGlyxFTB2HvwIQxEK6EbOHqk5ovwCWKN+mletgSUbxmc6yM5EUVGCrbsm/MTqs Z1ZmT2QvZ2WlKEKGaWZJCrPrQ1L6VSI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/6hpsLsV03ieW4vELbhOk4pxiCIUuyn6Bpw1V8QuWjA=; b=vTYL9F6nmyMC1z4vgUQ57UMuze c8bgt9vFOKWzPspRsbeTFLgLHz/hKRnLtd9UWTyKshqJF7eN4C3F+EMjcufK9pmtU6JnMc8dQv1Vt 5InC4HIkUznFa/hnNRczUUX7xHbrfZD4svYR9Kg0wslB46dSko8l2iAdkLRH/H5iWuiyt8iN5XazN QityxWl2yb3p6DSle3T84m2jiGMPG15FtuhdmZtjHlUbcKD8n1NBcGDOexBbj8JBeLDTA1BEKmInL 888FPoRnfrZ00U1GiFcxw/e4IZGsn0ijlmA9d45AXC5VifFlQ9hZQtQ/XxGEdq6/5qdn+lFw1Ut3Y +YmC6jBQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qaNMq-00DvXM-Sy; Sun, 27 Aug 2023 21:32:21 +0000 Date: Sun, 27 Aug 2023 22:32:20 +0100 From: Matthew Wilcox To: Hao Xu Cc: io-uring@vger.kernel.org, Jens Axboe , Dominique Martinet , Pavel Begunkov , Christian Brauner , Alexander Viro , Stefan Roesch , Clay Harris , Dave Chinner , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cachefs@redhat.com, ecryptfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-nilfs@vger.kernel.org, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, Wanpeng Li Subject: Re: [PATCH 07/11] vfs: add nowait parameter for file_accessed() Message-ID: References: <20230827132835.1373581-1-hao.xu@linux.dev> <20230827132835.1373581-8-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230827132835.1373581-8-hao.xu@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A71F81C0011 X-Stat-Signature: zn8me3oajnw1zcuatou8rbgw4f4os7hf X-HE-Tag: 1693171975-461997 X-HE-Meta: U2FsdGVkX18yCfMgdpJNOLVucReW0crisfd/6ciftjozYRh0jHSlBZbdeThk2AEZhQmFjb6XY7b2NVPWMdU7RfAbcl7FgY9mv2+XsCGz4MXKNoSNOQCvHzI9LdVca/8rzn2/ErQMzT98Ski9zcjCf5nGYrYSm9GxpUJqTP7RI2/1ePe1HZOt5b0wYZBontIJ3eYP6xBKdUMs6vm8h9w/4tz9Q2Ne6AIX5aRANsj2C4R3E5j/oItYUeyhksjh1fEo35VL33dQw8xXloRK2v9Du0rlML+7o8MbDgtJxlrGbRq7M6PE+smRaK2lssCm78uzdwGQcH86TgOb1M/1hF/U/iSgKdVQwbRm3eZf0XfYjNq/h+4QIHbSbEZCJ3VW1Kc1vkMLoLD6IdIs9kW9uuXYkK8TY0YycgVv3edKG96DY2jqfjH8HVK/Kra6aB+v7za41ZwBwIQgQ4CcKJXynQqcm04173q7jzbExKG7knn4SZseb2+IBolU+e0thqkeUslS/VJaoQ3CkR9DHya51/eQTzneuQ/eVzUy3AOrMxQWip/H/+WpuoiHgI4wBh+AESBFONFQtOjKI16jGGjm3Ok/MJnydXNnlBGnVRPy8KB8QXB+0KCjpNIXcxnc+l5sivj+mUDyQomato9lNmNHAq9IYCUzS1oVAtYZnanbYXBa2k6bHj9VpQs45raowO0KqIV74q3Mi26KftQU9EsFYeGdxhVi5eQuZH4P2aqpTFRRXzK6Uhbd1K6iwZRYb8e0/fxvmTWn5/8H3ZDw5TEEtSrzu/G+DS4q+mclwrx5h4a31o73SpotJTIB+LmRT95NFzjxwLJbzSub4D+Dha5qIfPVVgTJIZCS1C6jfrnaBRQSKCSpnvz0v8RegjRYVyGR0ldqBYGXkr14jcHW35PrvwjTB3DMDQV702dEFagtpclMUg8e5SmrW4h7U/shO+VRBeEvaTsZ8t5egUu9601nXf6 Dtp22N8Q 8nJOrtRRviMJNrv+oyehuhoAE3JFeZmDccB45MOBsgPkG3t7sIvNLu/fKzrZcVXLey74WISsg+cQjF6M1+sfr6C9iC7Abs2ydRKnru4pMOf5BjCwdl0M712XfDs4mgjJBRGqdKSGh21NKH96JqRSvXUEdCNmpmbDfARWAPOPH9dwHbWovHDNTBP8ITy1IfiKB5/r6FOCiNNg363r4Q79wvh+3mJozPBF9S3CFv60ECC6Z59AnfK/InQOEwSlM/iPwSkmBGMsi+UQuT8hTDEpXzvBfESBAc4J7H3x+pvXlf9Ed5Znmv7qiDKER/nh3TmVcV0Yr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 09:28:31PM +0800, Hao Xu wrote: > From: Hao Xu > > Add a boolean parameter for file_accessed() to support nowait semantics. > Currently it is true only with io_uring as its initial caller. So why do we need to do this as part of this series? Apparently it hasn't caused any problems for filemap_read(). > +++ b/mm/filemap.c > @@ -2723,7 +2723,7 @@ ssize_t filemap_read(struct kiocb *iocb, struct iov_iter *iter, > folio_batch_init(&fbatch); > } while (iov_iter_count(iter) && iocb->ki_pos < isize && !error); > > - file_accessed(filp); > + file_accessed(filp, false); > > return already_read ? already_read : error; > } > @@ -2809,7 +2809,7 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter) > retval = kiocb_write_and_wait(iocb, count); > if (retval < 0) > return retval; > - file_accessed(file); > + file_accessed(file, false); > > retval = mapping->a_ops->direct_IO(iocb, iter); > if (retval >= 0) { > @@ -2978,7 +2978,7 @@ ssize_t filemap_splice_read(struct file *in, loff_t *ppos, > > out: > folio_batch_release(&fbatch); > - file_accessed(in); > + file_accessed(in, false); > > return total_spliced ? total_spliced : error; > }