From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 789B0C71153 for ; Mon, 28 Aug 2023 06:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DBAD280010; Mon, 28 Aug 2023 02:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68C078E0001; Mon, 28 Aug 2023 02:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54122280010; Mon, 28 Aug 2023 02:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 42BD48E000E for ; Mon, 28 Aug 2023 02:37:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1432212010B for ; Mon, 28 Aug 2023 06:37:01 +0000 (UTC) X-FDA: 81172555842.29.A1CDFEA Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 6B3D3180006; Mon, 28 Aug 2023 06:36:57 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NcopADFc; spf=none (imf06.hostedemail.com: domain of BATV+b83d16e5cd0c301f07e4+7309+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b83d16e5cd0c301f07e4+7309+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693204619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xtken3ztdTUny1OMfzFaKlaMxo854CajVDA38Kiekk=; b=ja3+QIMLaX13h412AkvrPf9iMSM2UVt0AmdFXxc/yHa3waErWz/UEbQUD3Z8x/IQhMfp3t ogZtLss79anx31/IXamvi0BWvay3ORP8Htg943u+vivLEdJtiaCxGndttPt4BeMYbuhuGK SDRsNcBr5/eMINVXwdakNCPMv14ivW0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693204619; a=rsa-sha256; cv=none; b=IrRbdpcagL0AJflB3vRbO1E1b/ZHWN9Sr3H1tHrzp2kZ+lDLtBNtQtKv/ShC8zAaYfXXTE S905bUwf29v+DhIV2mAEYnZXcJZq43oBBInnRU7JhFyZXhiBmdfv7sShkGvmOt+vKqttTP Fs10w6NLujL05bgSPpqhIYJGlIz5je8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NcopADFc; spf=none (imf06.hostedemail.com: domain of BATV+b83d16e5cd0c301f07e4+7309+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b83d16e5cd0c301f07e4+7309+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5xtken3ztdTUny1OMfzFaKlaMxo854CajVDA38Kiekk=; b=NcopADFc2/ECJJnc4sPTJV2HCs oucoi3FqWUgmmWL2TBAkAp6f5/UWWSPbYwMK2t1FmNf9DCFana51kICNmLtKkXJ761PmFHB0kIciE tDPU+fPlvqzYN8rAM/mSYi0biQaE2nJXWR4/LhXs6sXOwn+rDi85UgDnSeFEYvprxuyB0OJDS3X7o v2xpNI5oF0c/7+f4qUhZDe9jzBoCkqp/fWoSoiT+ozzUuABOWCY4mt+L1Go7qVWjjcWLM8JX/eIsZ 5tjE66X7sfMtVGm7PjjSjRMkHZipPHTZVAj/5fkfJ06RMhfPBT227rR2yLfmee/6rVsL/f24aLc1t 55V7kRVw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qaVri-008xc2-1x; Mon, 28 Aug 2023 06:36:46 +0000 Date: Sun, 27 Aug 2023 23:36:46 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Jan Kara , Xueshi Hu , dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, jayalk@intworks.biz, daniel@ffwll.ch, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, djwong@kernel.org, akpm@linux-foundation.org, hughd@google.com, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] fs: clean up usage of noop_dirty_folio Message-ID: References: <20230819124225.1703147-1-xueshi.hu@smartx.com> <20230821111643.5vxtktznjqk42cak@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 1x4k31efidjd6pr8qg6pzssmze6us3tj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6B3D3180006 X-Rspam-User: X-HE-Tag: 1693204617-201566 X-HE-Meta: U2FsdGVkX18LiAOufmRA0ryGT+9xc4qwwqTsAb/fPfELvJpuRYn7Jz/lEbtNUL3+GzTbPZltU6B3oVZ+QfigH+LOfAbNjolJ3RuB/9ZdIF0USrH+xLmXEeOC4x2bdyrgGWTBZisi9SoxLKBy7ld+K5ml8JcirqkPhXIk/FT0llcIqhq5oCIzSyMs+qZj38tPxBageb+BErdLBbxoG9wlM8ozbnIJgcKgMtYG4iGB63zgZ3aQMCXzxiFbu7RluVUZjF8PQxyJjlJ577QJkLOEibZuW5ujHKy8N2miDoLyJ93rx5E550qi5KpAF5e/hMFGCslh+kT5G1xh1nfd89OwIT8Lo4u41F+kSwvkV/4OvGrE/cOF4XkzPvjbSln5su06UspsVXBoqiAYNZf/szaVO1CbpJuObtvaPiAqmMSE+QKdnziqBEV6yGodsbcsKMmFUMmiZdGUBMtHVHigqULmInvYxcClIbktB5+F3Ndknvqo1RfEH/pFC4hc3ustmWPZ1o/egxKCGctNCyXUyPTh126pRzg/YthF8c5kZU3Of8+W1poKb1Y1ryzlwbwZl80FbGN0BZXzL4LC/VuIRJ+JPavtWqkE/qQ2ZY8RMG8SVRqWG2gmLqYvrlAjXCDd3imxxHGqPkfr23yDG0rKPJAUADF7mLnaGuXb0gZZaBC0RM43N6UiofCDayBZD3OlGMISq166NYZHICoEvikrhhpvPsO6BVCtENbDErQuimOjPBMbYaZHnqgBiqpjcl5x1+J0QO9W+dWaaM4chZhPIVvhexxgo4lLpDg6NruompaxJfOpnfb3O+tI9/GMrT07wmbnNb6EuV9nL9waZnEfI7nywjIwNXgsfBD/FEv00ry2TSVQSwpOHyf8UpUkgaB0V7/dQKQc37beQpLbpUU4uu5DZ2vy+COPy6wcRGbvtkXxtsnhI0LMabEIQ4EzmwtLJnlnVnBK1mSudU1MBbx3obm G1i33i7q Pc/MpoK3x5QvgB5rGYloMN6CWwRD7k1j6O1/lEMYvXM2EKWCEHjw1nmP1OS4AQifRtjkJDvDcjiGjf+E3DQxIuJilwqXOEKef57CkYoynO57BMvlBEUFKgWgJxCgNLgpTVmawdU+wAJbsd87pcNCht4zAP2Dh+mT0ncLp8M0Whj/4xe/yAC+aexQtHDyisqgHFKTNZVA0Icbkzp3s/W6oquG4gXNnJ/zrpUTi9ssrGZ6aUMD/q2mdqoGwsDyg/rD59WkXl084vYDEy+Fwx9GHg3IV8ee1ZD5T/3xx5dhagzRylQ0RhDxYS6z7coVrHxqLLwa6sYrZeNh1aasvy6qA3ByusKWnrZTYbUJHxhUKQaOO6AU2JoXlOPEhwzVHqGXn4pd1KvqX5d4GDQ9aOJz8HUTE9A27wOudksRW9J50cpFQaPAtp1AJs3sXtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 01:20:33PM +0100, Matthew Wilcox wrote: > I was hoping Christoph would weigh in ;-) I don't have a strong I've enjoyed 2 weeks of almost uninterrupted vacation. I agree with this patch and also your incremental improvements.