From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2446CCF9E9 for ; Wed, 6 Sep 2023 00:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44242900012; Tue, 5 Sep 2023 20:49:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F25B8E0014; Tue, 5 Sep 2023 20:49:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E09C900012; Tue, 5 Sep 2023 20:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E5628E0014 for ; Tue, 5 Sep 2023 20:49:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0491C0B7B for ; Wed, 6 Sep 2023 00:49:05 +0000 (UTC) X-FDA: 81204338250.03.156B117 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 5FC9C1C0005 for ; Wed, 6 Sep 2023 00:49:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EflQnnTC; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693961343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I5z10LnLWSXAHPqe7mz8C6zD93RhuMzewKOg+qlq2WQ=; b=0EafBbcD0a5qcX7QM1sOQ1763WSckgd0FP7eTokfniymBJ3Uo3RtOFMLeAQlfd4/xucntD D3hA+Xy0Kz103BppeI3TmNOcEnP6A9CmHqVgfyFO+4MQm8XBzbr69l1N3PeFti7/LzStID iqLFkkdZZwkTqSKaLI6/eJ/Epqm916A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EflQnnTC; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693961343; a=rsa-sha256; cv=none; b=IErCU5oDkRVwM6yG88tpLoNRJH6Q9xDGxtiCqjMKxFQyAK/PF2XVhp9xjBcLxzR/Dezd7C JAzrcaFGXzugUqnb1Bd+9pvu1+2uEGgR6D/BFFACc3zblXboK43aMrEkR3WAgmGdKECE9L VEpxaoygHnTUFRejLIP3o0GSo0mfl+s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=I5z10LnLWSXAHPqe7mz8C6zD93RhuMzewKOg+qlq2WQ=; b=EflQnnTC1wk0PT/HVjR2GU2oUt BK1bETdOUojcH9S+JKWOronEzzK8U6dJ8ad18XhZYzV9P73J/8Rwn05gzKurMAH532fJiGUr+KlkS eHj4tzjDP/u+cgemcOiQp7GZradrJNeZr2jj0QpKXMfnlRvF+zc+28O79pAuPv1mQwlFCrcZvmW/a MmJ2KpstyduM1WuiMiXp74ZQ1nPhz+2liGyY5wjM15oUeq4w2pOQfz8zwSx8hySdri3ac+eoGhvld OZGRxQnYbharvNn2T4GT5czXK7xMXXuHX/DSrM8kkRg3fZdVI4nXa6qTsq2XwtTkyeWmRkMahkEnE C7dF7pJg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qdgj0-00F5yq-OT; Wed, 06 Sep 2023 00:48:54 +0000 Date: Wed, 6 Sep 2023 01:48:54 +0100 From: Matthew Wilcox To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song , Michal Hocko , Xiongchun Duan , Andrew Morton Subject: Re: [PATCH v2 01/11] hugetlb: set hugetlb page flag before optimizing vmemmap Message-ID: References: <20230905214412.89152-1-mike.kravetz@oracle.com> <20230905214412.89152-2-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230905214412.89152-2-mike.kravetz@oracle.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5FC9C1C0005 X-Stat-Signature: jy9ffd41prfgu3e49sr543ofhooid9tj X-Rspam-User: X-HE-Tag: 1693961343-834064 X-HE-Meta: U2FsdGVkX18gwJH6uqXh7733DKhJGW7dSGuCCpumFLAgijRDtYdAscjxEnC0NtBoyA5S/MR4yjACpF9bkNBkQdIRZedx1+nwvQqN5UO956npNpZdiCrxGRqwajbucAwL4bnKmEDbyI1UV+xhkqVRg1P6ei1kT8516C9XSlgfuNdFj5g2wYWXvHziQf9iAyzD3mmiiJC70N6FgbHFtuZL1VvklCvUQdn/NZFXumRVgCsEjAw3w6reESPvdwVo8eri0ed4l9IKibLgBSY2qErNRZF5cYU8i8/XRLsTIlHPj3ih6qQGWBrNBX7a36skUeaIsXxXxNiTK8vPOGLOUQgfFXpzUL7izsgYWiibcqio04IayKQSuSSAQAA6PNhn14od8LFbhjuceA9paVZigoatRaP8aYn5EactWE37tOcZeFXjZISlKxFhMhaEo8iz5XpGKD4DVsTLBhVTZoXfTJIB0KD5GKye806QqSy7zevFmyqZ0Qivy+Ivf3NwYKLH0V2Wz4aSPcOe5UgVw4yC60sF+XKkMfeTZey1J+wSwn6nsrSJYSEXHafbSzuI9znoLJ59Km5N14bSwdF7gjI9wyWk0jyA2MdVpc3P3NY7bEhvg4CzJHSki5mGF9/ewPCY2i/L0OJPKRfnQH82W87ubyWdu93W0v0V8YCq32Cpb9cr4eqfC6R1YuO4uilZAb93EET9nteuFbpiGbXQxVnhoifCC/R+IdwUW2GR3+XNxVmas6ST66pnd6/ThYU1vqi69j7oKjP9JvcFwNwIKWsP6lqidU3sMJId/dH+EEdNjqJIazS3HoXI/vG4m0dCmWsyZ1RK1xzMuuasMakAr9ej9UnyE0DZstIXgkuOU54WtesafReTNULLKdcxUXpxG2qqKOHfdoKfgod5a7iPsaUdrnoxUDdBdhAKV23dJh6sV+o6RrFAH8y2AzdrClOjf4+Dw6r3PQqk+g+hjURrSJUDN/X CRNxi78r uYGU3nxqDiJoAhTcsg4E6A+FI3LPKoQNt5RAF9+nqBOTN7znA5eLVUvRBlSsb8up8trYdOWMLeu849UwLyuwejxbU51tt8SDTZ2dP9ONJz7pog1mhZGs3UZYA053+S9SKA3EDYM5cCInxIXk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 05, 2023 at 02:44:00PM -0700, Mike Kravetz wrote: > @@ -456,6 +457,7 @@ int hugetlb_vmemmap_restore(const struct hstate *h, struct page *head) > unsigned long vmemmap_start = (unsigned long)head, vmemmap_end; > unsigned long vmemmap_reuse; > > + VM_WARN_ON_ONCE(!PageHuge(head)); > if (!HPageVmemmapOptimized(head)) > return 0; > > @@ -550,6 +552,7 @@ void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head) > unsigned long vmemmap_start = (unsigned long)head, vmemmap_end; > unsigned long vmemmap_reuse; > > + VM_WARN_ON_ONCE(!PageHuge(head)); > if (!vmemmap_should_optimize(h, head)) > return; Someone who's looking for an easy patch or three should convert both of these functions to take a folio instead of a page. All callers pass &folio->page. Obviously do that work on top of Mike's patch set to avoid creating more work for him.