From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9BA2EB8FAF for ; Wed, 6 Sep 2023 05:51:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34E0290001C; Wed, 6 Sep 2023 01:51:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FE4B8E0014; Wed, 6 Sep 2023 01:51:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C5E590001C; Wed, 6 Sep 2023 01:51:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0F6818E0014 for ; Wed, 6 Sep 2023 01:51:56 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D3AFE1A0C22 for ; Wed, 6 Sep 2023 05:51:55 +0000 (UTC) X-FDA: 81205101390.07.D21A0F3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 1D10E1C001B for ; Wed, 6 Sep 2023 05:51:53 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e9NGchdi; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693979514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fryIiZhy06QnkHy7STq692w/bK/pSon6VbynMKbTiPI=; b=aCdfx+ngjv9h89XxQFyiIngssoxTh++Rbzb7bX9iMRJARmRz4r5ByQ1piqO419Qd2G/1Sc ouUeJH5+6D/nEO2kW/fVV1dFzLbo1vJaliBLpRb7UwtV5WTPXRz7Tk9361bXMa+KsqxQkh ECU+0uFG1kk9eupRuEskEMmVqYv4iZ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693979514; a=rsa-sha256; cv=none; b=7qaeG0e4chG38DdvfiNEl1h9ON8UKEEhILUk5kuw5UwOde+qrURJuyvgaKbGML1qkiP1DA LTKtPpz7ZM7U5bxSxv2D0qA9SDA5Emu60GEOF/EhHC4gLjjbYoI7c7/mLq4vxuUX4j03Ov M+fLkWdp2vefXiAnuMPZGM+tfG0jymA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e9NGchdi; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693979513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fryIiZhy06QnkHy7STq692w/bK/pSon6VbynMKbTiPI=; b=e9NGchdiFarogoetMnxA7OmEIpjUpCdbLYDh8rq5k+sYkenDrePL8UHrl3VWKrOCbHutU0 cSGtUAJSS+bWodv3NaE2EfWbGPl2Y7ECjknE/u+9Ce3j4XaaiX5Qb5/f5FD2nRqGIqdWN3 mGBaPiYT6bOcBxkJYmZvqiYE/01UPTo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-ZC3w-hl7O5ujKHrTwp8pgw-1; Wed, 06 Sep 2023 01:51:48 -0400 X-MC-Unique: ZC3w-hl7O5ujKHrTwp8pgw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 51287101A529; Wed, 6 Sep 2023 05:51:47 +0000 (UTC) Received: from localhost (unknown [10.72.112.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09CE120BAE72; Wed, 6 Sep 2023 05:51:44 +0000 (UTC) Date: Wed, 6 Sep 2023 13:51:42 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v2 2/9] mm: vmalloc: Rename adjust_va_to_fit_type() function Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829081142.3619-3-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 1D10E1C001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zddbus3x6yxwu9f1ci49f4oyq1ntyptc X-HE-Tag: 1693979513-182336 X-HE-Meta: U2FsdGVkX18sXg605vmBbJ8DzjuyN3vUh/Q4uxzjLSFkvi97qEX4w7/pVbZ+n/7v0gEPelnYU85wbjkuJXlHagQukKQ+PZDs28KwzHfJsv8RKZvoqttkOBbYvDFVhehplTp4rzOcDTHv9u3CmLXvLgPKw/o2duk+8FL+NQK/zSBwWRXBZUs23dLd/qrt0QSiqNe/vWKDal2G5mvDRc7I6SUi9FC2xAWhnRlfi+V4e1f/02HmRfUObueo4ccvlRmHbLgpvffDgrl60tAnrZxwu1VmkJ8MCcKTiCMo89vbgy1fO26VsQdCKpwgG2Af2puuylmPrKAOoy9rKb6MxP8un1GKxcLluiwVNeIWDMpEIW+FX+x5K2oTej61/yhtTvsijogpqc0L+z+wHsOStsXYmbirK7DZ8fRWm3kmg2RvNk36rvA3MOv7CnMtKAmWi8bLVnW/K9cNRJhGims4rMsLbtSJstYdlotuImHSC/DshsQlemxMw8faJIoEpwPxhzcg7drJDeMuPPxagXKUPAJK4hVPf03M1POAm995uVsDLbr+y/im5f59lwAhNrYufoOlrW592IgU1TQ08MamY4x53R/LlvQgaDVy94HYBfcZ6DoJ0PsItZ2V5ODLKnY9LiInqMHNyHwNr+l26bW7XRWn9Ot7PJYWbSdp3djoJ1JS7oPgb9X8b0KvdHJPx3o+VGnCmu6ZqYXrYFGEhNi/X9xhIrOV14sLqf+rS0wRQr8Un9Xh8hTDSmy/v0OP4kH1bXp7jZ9qEBNpgMhuI3AM/wInoGzSQVEBKQwXtPLMo59XwHoAaNdIq7LYA/KqBov/uhb4FbBUtHHRXR2DBd5kblw7H59MOD0vZehLQCAK5I5ZbtPbOschlwkOdTJtbS53o1bt07Sb0ZG6jc+iEFyT6Bif+qJLRDBoFg7XzpezI7wuLQirrBi3EJVHC1e3Qdew8dOqweIPo1J08pzI/U87oSj 8iFjKDWR LJb7qqW11SJlxBRM8rH914FTDngEAjZQ9Ee9ReWivXJdddH192YpdeR88N7q1I+cL2kdHt3KApZ2KICBLru4Po791DWI0yaXl8jZ6fqWWuqr0Vy9b+su6KKfP91O7LBvH9jG0F7JbNcEPGGiomSh2VRN2089ujf8eu//6QScRxecAEQiWPXStqsplkW6R97Ov+jWhtGl3J6DJCMtIc3WMbvCIBmYNwkwImBfyievMRSNKhKrj7ustmjBtQVSAa06AKNUMhVfE7CIcxlu+YXPeG2PT2+LpFOxP7spVr37mvew3KPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > This patch renames the adjust_va_to_fit_type() function > to va_clip() which is shorter and more expressive. > > There is no a functional change as a result of this patch. > > Reviewed-by: Christoph Hellwig > Reviewed-by: Lorenzo Stoakes > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 00afc1ee4756..09e315f8ea34 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1382,9 +1382,9 @@ classify_va_fit_type(struct vmap_area *va, > } > > static __always_inline int > -adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > - struct vmap_area *va, unsigned long nva_start_addr, > - unsigned long size) > +va_clip(struct rb_root *root, struct list_head *head, > + struct vmap_area *va, unsigned long nva_start_addr, > + unsigned long size) > { > struct vmap_area *lva = NULL; > enum fit_type type = classify_va_fit_type(va, nva_start_addr, size); > @@ -1500,7 +1500,7 @@ va_alloc(struct vmap_area *va, > return vend; > > /* Update the free vmap_area. */ > - ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > + ret = va_clip(root, head, va, nva_start_addr, size); > if (WARN_ON_ONCE(ret)) > return vend; > > @@ -4151,9 +4151,8 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > /* It is a BUG(), but trigger recovery instead. */ > goto recovery; > > - ret = adjust_va_to_fit_type(&free_vmap_area_root, > - &free_vmap_area_list, > - va, start, size); > + ret = va_clip(&free_vmap_area_root, > + &free_vmap_area_list, va, start, size); > if (WARN_ON_ONCE(unlikely(ret))) > /* It is a BUG(), but trigger recovery instead. */ > goto recovery; > -- > 2.30.2 > Reviewed-by: Baoquan He