From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281BAEB8FAF for ; Wed, 6 Sep 2023 12:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96E4228001A; Wed, 6 Sep 2023 08:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91EE4280017; Wed, 6 Sep 2023 08:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80D9E28001A; Wed, 6 Sep 2023 08:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7169D280017 for ; Wed, 6 Sep 2023 08:07:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A465C0DF0 for ; Wed, 6 Sep 2023 12:07:01 +0000 (UTC) X-FDA: 81206046642.29.86FBAD4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 6F79840023 for ; Wed, 6 Sep 2023 12:06:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KAoOyUKi; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694002018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xxtZLesekG5b3wFQxKCMYE9RzV9DalJ9DCN36y6rges=; b=wqfHhHjsws3cSZJ2ZqNpj2edW5lOVwACGZUzQ29yQxmRMKNkQBAlSurwT0m8qF/wPDwxR4 QuQ+GnRfz2chn7cNQK1cUTfPpr1BKzTuIrz/PEx5IeXgObVdZpQw94F9ANuwN/smqpTYIN QWDV2MQl0B0bLUAMI+GjNRdhBokOAvI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KAoOyUKi; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694002018; a=rsa-sha256; cv=none; b=b+MSX1DTMIPLGDx9bwLkUTmbxAY5msUT2pBvty3tB3qFyrr7jMML/+phO0BcrG/woLt2Qe PSj07ZVRgzIrrKeQIi9Gr8WA55Ah3hlE1UY0Annju2qYR+/JzJ9Dd9uyXbUL5YOO7wHrcl bZFn/iiCfx9GLP6PzmBMinIDrhaCCTc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xxtZLesekG5b3wFQxKCMYE9RzV9DalJ9DCN36y6rges=; b=KAoOyUKic//cS3SljhfoqVfwOG t7OA3gIUOpNAA9sB6I2SEhf0rc1Hi3hISHknlsGytlQdui4DTImSv2xtPfyAUGu/OqdBf+BL63Z8z 236J0uwDWZqgDLDQBf2wQ1dorXu2QGAuaqU7wG4/W4KLyVprOEfmIc4pMFngUYWylubzUC7tKhjfv S/U9w/yJABX6EhBgi+pc3XcrSmzgIJAR1wlOMdVwwsU4Mf3XKayxhIqwt8Q+bw5BhGkXViTp7PpHA qWPWSRsYsWWNoHMzxYVdEEthDJqsGpIHNfj2HHtEurbEqpHqcVVZ1kTWKyPQQHh+MAQYLQavtct46 PAE+j/0g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qdrJ2-0029QD-Oq; Wed, 06 Sep 2023 12:06:48 +0000 Date: Wed, 6 Sep 2023 13:06:48 +0100 From: Matthew Wilcox To: Edward AD Cc: syzbot+b591856e0f0139f83023@syzkaller.appspotmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH] mm: as the same logic with queue_pages_range Message-ID: References: <000000000000f392a60604a65085@google.com> <20230906061902.591996-1-eadavis@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906061902.591996-1-eadavis@sina.com> X-Rspam-User: X-Stat-Signature: crydn5abqrkymyh5tiia933jyynh4qxz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6F79840023 X-HE-Tag: 1694002018-531342 X-HE-Meta: U2FsdGVkX1+XPTM4GmJto9slNm9Z1XDuPWR7YCblWqqv3wEpvv63Yq+/sssb9ffCwZre0Gv9/CKFcSejCc45NqLBydYWnx5C+q11nffOhqopgN6KyEqaSLtu1rnlAhNPPn2N2bWSP9G70uaiVzVtdq26RjradZsojUSjam2nQCntNqwPQomqaKYC7o0ZyRh7UcWabM64YUeK4yis+g3eintNXkA2eDtRd1um+db2inBUq8vTIh2pULByCqyGCGs8XdbiqyZulmW+LZgjMyFH/8ytaAbAXKHGoHeCXBc7XRk/LAXHtwvpc5OaIO4r8Yq4O7HtMenNU4j3i8UPH9eqaxi1ZY/AfAaVZqLRZEJsc5liME4pyy11LVyjvJf8HPiSoMluOY95FBYq6j8WLUQtTEK0wV5YImrW0vdvs6RNlOTcpKSnEYwkeYjFJVDjhj0ZTV8w1ITNne1Qnq7sUQmSNlzMZKMwFP4dZGGz8g0/TRGd1R6JViqFHpExIODgUxz/96IfEAq8+Go6uH/QajSpeqjhyVdmG2bsT+2gJ6Ifhh1wg3L3VuE5DYA3RPqPsIbtb0K/S7zOK/2gEceY2BSb32LYqZZ+jVumQowJyyb4HexAMBcPoTVMzXdPRnb9k/qKWlXJjejdlzKoaK2tR62cgN+ir0EDQaIbS/+jpLLL3nIf6kMh2C+NMdikEvw1We48oRt19tfkhDddc+kxpoxfeFjb3sAttt1Wkll6izZ7Y8JjoRAHtcO3HWJ3L0GgeX7sHg1NdJdnfCEx5KG1vje6HK1Z1aMxmMj1EmljI3GH38sMXkWBEzogjbuKNXjaPIh3ZwpgP7SfXc/UwmbrIFhrBlI/wnEhck/mgErJfTgL0jsNcnB56s+n6tv3DEeX7+Z7hgkyPWp65O5xUBck51VfT52MeAFffEDwrh8vS+0tDiI0eCTvX43cAtIIFp4kEGid5lgAsjETS47XeiMM+Kx YEL6W41h 6Om8G4XMqFDPPzTSWLxavEJ6vznB1Lsu9TOohfI19OaayD4otV7ddAHmkD8nvpi73FERBYBZ3nj+sJ4sPLyOq3+zQ3RhUGYWBtAoSqCJmoMA+zx2YsaOYbTyQO5+ChPP0C1tpsOuRj6+th6GOAm1JMF+R9f0V1Uy7t5XKEPeKSfjoUubN6QhABEb82scHf15Y5oUBctMqDJorkVuNq4yGLf5Zxx4gYhTKTEZUJWnzmpnDft6OMbkqU21bScczy/uwPxO/P3r0rHiu+i+Valph5o0gKomw03vTEGwiYJUsSnUurgeOqrw25Z8GkvkdToNYv4bhJ3iRt8S0hYrw7M1uP5aC1hZbP96HCFrcb2k/8un1N0s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 02:19:02PM +0800, Edward AD wrote: > Only dealwith queue_pages_range locked vmas. What? > Signed-off-by: Edward AD > --- > mm/mempolicy.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 42b5567e3773..13050b968479 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1342,6 +1342,8 @@ static long do_mbind(unsigned long start, unsigned long len, > vma_iter_init(&vmi, mm, start); > prev = vma_prev(&vmi); > for_each_vma_range(vmi, vma, end) { > + if (!vma || start < vma->vm_start) > + continue; #define for_each_vma_range(__vmi, __vma, __end) \ while (((__vma) = vma_find(&(__vmi), (__end))) != NULL) How can this produce a vma that is either NULL or has a vm_start after start?