From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74FAEE14A3 for ; Wed, 6 Sep 2023 15:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84465440173; Wed, 6 Sep 2023 11:06:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3E0440151; Wed, 6 Sep 2023 11:06:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695D9440173; Wed, 6 Sep 2023 11:06:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 558ED440151 for ; Wed, 6 Sep 2023 11:06:31 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 220A21A0BC1 for ; Wed, 6 Sep 2023 15:06:31 +0000 (UTC) X-FDA: 81206498982.08.9781232 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf02.hostedemail.com (Postfix) with ESMTP id 1117E8001A for ; Wed, 6 Sep 2023 15:06:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ojqlhCrW; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694012788; a=rsa-sha256; cv=none; b=NvDeBhC/WDA8TYWN8TBtbt3U5/7EmVBJkMiUIXjlx0bHC0QxPYfvm0NBl+LQ43a07aqiL4 2zRTYOyqkf5GIvJNjSbTvvyMbehIdZRWCjphz8vvPVVX+iv+ekFtUsSsxmrotrFl5R5dD+ 1qbxaChfhqj+4iDkZmTWJZTXpe98gYA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ojqlhCrW; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694012788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=md6yvbIaCY1wIEZej5F+EGAA01mvLh1YX5R7yH3UNb4=; b=TQ01SAeRw9hPTUwFL/hYj62OgZh1rxMgFU1TNsOovPMely3HqHAmWPWFhhbykmndxTaNE/ EHEeOeP6k48N7vboSCSIyppou+dQv3XcLe+H/zI5KvenPyAH/EJeCm2p1wdankuH8vvOBj tV69vJd8PX69JoL7qPQyeqe0NZf5rUM= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bcc846fed0so59442781fa.2 for ; Wed, 06 Sep 2023 08:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694012786; x=1694617586; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=md6yvbIaCY1wIEZej5F+EGAA01mvLh1YX5R7yH3UNb4=; b=ojqlhCrWM2bpVosSYFhQGQH4ET089CcC68JVKypnRd2025gQ22qkads0am7WEXxjlv xBwwHghTGcWMg1PMezaH+Qxgt3NkqodgjiyYTPyIuvQzYwiDmZ5yngiMa1C2d++7IYiB CrFf4OttcfPptHbGFZcop7B/0vSl8cqZqXFwWCG42B5gy4bbdnn4FiVxaQRQ5vUGxG0h eayop1/7q61v9LUU8KEzjFNhiROS0Nz9Oia5woTt0COajCKQBqIqtNCUBHM2QN2BvceJ EUbNxnwdveIN8JO0UETDpQESLKdj4oN+dHijM7ttIToa4MobHpx5jplIkIixRx00OzS/ KUig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694012786; x=1694617586; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=md6yvbIaCY1wIEZej5F+EGAA01mvLh1YX5R7yH3UNb4=; b=OA1NRdQQAUQiBtycrK7xAihYCWEpvC9/+BlVWL+t3bT7PUyPCWg2AA0Tk+gqMLtC/m xgjBGBXHtt7e2L80IL7JhoXbRyE41g4HVI6Uz+ZXOnyI8Ks5cQFVRM3/2Ffc9f9w9yky 08ukGaiwsX5KAnNg068iCx9NXVCcF94No2PIzGs6oza2Q3fI9q5Maz3QOTySs43jz3R2 O9ykTUYW5mGQxdbUpS6fXomuw5xdgh08wusAzygQh1lEQVlP56YC9I8b+SezObc3LA4C LK/r4Enhu4ww6M8fzeDHUjM8TAY6Bj5bwmmuHJSUzw3ufqp1eUDOxfDuDbenpcsemUqC LqJQ== X-Gm-Message-State: AOJu0YxeFVKEtBBCFZtPtYMO27tnXtk3KVDiPlcPhzNNQEttqMtZ9Ut/ YD8hkLqdQ+QbN+YSObKtoXk= X-Google-Smtp-Source: AGHT+IFP5O3nhoAfZwg8+CxRZ3wuOldaX2B3xbaRfAFF13oHHH3QoHKizP8eph+zE53aW9DQbvTU3g== X-Received: by 2002:a2e:b16e:0:b0:2b6:e283:32cb with SMTP id a14-20020a2eb16e000000b002b6e28332cbmr2290270ljm.23.1694012786033; Wed, 06 Sep 2023 08:06:26 -0700 (PDT) Received: from pc636 (host-90-235-20-237.mobileonline.telia.com. [90.235.20.237]) by smtp.gmail.com with ESMTPSA id j12-20020a2e800c000000b002b9f0b25ff6sm3430004ljg.4.2023.09.06.08.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 08:06:25 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 6 Sep 2023 17:06:22 +0200 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v2 1/9] mm: vmalloc: Add va_alloc() helper Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1117E8001A X-Stat-Signature: 4p4fwo1i3fmk55oxdknrs98g861fxxdq X-Rspam-User: X-HE-Tag: 1694012787-742825 X-HE-Meta: U2FsdGVkX1/SaJMbXJMHdejNVnlIC82s9bJPO1pghMoLSwTOQELrdBothwcpfY2ilWm3ihBk+zAx7hPpOPTsu/BUx1pJtfIOombbH/p49jJM6PFo35IrCr4Iq/FLhLvwys/9c7rSVW5QowVyEnowH3IxM5xRFgNIJ/llFyFXkodHZTCyK3nSLAS8zJgFNsDyDDQdzuzmZdXJbSB/rMCsU0MBCOjPXuGD5qqQI+99WhCdDzTtp/VwXpTBZuBADeHGd96B093ypW4Dvnc1XDUWkdUM8RKMaN8NNTO0BZR0X7EAM6NGv3ap2xg7c0+dCYmWfjcY5EGP+e1ZNxpJYVbOXOS2fRR/mHNIif5Cfnj3rJjWIsjoGa1XvCtbVcRAkeV1aUdPNj3YjbD4NUZnTg2c6/ZtNAyW50uEMJ/OrxsXmuo04NJl5TPPcBUB5ciFkBY6oJ2ZZjj05zQQEYX0JpSj5/u8qVi9kZ4cZNAN/JXXHgcM2Q0s3hTNiO8CY7OASBN9qw1rId+NFEkLOo7XjFE9MmuSYJjkkhjY2lmv2t4kUoXYUjXVKvUwq7f5oAwfETEl8AJlJI8KzPjtX+0Kd73Pl4MRefUnKPPCgscoKDcrXH8i4v+ddAMSeCHWbHnh6tmgTVxlJx/duKK93fNsOQa9p+B8I2ZIXH7nFlyXRNy616qeNikitRyDD5u3F8VVI0WVmWj3io/UKHbCL6L+qyXSkRdI9jcHlaUb8sAOAILRDrBkU0VC2rBo0KpU43hJwNPrfJ3ql0ifcCVXvN3KHk3A9jwW8XbKq5Q64YGuX/kPoA0XsXFL2yP7/pv62C1SmL8uybs1SwZ1EvRR1igUP//8ONb4lTvuHdA6Re8FHd5ZfNNt0I7rwiKxuhrDiJkQFJsFtMB4QfAQg6wRl8gyZbjOqAPTXKJyJIEPRzIsk/HDxKBrc056u3HhzIBbu0uW3ltOVQxqVpEt+iJV8XkYAXB +LZqffvg Ce+XbzkrizY+LS5J2nsdE2UqQ6UqRxcn/k0sjih9On4V49F12FXF9Sc8FHpzGA/XQh6i+vDUaFAaHCKTViIN29z9t7mdBYyrbNcP6N7LSb2FDxHikDdEhkYFj6QsMkWDkkoOtrhT0u/5MKLnhKz9zc81ZKWleclIzlpIKdXmwVnjsgdISZNdrSzU7iTAelV7fptKQytpqJAGEBFSrVMs9M27lFHwvdlyKJR4+mvGoj2jLHC/RWm0zsPXU+o8ltQTog/C684lfgWAGCrbxf5YXuqD4lKrrTHzblrDqIefRBpL7k5Q3O+yJ+bpBf9/nvWZ1vHNhM7VcEU7EGPStKht0FcNTY8gK4yC5JdFOzOgp60PBQP68EJ2DyCZOcg2ZoLS4EyhlFWm/eER2CR1xXNIQfexB8S1TolXdXNb0zwynQqjFo40xCbdIp6AUMLBUM05rBQXwguJ7Mf7/P+2jBNT8GQPgnXb/SmwasvvuRcKDHeL5wuOd/EeU5TQrthwnPLXwg9HTBuwLARbHsVkQ/W8FQbbwXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 01:51:03PM +0800, Baoquan He wrote: > On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > > Currently __alloc_vmap_area() function contains an open codded > > logic that finds and adjusts a VA based on allocation request. > > > > Introduce a va_alloc() helper that adjusts found VA only. It > > will be used later at least in two places. > > > > There is no a functional change as a result of this patch. > > > > Reviewed-by: Christoph Hellwig > > Reviewed-by: Lorenzo Stoakes > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 41 ++++++++++++++++++++++++++++------------- > > 1 file changed, 28 insertions(+), 13 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 93cf99aba335..00afc1ee4756 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1481,6 +1481,32 @@ adjust_va_to_fit_type(struct rb_root *root, struct list_head *head, > > return 0; > > } > > > > +static unsigned long > > +va_alloc(struct vmap_area *va, > > + struct rb_root *root, struct list_head *head, > > + unsigned long size, unsigned long align, > > + unsigned long vstart, unsigned long vend) > > +{ > > + unsigned long nva_start_addr; > > + int ret; > > + > > + if (va->va_start > vstart) > > + nva_start_addr = ALIGN(va->va_start, align); > > + else > > + nva_start_addr = ALIGN(vstart, align); > > + > > + /* Check the "vend" restriction. */ > > + if (nva_start_addr + size > vend) > > + return vend; > > + > > + /* Update the free vmap_area. */ > > + ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > > + if (WARN_ON_ONCE(ret)) > > + return vend; > > + > > + return nva_start_addr; > > +} > > + > > /* > > * Returns a start address of the newly allocated area, if success. > > * Otherwise a vend is returned that indicates failure. > > @@ -1493,7 +1519,6 @@ __alloc_vmap_area(struct rb_root *root, struct list_head *head, > > bool adjust_search_size = true; > > unsigned long nva_start_addr; > > struct vmap_area *va; > > - int ret; > > > > /* > > * Do not adjust when: > > @@ -1511,18 +1536,8 @@ __alloc_vmap_area(struct rb_root *root, struct list_head *head, > > if (unlikely(!va)) > > return vend; > > > > - if (va->va_start > vstart) > > - nva_start_addr = ALIGN(va->va_start, align); > > - else > > - nva_start_addr = ALIGN(vstart, align); > > - > > - /* Check the "vend" restriction. */ > > - if (nva_start_addr + size > vend) > > - return vend; > > - > > - /* Update the free vmap_area. */ > > - ret = adjust_va_to_fit_type(root, head, va, nva_start_addr, size); > > - if (WARN_ON_ONCE(ret)) > > + nva_start_addr = va_alloc(va, root, head, size, align, vstart, vend); > > + if (nva_start_addr == vend) > > return vend; > > > > #if DEBUG_AUGMENT_LOWEST_MATCH_CHECK > > -- > > 2.30.2 > > Reviewed-by: Baoquan He > Thanks, i picked it for V3. -- Uladzislau Rezki