From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD13EE14A5 for ; Wed, 6 Sep 2023 16:29:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B18F98D0015; Wed, 6 Sep 2023 12:29:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9A58D0005; Wed, 6 Sep 2023 12:29:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 991628D0015; Wed, 6 Sep 2023 12:29:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 870B48D0005 for ; Wed, 6 Sep 2023 12:29:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 666FE160DB4 for ; Wed, 6 Sep 2023 16:29:35 +0000 (UTC) X-FDA: 81206708310.15.261EF97 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf11.hostedemail.com (Postfix) with ESMTP id 6819E4000C for ; Wed, 6 Sep 2023 16:29:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Tk9Dzctj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694017773; a=rsa-sha256; cv=none; b=fzVNdK7qdfETfNn8mrgMaU5JKFtRObi07VdIMdPl90Ut2fHbZTgQVyaIP/X+fVOOG2cZwB PH2txNruYwZUGmff5q4d/kh5rWZvvnqVceYHidtC9zf9ey/8N9kZ+E+7p3iZ/yW46dudKD UBNEthnDcvG0maYZYxXXWrw3vuEgEXQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Tk9Dzctj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694017773; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xt74OUm6mXGe6ONc5vzMIVlJ1a8JtseT6g4gQMDvneo=; b=oyJwqhNVeOzbthISs3UJuhuON2IXuAj0rMfibFZoIf6/fszbh8+LONuhJ6ttbmLmUJ5QM2 cgkkQClcvKxFrRXP7NgeuZmOz0TVFI2xevhTmXRzOhzBLy97h2Zj86gDf4hNcTyh5egTdz HDhMjeFdpdXPaY82zOnTzUts3XFhJrc= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-501bd6f7d11so3467933e87.1 for ; Wed, 06 Sep 2023 09:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694017772; x=1694622572; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=xt74OUm6mXGe6ONc5vzMIVlJ1a8JtseT6g4gQMDvneo=; b=Tk9Dzctj9z8s+m5Obqglzj3dI3QRF9v20VHkUctVRDL918M5boqBST3mlJ+W3sqz7G 75LjC9upupNCS46IPHHRVOtl9M114HWXw1qtq52OVzmmZ2KTI0ReNRKsicR4M2/Z04Za u6oXTo/V3FsNgd1BjGwJ58brsaK2YemPlsiASNfnPo1xDccdxzbebu5ygEmUiNQfeaO7 i/qON5lnSh14gTR41RlQ+HjA/K0VEpacB0jOMiIh+Rn399GH0T833XWSe+k/MNjdquab X2OVBeD6Yq8+g8pCA6t+mA5LkE5OjtxaOkBRl9vIrxhjxIyvp8ZVCgV+4BkECe8m6lun +CFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694017772; x=1694622572; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xt74OUm6mXGe6ONc5vzMIVlJ1a8JtseT6g4gQMDvneo=; b=CBKtlzOxDuE5AbYQ8VwL57l48Xk3OPZN8YewPoOTh36l/e46dTVKfbwhl96SaYSUNb TfsSi6beRxnfrvAtsH4LELe73856kJMWtLhdbjznXMAZBnQz1s/3f6Dv7epLk0Aw9Q3j ApD5ojLxJaAd1EFLwND1dEaY/RiGmJxKfk7K2K9DD/YKMlODQvfBFF4KgjQMZmJ5SLrx t3DqdpDkli4yu+B3Zunp6RVMnUsE2Ex8HLT7q7ngEqM6Hd3djnEKh25Enb5Sao5C3N9z Outx1ObOaf7FwfDPhMUpn9Qu3y5YhNMg/U8vnph290+wVk3NEzNp1/pKXBgp5D2EhaoH DKig== X-Gm-Message-State: AOJu0YzBK29kl9cz/PyCgy+ttwznZzwEe0XYevJpp4mazL0mfko0d+wt YUJIP598KOo44xWp6Py1q1g= X-Google-Smtp-Source: AGHT+IE782HP7mYnEUI6Gy5MiSkzRhmUBtE+OICSihXHHrCrIfc0lgF58YfkqNY9IcAsnO8QmVzW+Q== X-Received: by 2002:a05:6512:3c84:b0:500:b891:779b with SMTP id h4-20020a0565123c8400b00500b891779bmr3245543lfv.51.1694017771652; Wed, 06 Sep 2023 09:29:31 -0700 (PDT) Received: from pc636 (host-90-235-20-237.mobileonline.telia.com. [90.235.20.237]) by smtp.gmail.com with ESMTPSA id e3-20020ac25463000000b004fdb85646f1sm2817812lfn.201.2023.09.06.09.29.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 09:29:31 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 6 Sep 2023 18:29:28 +0200 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v2 3/9] mm: vmalloc: Move vmap_init_free_space() down in vmalloc.c Message-ID: References: <20230829081142.3619-1-urezki@gmail.com> <20230829081142.3619-4-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6819E4000C X-Stat-Signature: ccztr7rn8bs7bp68eb6s3yommgi1g7mf X-HE-Tag: 1694017773-638025 X-HE-Meta: U2FsdGVkX1+oB9iFHtUiCwApXevLOkawUsioC2FauEcfPigUpOzjLr4wd6DEPUgHuyQ5cjytYSwhCwCkL6RwuZzuZWB3lsrJRlUzwvTvG9UKw8Lgp53temzLPg9cCdYNcIxBjo+MSGhyMsMyCN66G+jQ7fFU63KJWRhzCU4QkKImDG69cem5Kj/8i+apxTzzPCIXncjs/FFUZwik2gfQA3Uv0OnO90UxDDs/OQDsmSDJEQA3M98V3/JwFTcncOLmWkFwKPcIMeDxIvidbMnhqt9iBhrdXd2ZfPfzlHQLY8KSiPgcLcY2ePBXb+PYMVAjh1KKESLGiL72kHfDST2ZUVCQoIWEWob6vBLu0nTDzFsOESUxravGFLNdN2KqFhTITFqX4C4hYPbew/TceE6gBzIQyOwcDjufrRdwQAStLW7mII3u74lc3RgBFDQGHPVsumqFdMyYYusw/KQkp9H0IYxzVRHm31ctLves6zqHLWocJmXC0ZAAVlYbcirfFaEHsCgg09j3UhuGh+jToev+gJDIn9BhT6YpgTxORg9Rj+bDVTBK/Mscv2YIHkp+esJ2DYzqYyF8N3dzkCiIjNkNP9Ng+zA3+Yk4j2nJPILPeh8lo06JZ85MmsCx/aqQShNwcWkJT7l8sktD1wSKS9X77RCoHDGWQlT+DKMxMszavB1lZda8ioYqB4EEsC8LrBwLdjoTd6dtnJcqjc10UsZwR/ePcM0vNWw17jCRh6xMxN1xK/78s6hDpqLDu0fUMvbG8S2AThQtpl/emtANhmoR6bzheRE+ygRONzus9XnbPOrnTcADqdH1d9qu7ZhAF0h/Nkq4Iq8l3xXqPgVzg3M+d8+BFnWavdKXDT99A+VBBBQK3LdamBGM0OKY2UdVbSLbp+sWr7ijuKNUTAo2lvXIiRhMs+q/JhjcZmJ6q4/tCdU1TVm/yiB+jhuZT/eRtN7ZaufumAF1Bu6B2m+sBfu CPOTsSNR qDmtnDAHNj2smvmIq/pGNq1Z1HEpfCIeyNhga8SMVwVxbjDH4oR2EeoleMIOvEvA+WlNkDiI2Phw1gueMBsKNcmCgtoEavUFOl5fiVbXQiCAVBIi26JiGw+i+MC/nwd9Hed/DykI3gcaSYRanLH6kyuBfCmXW65jw46inCQM1wyXyNAUwNcmY3R+CgLRyswkBccqfRYO6J6pKjZrdakg9IUzLXmK7GwLOIhL9lTctAAZ1EVQLC5PeWjjPoKyxREBy+HBb+7xPgLpIxr8KiGYGNNNjP4uKWBUP66/5jafKTV4YaHt7lhCFMHCC5yeqYXTrEvLeInCzVEBVTnqD5bATNkYMBgnkS4Nkh6rGd0BfvQPKnztJBFeSYjCwAl87hnjbHxYuIm2wnVPg3idsTmkEFj2eRAjq9868lhUGXiTgQNwRgrVdnUgdAP5npVYL1bIGW0amg7x9qCbbyfak6PhgxU1Oo7fTN+jt6UETkBB/wJgt3Oa/aWIhgpgG0gX7XL18IaaF/ofQG0PhanYnLGtG3hQmdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 06, 2023 at 01:52:08PM +0800, Baoquan He wrote: > On 08/29/23 at 10:11am, Uladzislau Rezki (Sony) wrote: > > A vmap_init_free_space() is a function that setups a vmap space > > and is considered as part of initialization phase. Since a main > > entry which is vmalloc_init(), has been moved down in vmalloc.c > > it makes sense to follow the pattern. > > > > There is no a functional change as a result of this patch. > > > > Reviewed-by: Christoph Hellwig > > Reviewed-by: Lorenzo Stoakes > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 82 ++++++++++++++++++++++++++-------------------------- > > 1 file changed, 41 insertions(+), 41 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 09e315f8ea34..b7deacca1483 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -2512,47 +2512,6 @@ void __init vm_area_register_early(struct vm_struct *vm, size_t align) > > kasan_populate_early_vm_area_shadow(vm->addr, vm->size); > > } > > > > -static void vmap_init_free_space(void) > > -{ > > - unsigned long vmap_start = 1; > > - const unsigned long vmap_end = ULONG_MAX; > > - struct vmap_area *busy, *free; > > - > > - /* > > - * B F B B B F > > - * -|-----|.....|-----|-----|-----|.....|- > > - * | The KVA space | > > - * |<--------------------------------->| > > - */ > > - list_for_each_entry(busy, &vmap_area_list, list) { > > - if (busy->va_start - vmap_start > 0) { > > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > > - if (!WARN_ON_ONCE(!free)) { > > - free->va_start = vmap_start; > > - free->va_end = busy->va_start; > > - > > - insert_vmap_area_augment(free, NULL, > > - &free_vmap_area_root, > > - &free_vmap_area_list); > > - } > > - } > > - > > - vmap_start = busy->va_end; > > - } > > - > > - if (vmap_end - vmap_start > 0) { > > - free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > > - if (!WARN_ON_ONCE(!free)) { > > - free->va_start = vmap_start; > > - free->va_end = vmap_end; > > - > > - insert_vmap_area_augment(free, NULL, > > - &free_vmap_area_root, > > - &free_vmap_area_list); > > - } > > - } > > -} > > - > > static inline void setup_vmalloc_vm_locked(struct vm_struct *vm, > > struct vmap_area *va, unsigned long flags, const void *caller) > > { > > @@ -4443,6 +4402,47 @@ module_init(proc_vmalloc_init); > > > > #endif > > > > +static void vmap_init_free_space(void) > > +{ > > + unsigned long vmap_start = 1; > > + const unsigned long vmap_end = ULONG_MAX; > > + struct vmap_area *busy, *free; > > + > > + /* > > + * B F B B B F > > + * -|-----|.....|-----|-----|-----|.....|- > > + * | The KVA space | > > + * |<--------------------------------->| > > + */ > > + list_for_each_entry(busy, &vmap_area_list, list) { > > + if (busy->va_start - vmap_start > 0) { > > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > > + if (!WARN_ON_ONCE(!free)) { > > + free->va_start = vmap_start; > > + free->va_end = busy->va_start; > > + > > + insert_vmap_area_augment(free, NULL, > > + &free_vmap_area_root, > > + &free_vmap_area_list); > > + } > > + } > > + > > + vmap_start = busy->va_end; > > + } > > + > > + if (vmap_end - vmap_start > 0) { > > + free = kmem_cache_zalloc(vmap_area_cachep, GFP_NOWAIT); > > + if (!WARN_ON_ONCE(!free)) { > > + free->va_start = vmap_start; > > + free->va_end = vmap_end; > > + > > + insert_vmap_area_augment(free, NULL, > > + &free_vmap_area_root, > > + &free_vmap_area_list); > > + } > > + } > > +} > > + > > void __init vmalloc_init(void) > > { > > struct vmap_area *va; > > -- > > 2.30.2 > > > > Reviewed-by: Baoquan He > Thanks! -- Uladzislau Rezki