From: Matthew Wilcox <willy@infradead.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com,
muchun.song@linux.dev, glider@google.com, elver@google.com,
dvyukov@google.com, rppt@kernel.org, david@redhat.com,
osalvador@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com
Subject: Re: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page
Date: Fri, 22 Sep 2023 08:47:15 +0100 [thread overview]
Message-ID: <ZQ1Gg533lODfqvWd@casper.infradead.org> (raw)
In-Reply-To: <20230922070923.355656-2-yajun.deng@linux.dev>
On Fri, Sep 22, 2023 at 03:09:20PM +0800, Yajun Deng wrote:
> - __init_single_page(page, pfn, zone, nid);
> + __init_single_page(page, pfn, zone, nid, true, false);
So Linus has just had a big rant about not doing bool flags to
functions. And in particular _multiple_ bool flags to functions.
ie this should be:
#define INIT_PAGE_COUNT (1 << 0)
#define INIT_PAGE_RESERVED (1 << 1)
__init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT);
or something similar.
I have no judgement on the merits of this patch so far. Do you have
performance numbers for each of these patches? Some of them seem quite
unlikely to actually help, at least on a machine which is constrained
by cacheline fetches.
next prev parent reply other threads:[~2023-09-22 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 7:09 [PATCH 0/4] mm: Don't set and reset page count in MEMINIT_EARLY Yajun Deng
2023-09-22 7:09 ` [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page Yajun Deng
2023-09-22 7:47 ` Matthew Wilcox [this message]
2023-09-22 7:48 ` David Hildenbrand
2023-09-22 8:08 ` Mike Rapoport
2023-09-22 7:09 ` [PATCH 2/4] mm: Introduce MEMINIT_LATE context Yajun Deng
2023-09-22 7:09 ` [PATCH 3/4] mm: Set page count and mark page reserved in reserve_bootmem_region Yajun Deng
2023-09-22 7:09 ` [PATCH 4/4] mm: don't set page count in deferred_init_pages Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ1Gg533lODfqvWd@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).