From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BB8CD4F3B for ; Fri, 22 Sep 2023 09:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 852046B02AC; Fri, 22 Sep 2023 05:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 828A36B02AD; Fri, 22 Sep 2023 05:35:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 718AF6B02AE; Fri, 22 Sep 2023 05:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6299F6B02AC for ; Fri, 22 Sep 2023 05:35:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3BBFF1A09F9 for ; Fri, 22 Sep 2023 09:35:10 +0000 (UTC) X-FDA: 81263724780.02.66038A5 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 53B3A180020 for ; Fri, 22 Sep 2023 09:35:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MwenzlLG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695375308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PTRcAdPYlN/VHO8FKzfnqIxG4I6YBXrgONS3QPJcMq8=; b=JafBSqZP1JX6MLst8tLPS/DuCFLJJi8EL4feW0K8hen4hjQeu29KHnlxV6U+3I58XhMnSB YWPFwbm4FYY45TiKuHCRU8J55uaC7mvTscf2dBlP+tNNbNVxpH2b8Wn6EALRAjIk9Bwgi9 UMU8ZMDD9V24D3QH6ZMp4Raog6U1rQg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MwenzlLG; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695375308; a=rsa-sha256; cv=none; b=tYJPBb7a5dAJNOTEqZ5dcC9yJMioIVOolVrQsTAH2GuXPAjOi2gcNR+oiZNYMIKEihh3qM 5403lpIRKCzXno1DraAySRojgD5jw6Q+xhUu3G40Uv5dRlADXy7dQ6O3dRLUK8W6XcFSf1 q7hV/7fBhD/YXU0Wdu7m5S6t3sXw9OA= Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-307d58b3efbso1751403f8f.0 for ; Fri, 22 Sep 2023 02:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695375307; x=1695980107; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=PTRcAdPYlN/VHO8FKzfnqIxG4I6YBXrgONS3QPJcMq8=; b=MwenzlLGbE/+YVxVp98SyCv64ndjorGmAS2Gajvy00QBq8dahAec4qYaqCzHpX0bLP tNninnNKbOEle/+cjxtrC8BG0qySy/PO7lU6dNUQsBJas9j+QsOcZdkjOM69N5lkJliJ hKkw4lF6tjG8sYxa+t22QfZ7BKszsQjoQYGYfb4Zn5k6JmiZGHBSIlE56ssfaUh5dnQm Ec60p9llo43SZg9Z42cZVzzYC2oc8Ajuid6T8SeN00BuwPq28UiKpJ7JQ3RQRBvDu03P ij9LPAkNh3wtiucsR0M8R4Hpl7AGdLCyvl5fl4ZBMk73VVMJl9XDV+O0ILwCnWqXoOH/ 5xNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695375307; x=1695980107; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PTRcAdPYlN/VHO8FKzfnqIxG4I6YBXrgONS3QPJcMq8=; b=tO6OLIzr1IurO80jHzQ6kic61S8kMPUz/yhi9DzslfheLkC6st6BcikUzlO38MdKmG b12y35RK0cU0135VxSPV9YbQ84GPBiVJtNhngba0JOttvI4rvYdOtEreNarr7sI1R/Fg /YBGBPV1Q1wsAyIMFKpY1BzwNPCvCaQJSaVwOwOtbn0sw83MFeQNtM0MvKHSftP4/QjS BjiFPXQTH0rKZxlDbofgpcenWjhvqEefKz/a7H89mAmZ7jZJRR584WDUTUBcapMWF6rN EQkxTz0Vz+F+Z4JKjqI3Y0T3bXe8mxnHAPiG6FK2G9aoeHL7H29DvsVn76LdmmdnI/Xr wiSw== X-Gm-Message-State: AOJu0YxaZDl+AzYqh+qOpGxSucmjpuwKrVGvt7zLuZMI5VkEQfF+qWEi gvWTHT2nPvC1ZM1lyOl4Kbs= X-Google-Smtp-Source: AGHT+IHgk2oAySrEJX2mQ/nnZhq8OwQDyWgRq6/WsNVQQ6OGQjV4H9P7ur5I0ax4wch7C5zJrWdveA== X-Received: by 2002:adf:fc0d:0:b0:314:152d:f8db with SMTP id i13-20020adffc0d000000b00314152df8dbmr6957471wrr.58.1695375306573; Fri, 22 Sep 2023 02:35:06 -0700 (PDT) Received: from gmail.com (1F2EF49C.nat.pool.telekom.hu. [31.46.244.156]) by smtp.gmail.com with ESMTPSA id v9-20020a5d4b09000000b0032008f99216sm4038542wrq.96.2023.09.22.02.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 02:35:05 -0700 (PDT) Date: Fri, 22 Sep 2023 11:35:03 +0200 From: Ingo Molnar To: peterz@infradead.org Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de, Geert Uytterhoeven Subject: Re: [PATCH v3 10/15] futex: Add sys_futex_requeue() Message-ID: References: <20230921104505.717750284@noisy.programming.kicks-ass.net> <20230921105248.511860556@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921105248.511860556@noisy.programming.kicks-ass.net> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 53B3A180020 X-Stat-Signature: u1drd4k1qacmrjnfxkgizcwd63yhc6b9 X-Rspam-User: X-HE-Tag: 1695375308-962496 X-HE-Meta: U2FsdGVkX1+aVtH53phnmmn6PPsFf2FL+8WvyXYqtMjoq1u7TiyfWDPpgmbowTLnVrVPXP1uoK+Rdjsr4sO0MFt93UnSZVkzGEgrCGtT3fMwvRAY8Tkt2M8hmN1mx7B3WhUdrg1NegCPl2rDBFIsugE9thdDW4yfLulElKxoZbybcOwhRXt8Gx1aO3A87QMwI5hQ9ZA8DMkgg7JCQ02t8J8LCAs/HK1x/+HtSapZpokpO9e/10y95K1ULZKwy44njz66OUCl3xtuq26u1ff0FEKjbBbFt9ZVZBKoSoXW4s8yLEEAyanRQGvxyumDveHz8OqNL5IEG0mcgodqSTrBfhSxpylF2W+xBDI+u8AEniaHbG66nsnasybavv3nvvAigpX9fUUCYnV5z2o6h/oYsdEb8LAdH2Ti/fKZIQbfAA522UpMg/1XBiS/pfGAI4St+RBp6VGS4wz0TIoqZrw7jmc3Ng6NYsFv1rqbUQ3aLMbCHG0GBI9roBBoAZMV2u5L09MrehfcHrVsErngw/L9Hq6ESq3DA2b+fmJtz8gL8TeQFMskOJCooRXZF2SHTCI/NjnwXg6O8477/e3osXVj1YH/4YOLw6PQWmSj8ftPl9/0TVeMX6EUaASybrvBBEi3jngXoEBqC3vUFmShE4mbEagAg3G/BeuELGH8K/PxvhnVHzKeH7ju1t39Xhn/4CJ5LPHraiLab/LFYZluF5p1GAsX14RngHit9vjYnKIyYyfMpYNh+Em2X6SuLsv0sTflz+5+GxNC1cubXkdSLoEPmVVCFYCY2W+iFQsOLwDdYlLBYtNYenQQOBeDD/uuHsg8ocJaXAzaLQHxmNPb+WwdAf+yYCwUKrHp9JyhPa5Fk/p/eeup9uvP/7zfb6wkt/hs4n2dDcHEAV5DS+XYdeWfpHsPjW5Div090Un29Duu0iek1PCSJmrur2bCOZn+ieTWYttDjn7vhEcZQgDxbvK ANfZbFAL UN7felJ2+kYT3i7v9gLxazq465piExPcqBMKuUiNPr3AfRs1Bx9pCKVm8+/KjUbuhiwh4BzHpHvq/wXXOXLDUO0jihfpyETZMb0ouKV1eGBu3qk/NTPYUtEVPd56JRcyouT2bHLYP61repoQyjGsG9VPQ7kQvSltGuyJMglLuVcGIEDzExPrsC9QIyw2Vl6FRzkn6RGkUpQW5eixLxn1ktWd8kaq+oOIPx2vzr3u4QPJgu2Gb1gu0RKj0QT55qMC29WumTqvTv6xQ+QGXx2n1yHvX7dsKY9t5aQZlwHs7jL2iZyjEA9JrlxLucMEsfHIgmU+p2GGu09hOfW0RqmLLM+5XzlXHdb+9pMnmq7ZKnqc96nBKQt28oTTZ5BJE81HNUpvShLhJPUFCwDN5aDK/wOZjvHOxz0pmDlWeLJlKJSQmOFrY0WDUCDTpHOXsmjNkruBJHPBH9H3Jb8k7lw5xhzY4htZQo16C8AL5LxnUloMlxXgOEqugcZGwnQ3bZ6TtsAfqE6fsee2GrLSiOC8PQA0BBuC3fIWSzkNooPD4br6jz2Jb+QNQRGo7zKK9BGkmtegpR74tqx9l/LjsP4DaiDs/uHnJLX2/SSKWbqH8pM5wur6I+wkXw8aMog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * peterz@infradead.org wrote: > --- linux-2.6.orig/kernel/futex/syscalls.c > +++ linux-2.6/kernel/futex/syscalls.c > @@ -396,6 +396,44 @@ SYSCALL_DEFINE6(futex_wait, > return ret; > } > > +/* > + * sys_futex_requeue - Requeue a waiter from one futex to another > + * @waiters: array describing the source and destination futex > + * @flags: unused > + * @nr_wake: number of futexes to wake > + * @nr_requeue: number of futexes to requeue > + * > + * Identical to the traditional FUTEX_CMP_REQUEUE op, except it is part of the > + * futex2 family of calls. > + */ > + > +SYSCALL_DEFINE4(futex_requeue, > + struct futex_waitv __user *, waiters, > + unsigned int, flags, > + int, nr_wake, > + int, nr_requeue) > +{ > + struct futex_vector futexes[2]; > + u32 cmpval; > + int ret; > + > + if (flags) > + return -EINVAL; Small detail, but isn't -ENOSYS the canonical error code for functionality not yet implemented - which the unused 'flags' ABI is arguably? -EINVAL is for recognized but incorrect parameters, such as: > + if (!waiters) > + return -EINVAL; Thanks, Ingo